You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/05 07:22:17 UTC

[GitHub] [incubator-nuttx] yamt opened a new pull request #2983: esp32: Extract memory layout definitions to a separate header

yamt opened a new pull request #2983:
URL: https://github.com/apache/incubator-nuttx/pull/2983


   ## Summary
   esp32: Extract memory layout definitions to a separate header
   ## Impact
   
   ## Testing
   build tested


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2983: esp32: Extract memory layout definitions to a separate header

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2983:
URL: https://github.com/apache/incubator-nuttx/pull/2983


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2983: esp32: Extract memory layout definitions to a separate header

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2983:
URL: https://github.com/apache/incubator-nuttx/pull/2983#issuecomment-791268698


   @yamt could you please squash the two commits?  I think since it's a new file with no code leveraged, it does matter where the license came from.
   
   BTW, I've got a few changes for this layout that I'm about to push.  It changes a bit the layout and introduces a couple of regions (mostly in SMP).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2983: esp32: Extract memory layout definitions to a separate header

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2983:
URL: https://github.com/apache/incubator-nuttx/pull/2983#issuecomment-791297571


   > i don't think it's appropriate to squash them.
   
   Ok.
   
   > ok. do you want to make your change in before this one?
   
   I wanted to, but let's not hold this one.  I'll rebase once merged and update the comments.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #2983: esp32: Extract memory layout definitions to a separate header

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2983:
URL: https://github.com/apache/incubator-nuttx/pull/2983#issuecomment-791273648


   > @yamt could you please squash the two commits? I think since it's a new file with no code leveraged, it does matter where the license came from.
   
   i don't think it's appropriate to squash them.
   
   it isn't "a new file with no code leveraged". it's a code extracted from the existing file.
   so it should inherit the original copyright notice.
   
   the license change is a logically independent change.
   it's in the same PR just because we have a policy to avoid adding a file with non apache license.
   
   > 
   > BTW, I've got a few changes for this layout that I'm about to push. It changes a bit the layout and introduces a couple of regions (mostly in SMP).
   
   ok. do you want to make your change in before this one?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org