You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/27 16:31:58 UTC
[GitHub] [arrow] daattali opened a new pull request, #14744: {rlang} dependency must be at least version 1.0.0 because of check_dots_empty
daattali opened a new pull request, #14744:
URL: https://github.com/apache/arrow/pull/14744
The function rlang::check_dots_empty() is used in this package. That function only became available in rlang version 1.0.0, so that version should be specified as the minimum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14744: {rlang} dependency must be at least version 1.0.0 because of check_dots_empty
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14744:
URL: https://github.com/apache/arrow/pull/14744#issuecomment-1328286226
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche merged pull request #14744: GH-14745: [R] {rlang} dependency must be at least version 1.0.0 because of check_dots_empty
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche merged PR #14744:
URL: https://github.com/apache/arrow/pull/14744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #14744: GH-14745: [R] {rlang} dependency must be at least version 1.0.0 because of check_dots_empty
Posted by GitBox <gi...@apache.org>.
thisisnic commented on PR #14744:
URL: https://github.com/apache/arrow/pull/14744#issuecomment-1328748562
Unfortunately, the upgraded version of rlang has different (better!) error messages, and so there are test failures on CI as our testthat snapshots need updating too. @daattali - would you mind either updating them, or [allowing me to push to your fork](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) and I'll make those updates myself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] daattali commented on pull request #14744: GH-14745: [R] {rlang} dependency must be at least version 1.0.0 because of check_dots_empty
Posted by GitBox <gi...@apache.org>.
daattali commented on PR #14744:
URL: https://github.com/apache/arrow/pull/14744#issuecomment-1328320431
Edited title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] daattali commented on pull request #14744: GH-14745: [R] {rlang} dependency must be at least version 1.0.0 because of check_dots_empty
Posted by GitBox <gi...@apache.org>.
daattali commented on PR #14744:
URL: https://github.com/apache/arrow/pull/14744#issuecomment-1329296846
The "Allow edits by maintainers" box is checked, you should be able to edit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14744: GH-14745: [R] {rlang} dependency must be at least version 1.0.0 because of check_dots_empty
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14744:
URL: https://github.com/apache/arrow/pull/14744#issuecomment-1331492200
Benchmark runs are scheduled for baseline = a594e38fad126a63c952e0fd84e773f80fc3b3f0 and contender = fde7b937c84eaad842ab0457d2490c6c8c244697. fde7b937c84eaad842ab0457d2490c6c8c244697 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9724977dfa5f49e5a0c225f10aebcb83...feeaa2bda00741d294aaf2f79a1c0b7e/)
[Failed :arrow_down:0.2% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/41b40504458344549b3122d6ab3f3068...b4dd3ce16b724062a4369f5e885b559f/)
[Finished :arrow_down:0.54% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8a1000f38f5849a9aaaf1dcc92024de7...ae9380505d7048b4b2b95412f3a47f8e/)
[Finished :arrow_down:0.14% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fa3afccbea2f4745a30d150a316c5506...94ef9b808cac49bdb99819243f751421/)
Buildkite builds:
[Finished] [`fde7b937` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1944)
[Failed] [`fde7b937` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1966)
[Finished] [`fde7b937` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1936)
[Finished] [`fde7b937` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1958)
[Finished] [`a594e38f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1943)
[Finished] [`a594e38f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1965)
[Finished] [`a594e38f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1935)
[Finished] [`a594e38f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1957)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org