You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/15 03:46:40 UTC
[GitHub] [kafka] OneCricketeer commented on a change in pull request #8489: KAFKA-9857:Failed to build image ducker-ak-openjdk-8 on arm
OneCricketeer commented on a change in pull request #8489:
URL: https://github.com/apache/kafka/pull/8489#discussion_r425549885
##########
File path: tests/docker/ducker-ak
##########
@@ -42,7 +42,14 @@ docker_run_memory_limit="2000m"
default_num_nodes=14
# The default OpenJDK base image.
-default_jdk="openjdk:8"
Review comment:
So, you could've kept this
##########
File path: tests/docker/ducker-ak
##########
@@ -42,7 +42,14 @@ docker_run_memory_limit="2000m"
default_num_nodes=14
# The default OpenJDK base image.
-default_jdk="openjdk:8"
+case "$(uname -m)" in
+ aarch64)
+ default_jdk="arm64v8/openjdk:11"
+ ;;
+ *)
+ default_jdk="openjdk:11"
Review comment:
Then the wild card wouldn't be necessary
##########
File path: tests/docker/ducker-ak
##########
@@ -42,7 +42,14 @@ docker_run_memory_limit="2000m"
default_num_nodes=14
# The default OpenJDK base image.
-default_jdk="openjdk:8"
+case "$(uname -m)" in
+ aarch64)
+ default_jdk="arm64v8/openjdk:11"
Review comment:
Then done `default_jdk=arm64v8/${default_jdk}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org