You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2019/08/06 12:39:00 UTC

[jira] [Commented] (OAK-8521) Add shutdown hook for oak-run commands

    [ https://issues.apache.org/jira/browse/OAK-8521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900986#comment-16900986 ] 

Marcel Reutegger commented on OAK-8521:
---------------------------------------

Vinod proposed changes in https://github.com/apache/jackrabbit-oak/pull/137

> Add shutdown hook for oak-run commands
> --------------------------------------
>
>                 Key: OAK-8521
>                 URL: https://issues.apache.org/jira/browse/OAK-8521
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk, run
>            Reporter: Vinod Holani
>            Assignee: Marcel Reutegger
>            Priority: Minor
>         Attachments: OAK-8521.patch
>
>
> Ensure there are shutdown hooks in place for the various oak-run commands that properly stop the repository and release the clusterId.
> Many command construct a repository, then perform some operation and then shut down the repository again. Shutting down the repository will release the clusterId change the state of the clusterNodes entry back to inactive. In some cases commands execute for a longer period of time and a user might kill the process. When this happens, the clusterId is not released and stays in the active state with a lease that eventually expires. The command implementations should be improved to register a JVM shutdown hook that ensures the repository is shut down, even when the process is killed.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)