You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/24 08:53:25 UTC

[GitHub] [spark] beliefer commented on a diff in pull request #38745: [SPARK-37099][SQL] Optimize the filter based on rank-like window function by reduce not required rows

beliefer commented on code in PR #38745:
URL: https://github.com/apache/spark/pull/38745#discussion_r1031206732


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala:
##########
@@ -87,7 +88,8 @@ case class WindowExec(
     windowExpression: Seq[NamedExpression],
     partitionSpec: Seq[Expression],
     orderSpec: Seq[SortOrder],
-    child: SparkPlan)
+    child: SparkPlan,
+    groupLimitInfo: Option[(Int, Expression)] = None)

Review Comment:
   I think it is OK to add a physical node, but the amount of code is a little large, and the filtering and reduction of data occur a little late.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org