You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by de...@apache.org on 2007/07/19 13:26:12 UTC

svn commit: r557578 - /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/deployment/POJODeployer.java

Author: deepal
Date: Thu Jul 19 04:26:11 2007
New Revision: 557578

URL: http://svn.apache.org/viewvc?view=rev&rev=557578
Log:
setting parent before adding to the AxisConfiguration , o.w when calling observers NPE occurs 

Modified:
    webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/deployment/POJODeployer.java

Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/deployment/POJODeployer.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/deployment/POJODeployer.java?view=diff&rev=557578&r1=557577&r2=557578
==============================================================================
--- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/deployment/POJODeployer.java (original)
+++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/deployment/POJODeployer.java Thu Jul 19 04:26:11 2007
@@ -190,6 +190,7 @@
                         AxisService axisService = (AxisService) axisServiceList.get(i);
                         serviceGroup.addService(axisService);
                     }
+                    serviceGroup.setParent(configCtx.getAxisConfiguration());
                     configCtx.getAxisConfiguration().addServiceGroup(serviceGroup);
                 } else {
                     log.info("No annotated class found in the jar: "  + deploymentFileData.getFile().getName());



---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org

Re: [axis2] Re: svn commit: r557578 - /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/deployment/POJODeployer.java

Posted by Deepal Jayasinghe <de...@opensource.lk>.
Hi Glen ,
Yes , I will do that way.

Thanks
Deepal

Glen Daniels wrote:
> Hi Deepal!
>
> deepal@apache.org wrote:
>> +                   
>> serviceGroup.setParent(configCtx.getAxisConfiguration());
>>                     
>> configCtx.getAxisConfiguration().addServiceGroup(serviceGroup);
>
> Didn't we make addServiceGroup() set the parent automatically?  If
> not, can we please do that instead?  In general the management of
> parent/child links in a hierarchical data structure should be managed
> by the internal logic of the classes themselves.  The user-level API
> shouldn't really even have direct control over parent/child data, it
> should just call add()/remove() and then internally the classes manage
> that data themselves.
>
> Thanks,
> --Glen
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org

[axis2] Re: svn commit: r557578 - /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/deployment/POJODeployer.java

Posted by Glen Daniels <gl...@thoughtcraft.com>.
Hi Deepal!

deepal@apache.org wrote:
> +                    serviceGroup.setParent(configCtx.getAxisConfiguration());
>                      configCtx.getAxisConfiguration().addServiceGroup(serviceGroup);

Didn't we make addServiceGroup() set the parent automatically?  If not, 
can we please do that instead?  In general the management of 
parent/child links in a hierarchical data structure should be managed by 
the internal logic of the classes themselves.  The user-level API 
shouldn't really even have direct control over parent/child data, it 
should just call add()/remove() and then internally the classes manage 
that data themselves.

Thanks,
--Glen

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org