You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "shreemaan-abhishek (via GitHub)" <gi...@apache.org> on 2023/02/23 04:03:18 UTC
[GitHub] [apisix] shreemaan-abhishek opened a new pull request, #8916: docs: replace `NOTE:` with note condonation
shreemaan-abhishek opened a new pull request, #8916:
URL: https://github.com/apache/apisix/pull/8916
### Description
I have replaced plain `NOTE:` with the `:::note ..... note` condonation.
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: replace `NOTE:` with note admonition [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek closed pull request #8916: docs: replace `NOTE:` with note admonition
URL: https://github.com/apache/apisix/pull/8916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] github-actions[bot] commented on pull request #8916: docs: replace `NOTE:` with note admonition
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8916:
URL: https://github.com/apache/apisix/pull/8916#issuecomment-1735228566
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: replace `NOTE:` with note admonition [apisix]
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on PR #8916:
URL: https://github.com/apache/apisix/pull/8916#issuecomment-1753933673
Hi @shreemaan-abhishek, please evaluate if this PR is still beneficial. I've noticed some docs already use admonitions deliberately (and, perhaps, too many). For example, this [authz-casdoor](https://apisix.apache.org/docs/apisix/plugins/authz-casdoor/#attributes) doc will three admonitions in a row after this change:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: replace `NOTE:` with note admonition [apisix]
Posted by "moonming (via GitHub)" <gi...@apache.org>.
moonming commented on PR #8916:
URL: https://github.com/apache/apisix/pull/8916#issuecomment-1752500176
@kayx23 please take care of this PR,thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Ajay-singh1 commented on pull request #8916: docs: replace `NOTE:` with note admonition
Posted by "Ajay-singh1 (via GitHub)" <gi...@apache.org>.
Ajay-singh1 commented on PR #8916:
URL: https://github.com/apache/apisix/pull/8916#issuecomment-1453654633
Good Work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org