You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/11/21 23:38:04 UTC
[kudu-CR] compaction: remove dead code
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11978
to review the following change.
Change subject: compaction: remove dead code
......................................................................
compaction: remove dead code
As far as I can tell, this has been dead since 2014 (commit 07db3407e)
and 2013 (commit 95f6c9811).
Change-Id: I046d1c402f65803b6feb64983b52b6cccafdf2ab
---
M src/kudu/tablet/compaction.cc
1 file changed, 1 insertion(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/11978/1
--
To view, visit http://gerrit.cloudera.org:8080/11978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I046d1c402f65803b6feb64983b52b6cccafdf2ab
Gerrit-Change-Number: 11978
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] compaction: remove dead code
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11978 )
Change subject: compaction: remove dead code
......................................................................
compaction: remove dead code
As far as I can tell, this has been dead since 2014 (commit 07db3407e)
and 2013 (commit 95f6c9811).
Change-Id: I046d1c402f65803b6feb64983b52b6cccafdf2ab
Reviewed-on: http://gerrit.cloudera.org:8080/11978
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/tablet/compaction.cc
1 file changed, 1 insertion(+), 11 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I046d1c402f65803b6feb64983b52b6cccafdf2ab
Gerrit-Change-Number: 11978
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] compaction: remove dead code
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11978 )
Change subject: compaction: remove dead code
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I046d1c402f65803b6feb64983b52b6cccafdf2ab
Gerrit-Change-Number: 11978
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 26 Nov 2018 21:22:55 +0000
Gerrit-HasComments: No