[GitHub] [pulsar] bharanic-dev commented on a change in pull request #11916: [PIP-82] [pulsar-broker] Miscellaneous bug fixes in resource group rate limiter.

[GitBox <gi...@apache.org>]

bharanic-dev commented on a change in pull request #11916:
URL: https://github.com/apache/pulsar/pull/11916#discussion_r702068431



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceQuotaCalculatorImpl.java
##########
@@ -80,6 +74,12 @@ public long computeLocalQuota(long confUsage, long myUsage, long[] allUsages) th
         float myUsageFraction = (float) myUsage / totalUsage;
         float calculatedQuota = max(myUsage + residual * myUsageFraction, 0);
 
+        // If the calculated rate ends up being 0, set it to 0. rate value of 0 or less is assumed to mean that

Review comment:
       thank you @ravi-vaidyanathan , will fix the comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org