You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sis.apache.org by de...@apache.org on 2024/02/18 22:02:49 UTC
(sis) branch geoapi-4.0 updated: GeoAPI `TransformTestCase` constructor no longer requires factories.
This is an automated email from the ASF dual-hosted git repository.
desruisseaux pushed a commit to branch geoapi-4.0
in repository https://gitbox.apache.org/repos/asf/sis.git
The following commit(s) were added to refs/heads/geoapi-4.0 by this push:
new acc94580f9 GeoAPI `TransformTestCase` constructor no longer requires factories.
acc94580f9 is described below
commit acc94580f97e24c19d548f0abe8dc1b7e6b7a8cb
Author: Martin Desruisseaux <ma...@geomatys.com>
AuthorDate: Sun Feb 18 23:00:33 2024 +0100
GeoAPI `TransformTestCase` constructor no longer requires factories.
---
.../operation/transform/MathTransformTestCase.java | 19 ++++---------------
geoapi/snapshot | 2 +-
2 files changed, 5 insertions(+), 16 deletions(-)
diff --git a/endorsed/src/org.apache.sis.referencing/test/org/apache/sis/referencing/operation/transform/MathTransformTestCase.java b/endorsed/src/org.apache.sis.referencing/test/org/apache/sis/referencing/operation/transform/MathTransformTestCase.java
index b24182f1b4..57b25dbd52 100644
--- a/endorsed/src/org.apache.sis.referencing/test/org/apache/sis/referencing/operation/transform/MathTransformTestCase.java
+++ b/endorsed/src/org.apache.sis.referencing/test/org/apache/sis/referencing/operation/transform/MathTransformTestCase.java
@@ -45,7 +45,6 @@ import org.apache.sis.referencing.Assertions;
import org.opengis.test.Validators;
// Specific to the geoapi-3.1 and geoapi-4.0 branches:
-import org.opengis.util.Factory;
import org.opengis.geometry.DirectPosition;
import org.apache.sis.measure.Longitude;
import org.opengis.test.CalculationType;
@@ -121,18 +120,8 @@ public abstract class MathTransformTestCase extends TransformTestCase {
* Creates a new test case.
*/
protected MathTransformTestCase() {
- this(new Factory[0]);
- }
-
- /**
- * Creates a new test case which will use the given factories.
- *
- * @param factories the factories to be used by the test.
- */
- protected MathTransformTestCase(final Factory... factories) {
- super(factories);
/*
- * Use 'zTolerance' threshold instead of 'tolerance' when comparing vertical coordinate values.
+ * Use `zTolerance` threshold instead of `tolerance` when comparing vertical coordinate values.
*/
toleranceModifier = (final double[] tolerances, final DirectPosition coordinates, final CalculationType mode) -> {
if (mode != CalculationType.IDENTITY) {
@@ -262,7 +251,7 @@ public abstract class MathTransformTestCase extends TransformTestCase {
super.verifyTransform(coordinates, expected);
/*
* In addition to the GeoAPI "verifyTransform" check, check also for consistency of various variant
- * of MathTransform.transform(…) methods. In GeoAPI, 'verifyTransform' and 'verifyConsistency' are
+ * of MathTransform.transform(…) methods. In GeoAPI, `verifyTransform` and `verifyConsistency` are
* two independent steps because not all developers may want to perform both verifications together.
* But in Apache SIS, we want to verify consistency for all math transforms. A previous version had
* a bug with the Google projection which was unnoticed because of lack of this consistency check.
@@ -276,7 +265,7 @@ public abstract class MathTransformTestCase extends TransformTestCase {
* The comparison below needs a higher tolerance threshold, because we converted the source
* coordinates to floating points which induce a lost of precision. The multiplication factor
* used here has been determined empirically. The value is quite high, but this is only an
- * oportunist check anyway. The "real" test is the one performed by 'verifyConsistency'.
+ * oportunist check anyway. The "real" test is the one performed by `verifyConsistency`.
* We do not perform this check for non-linear transforms, because the differences in input
* have too unpredictable consequences on the output.
*/
@@ -284,7 +273,7 @@ public abstract class MathTransformTestCase extends TransformTestCase {
for (int i=0; i<expected.length; i++) {
final double e = expected[i];
double tol = 1E-6 * abs(e);
- if (!(tol > tolerance)) { // Use '!' for replacing NaN by 'tolerance'.
+ if (!(tol > tolerance)) { // Use `!` for replacing NaN by `tolerance`.
tol = tolerance;
}
assertEquals(e, result[i], tol);
diff --git a/geoapi/snapshot b/geoapi/snapshot
index 84e48733a2..c786929b56 160000
--- a/geoapi/snapshot
+++ b/geoapi/snapshot
@@ -1 +1 @@
-Subproject commit 84e48733a2ec792e1af71ed51f15e70683182e53
+Subproject commit c786929b56e8f8aed8eceb0144734bbd7ac28ea6