You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by li...@apache.org on 2023/01/10 09:16:39 UTC
[incubator-devlake] branch main updated: fix: add unique index for the name of transformation rule (#4172)
This is an automated email from the ASF dual-hosted git repository.
likyh pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
The following commit(s) were added to refs/heads/main by this push:
new 01ef080b6 fix: add unique index for the name of transformation rule (#4172)
01ef080b6 is described below
commit 01ef080b65209a4488782b13a3d23e6363f65018
Author: mindlesscloud <li...@merico.dev>
AuthorDate: Tue Jan 10 17:16:34 2023 +0800
fix: add unique index for the name of transformation rule (#4172)
* fix: add unique index for the name of transformation rule
* fix: improve the error message
---
impl/dalgorm/dalgorm.go | 2 +-
plugins/github/api/transformation_rule.go | 23 ++++++++++++--------
.../20221214_add_trasformation_rule_table.go | 2 +-
.../archived/transformation_rules.go | 2 +-
plugins/github/models/transformation_rule.go | 2 +-
plugins/gitlab/api/transformation_rule.go | 23 ++++++++++++--------
.../20221125_add_html_url_to_project.go | 2 +-
.../archived/transformation_rules.go | 2 +-
plugins/gitlab/models/transformation_rule.go | 2 +-
plugins/jenkins/api/transformation_rule.go | 23 ++++++++++++--------
.../20221205_add_trasformation_rule_table.go | 2 +-
.../archived/transformation_rules.go | 2 +-
plugins/jenkins/models/transformation_rule.go | 2 +-
plugins/jira/api/transformation_rule.go | 25 +++++++++++++---------
.../20221116_add_trasformation_rule_table.go | 2 +-
.../archived/transformation_rule.go | 2 +-
plugins/jira/models/transformation_rules.go | 2 +-
plugins/jira/tasks/task_data.go | 2 +-
18 files changed, 71 insertions(+), 51 deletions(-)
diff --git a/impl/dalgorm/dalgorm.go b/impl/dalgorm/dalgorm.go
index a9a2e8403..f09791ef4 100644
--- a/impl/dalgorm/dalgorm.go
+++ b/impl/dalgorm/dalgorm.go
@@ -362,7 +362,7 @@ func (d *Dalgorm) IsErrorNotFound(err errors.Error) bool {
// IsDuplicationError checking if the sql error is not found.
func (d *Dalgorm) IsDuplicationError(err errors.Error) bool {
- return strings.Contains(err.Error(), "duplicate")
+ return strings.Contains(strings.ToLower(err.Error()), "duplicate")
}
// NewDalgorm creates a *Dalgorm
diff --git a/plugins/github/api/transformation_rule.go b/plugins/github/api/transformation_rule.go
index 92d6647c5..0d223a54a 100644
--- a/plugins/github/api/transformation_rule.go
+++ b/plugins/github/api/transformation_rule.go
@@ -26,7 +26,6 @@ import (
"github.com/apache/incubator-devlake/plugins/core/dal"
"github.com/apache/incubator-devlake/plugins/github/models"
"github.com/apache/incubator-devlake/plugins/helper"
- "github.com/mitchellh/mapstructure"
)
// CreateTransformationRule create transformation rule for Github
@@ -41,13 +40,16 @@ import (
// @Router /plugins/github/transformation_rules [POST]
func CreateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOutput, errors.Error) {
var rule models.GithubTransformationRule
- err := mapstructure.Decode(input.Body, &rule)
+ err := helper.Decode(input.Body, &rule, vld)
if err != nil {
- return nil, errors.Default.Wrap(err, "error in decoding transformation rule")
+ return nil, errors.BadInput.Wrap(err, "error in decoding transformation rule")
}
err = basicRes.GetDal().Create(&rule)
if err != nil {
- return nil, errors.Default.Wrap(err, "error on saving TransformationRule")
+ if basicRes.GetDal().IsDuplicationError(err) {
+ return nil, errors.BadInput.New("there was a transformation rule with the same name, please choose another name")
+ }
+ return nil, errors.BadInput.Wrap(err, "error on saving TransformationRule")
}
return &core.ApiResourceOutput{Body: rule, Status: http.StatusOK}, nil
}
@@ -64,12 +66,12 @@ func CreateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOu
// @Failure 500 {object} shared.ApiBody "Internal Error"
// @Router /plugins/github/transformation_rules/{id} [PATCH]
func UpdateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOutput, errors.Error) {
- transformationRuleId, err := strconv.ParseUint(input.Params["id"], 10, 64)
- if err != nil {
- return nil, errors.Default.Wrap(err, "the transformation rule ID should be an integer")
+ transformationRuleId, e := strconv.ParseUint(input.Params["id"], 10, 64)
+ if e != nil {
+ return nil, errors.Default.Wrap(e, "the transformation rule ID should be an integer")
}
var old models.GithubTransformationRule
- err = basicRes.GetDal().First(&old, dal.Where("id = ?", transformationRuleId))
+ err := basicRes.GetDal().First(&old, dal.Where("id = ?", transformationRuleId))
if err != nil {
return nil, errors.Default.Wrap(err, "error on saving TransformationRule")
}
@@ -80,7 +82,10 @@ func UpdateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOu
old.ID = transformationRuleId
err = basicRes.GetDal().Update(&old, dal.Where("id = ?", transformationRuleId))
if err != nil {
- return nil, errors.Default.Wrap(err, "error on saving TransformationRule")
+ if basicRes.GetDal().IsDuplicationError(err) {
+ return nil, errors.BadInput.New("there was a transformation rule with the same name, please choose another name")
+ }
+ return nil, errors.BadInput.Wrap(err, "error on saving TransformationRule")
}
return &core.ApiResourceOutput{Body: old, Status: http.StatusOK}, nil
}
diff --git a/plugins/github/models/migrationscripts/20221214_add_trasformation_rule_table.go b/plugins/github/models/migrationscripts/20221214_add_trasformation_rule_table.go
index a87fd2c32..ba4003b15 100644
--- a/plugins/github/models/migrationscripts/20221214_add_trasformation_rule_table.go
+++ b/plugins/github/models/migrationscripts/20221214_add_trasformation_rule_table.go
@@ -40,7 +40,7 @@ func (script *addTransformationRule20221124) Up(basicRes core.BasicRes) errors.E
}
func (*addTransformationRule20221124) Version() uint64 {
- return 20221214095900
+ return 20221214095902
}
func (*addTransformationRule20221124) Name() string {
diff --git a/plugins/github/models/migrationscripts/archived/transformation_rules.go b/plugins/github/models/migrationscripts/archived/transformation_rules.go
index 2df2bc000..2dfa1a65d 100644
--- a/plugins/github/models/migrationscripts/archived/transformation_rules.go
+++ b/plugins/github/models/migrationscripts/archived/transformation_rules.go
@@ -25,7 +25,7 @@ import (
type GithubTransformationRule struct {
archived.Model
- Name string `mapstructure:"name" json:"name" gorm:"type:varchar(255)"`
+ Name string `mapstructure:"name" json:"name" gorm:"type:varchar(255);index:idx_name,unique" validate:"required"`
PrType string `mapstructure:"prType" json:"prType" gorm:"type:varchar(255)"`
PrComponent string `mapstructure:"prComponent" json:"prComponent" gorm:"type:varchar(255)"`
PrBodyClosePattern string `mapstructure:"prBodyClosePattern" json:"prBodyClosePattern" gorm:"type:varchar(255)"`
diff --git a/plugins/github/models/transformation_rule.go b/plugins/github/models/transformation_rule.go
index 66b4b7fcf..40d9cbb9e 100644
--- a/plugins/github/models/transformation_rule.go
+++ b/plugins/github/models/transformation_rule.go
@@ -24,7 +24,7 @@ import (
type GithubTransformationRule struct {
common.Model `mapstructure:"-"`
- Name string `mapstructure:"name" json:"name" gorm:"type:varchar(255)"`
+ Name string `mapstructure:"name" json:"name" gorm:"type:varchar(255);index:idx_name,unique" validate:"required"`
PrType string `mapstructure:"prType,omitempty" json:"prType" gorm:"type:varchar(255)"`
PrComponent string `mapstructure:"prComponent,omitempty" json:"prComponent" gorm:"type:varchar(255)"`
PrBodyClosePattern string `mapstructure:"prBodyClosePattern,omitempty" json:"prBodyClosePattern" gorm:"type:varchar(255)"`
diff --git a/plugins/gitlab/api/transformation_rule.go b/plugins/gitlab/api/transformation_rule.go
index 1c56b46d0..51b06cac0 100644
--- a/plugins/gitlab/api/transformation_rule.go
+++ b/plugins/gitlab/api/transformation_rule.go
@@ -26,7 +26,6 @@ import (
"github.com/apache/incubator-devlake/plugins/core/dal"
"github.com/apache/incubator-devlake/plugins/gitlab/models"
"github.com/apache/incubator-devlake/plugins/helper"
- "github.com/mitchellh/mapstructure"
)
// CreateTransformationRule create transformation rule for Gitlab
@@ -41,13 +40,16 @@ import (
// @Router /plugins/gitlab/transformation_rules [POST]
func CreateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOutput, errors.Error) {
var rule models.GitlabTransformationRule
- err := mapstructure.Decode(input.Body, &rule)
+ err := helper.Decode(input.Body, &rule, vld)
if err != nil {
- return nil, errors.Default.Wrap(err, "error in decoding transformation rule")
+ return nil, errors.BadInput.Wrap(err, "error in decoding transformation rule")
}
err = basicRes.GetDal().Create(&rule)
if err != nil {
- return nil, errors.Default.Wrap(err, "error on saving TransformationRule")
+ if basicRes.GetDal().IsDuplicationError(err) {
+ return nil, errors.BadInput.New("there was a transformation rule with the same name, please choose another name")
+ }
+ return nil, errors.BadInput.Wrap(err, "error on saving TransformationRule")
}
return &core.ApiResourceOutput{Body: rule, Status: http.StatusOK}, nil
}
@@ -64,12 +66,12 @@ func CreateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOu
// @Failure 500 {object} shared.ApiBody "Internal Error"
// @Router /plugins/gitlab/transformation_rules/{id} [PATCH]
func UpdateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOutput, errors.Error) {
- transformationRuleId, err := strconv.ParseUint(input.Params["id"], 10, 64)
- if err != nil {
- return nil, errors.Default.Wrap(err, "the transformation rule ID should be an integer")
+ transformationRuleId, e := strconv.ParseUint(input.Params["id"], 10, 64)
+ if e != nil {
+ return nil, errors.Default.Wrap(e, "the transformation rule ID should be an integer")
}
var old models.GitlabTransformationRule
- err = basicRes.GetDal().First(&old, dal.Where("id = ?", transformationRuleId))
+ err := basicRes.GetDal().First(&old, dal.Where("id = ?", transformationRuleId))
if err != nil {
return nil, errors.Default.Wrap(err, "error on saving TransformationRule")
}
@@ -80,7 +82,10 @@ func UpdateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOu
old.ID = transformationRuleId
err = basicRes.GetDal().Update(&old, dal.Where("id = ?", transformationRuleId))
if err != nil {
- return nil, errors.Default.Wrap(err, "error on saving TransformationRule")
+ if basicRes.GetDal().IsDuplicationError(err) {
+ return nil, errors.BadInput.New("there was a transformation rule with the same name, please choose another name")
+ }
+ return nil, errors.BadInput.Wrap(err, "error on saving TransformationRule")
}
return &core.ApiResourceOutput{Body: old, Status: http.StatusOK}, nil
}
diff --git a/plugins/gitlab/models/migrationscripts/20221125_add_html_url_to_project.go b/plugins/gitlab/models/migrationscripts/20221125_add_html_url_to_project.go
index d51bd6d98..2f7e1bb51 100644
--- a/plugins/gitlab/models/migrationscripts/20221125_add_html_url_to_project.go
+++ b/plugins/gitlab/models/migrationscripts/20221125_add_html_url_to_project.go
@@ -40,7 +40,7 @@ func (*addTransformationRule20221125) Up(basicRes core.BasicRes) errors.Error {
}
func (*addTransformationRule20221125) Version() uint64 {
- return 20221125102500
+ return 20221125102502
}
func (*addTransformationRule20221125) Name() string {
diff --git a/plugins/gitlab/models/migrationscripts/archived/transformation_rules.go b/plugins/gitlab/models/migrationscripts/archived/transformation_rules.go
index 97b42c750..d8fb0d332 100644
--- a/plugins/gitlab/models/migrationscripts/archived/transformation_rules.go
+++ b/plugins/gitlab/models/migrationscripts/archived/transformation_rules.go
@@ -24,7 +24,7 @@ import (
type GitlabTransformationRule struct {
archived.Model
- Name string `gorm:"type:varchar(255)"`
+ Name string `gorm:"type:varchar(255);index:idx_name,unique" validate:"required"`
PrType string `mapstructure:"prType" json:"prType" gorm:"type:varchar(255)"`
PrComponent string `mapstructure:"prComponent" json:"prComponent" gorm:"type:varchar(255)"`
PrBodyClosePattern string `mapstructure:"prBodyClosePattern" json:"prBodyClosePattern" gorm:"type:varchar(255)"`
diff --git a/plugins/gitlab/models/transformation_rule.go b/plugins/gitlab/models/transformation_rule.go
index 10a73e111..ec3fd2917 100644
--- a/plugins/gitlab/models/transformation_rule.go
+++ b/plugins/gitlab/models/transformation_rule.go
@@ -24,7 +24,7 @@ import (
type GitlabTransformationRule struct {
common.Model
- Name string `gorm:"type:varchar(255)" mapstructure:"name" json:"name"`
+ Name string `gorm:"type:varchar(255);index:idx_name,unique" validate:"required" mapstructure:"name" json:"name"`
PrType string `mapstructure:"prType" json:"prType"`
PrComponent string `mapstructure:"prComponent" json:"prComponent"`
PrBodyClosePattern string `mapstructure:"prBodyClosePattern" json:"prBodyClosePattern"`
diff --git a/plugins/jenkins/api/transformation_rule.go b/plugins/jenkins/api/transformation_rule.go
index 62d4d9235..74ec3f8b3 100644
--- a/plugins/jenkins/api/transformation_rule.go
+++ b/plugins/jenkins/api/transformation_rule.go
@@ -26,7 +26,6 @@ import (
"github.com/apache/incubator-devlake/plugins/core/dal"
"github.com/apache/incubator-devlake/plugins/helper"
"github.com/apache/incubator-devlake/plugins/jenkins/models"
- "github.com/mitchellh/mapstructure"
)
// CreateTransformationRule create transformation rule for Jenkins
@@ -41,13 +40,16 @@ import (
// @Router /plugins/jenkins/transformation_rules [POST]
func CreateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOutput, errors.Error) {
var rule models.JenkinsTransformationRule
- err := mapstructure.Decode(input.Body, &rule)
+ err := helper.Decode(input.Body, &rule, vld)
if err != nil {
- return nil, errors.Default.Wrap(err, "error in decoding transformation rule")
+ return nil, errors.BadInput.Wrap(err, "error in decoding transformation rule")
}
err = basicRes.GetDal().Create(&rule)
if err != nil {
- return nil, errors.Default.Wrap(err, "error on saving TransformationRule")
+ if basicRes.GetDal().IsDuplicationError(err) {
+ return nil, errors.BadInput.New("there was a transformation rule with the same name, please choose another name")
+ }
+ return nil, errors.BadInput.Wrap(err, "error on saving TransformationRule")
}
return &core.ApiResourceOutput{Body: rule, Status: http.StatusOK}, nil
}
@@ -64,12 +66,12 @@ func CreateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOu
// @Failure 500 {object} shared.ApiBody "Internal Error"
// @Router /plugins/jenkins/transformation_rules/{id} [PATCH]
func UpdateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOutput, errors.Error) {
- transformationRuleId, err := strconv.ParseUint(input.Params["id"], 10, 64)
- if err != nil {
- return nil, errors.Default.Wrap(err, "the transformation rule ID should be an integer")
+ transformationRuleId, e := strconv.ParseUint(input.Params["id"], 10, 64)
+ if e != nil {
+ return nil, errors.Default.Wrap(e, "the transformation rule ID should be an integer")
}
var old models.JenkinsTransformationRule
- err = basicRes.GetDal().First(&old, dal.Where("id = ?", transformationRuleId))
+ err := basicRes.GetDal().First(&old, dal.Where("id = ?", transformationRuleId))
if err != nil {
return nil, errors.Default.Wrap(err, "error on saving TransformationRule")
}
@@ -80,7 +82,10 @@ func UpdateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOu
old.ID = transformationRuleId
err = basicRes.GetDal().Update(&old, dal.Where("id = ?", transformationRuleId))
if err != nil {
- return nil, errors.Default.Wrap(err, "error on saving TransformationRule")
+ if basicRes.GetDal().IsDuplicationError(err) {
+ return nil, errors.BadInput.New("there was a transformation rule with the same name, please choose another name")
+ }
+ return nil, errors.BadInput.Wrap(err, "error on saving TransformationRule")
}
return &core.ApiResourceOutput{Body: old, Status: http.StatusOK}, nil
}
diff --git a/plugins/jenkins/models/migrationscripts/20221205_add_trasformation_rule_table.go b/plugins/jenkins/models/migrationscripts/20221205_add_trasformation_rule_table.go
index d63046e12..5bdf6f6bc 100644
--- a/plugins/jenkins/models/migrationscripts/20221205_add_trasformation_rule_table.go
+++ b/plugins/jenkins/models/migrationscripts/20221205_add_trasformation_rule_table.go
@@ -39,7 +39,7 @@ func (*addTransformationRule20221128) Up(basicRes core.BasicRes) errors.Error {
}
func (*addTransformationRule20221128) Version() uint64 {
- return 20221205113500
+ return 20221205113502
}
func (*addTransformationRule20221128) Name() string {
diff --git a/plugins/jenkins/models/migrationscripts/archived/transformation_rules.go b/plugins/jenkins/models/migrationscripts/archived/transformation_rules.go
index 71aa0e9d6..d3d806066 100644
--- a/plugins/jenkins/models/migrationscripts/archived/transformation_rules.go
+++ b/plugins/jenkins/models/migrationscripts/archived/transformation_rules.go
@@ -23,7 +23,7 @@ import (
type JenkinsTransformationRule struct {
archived.Model
- Name string `gorm:"type:varchar(255)"`
+ Name string `gorm:"type:varchar(255);index:idx_name,unique" validate:"required"`
DeploymentPattern string `gorm:"type:varchar(255)" mapstructure:"deploymentPattern" json:"deploymentPattern"`
ProductionPattern string `gorm:"type:varchar(255)" mapstructure:"deploymentPattern,omitempty" json:"productionPattern"`
}
diff --git a/plugins/jenkins/models/transformation_rule.go b/plugins/jenkins/models/transformation_rule.go
index a79d3820c..3a092f714 100644
--- a/plugins/jenkins/models/transformation_rule.go
+++ b/plugins/jenkins/models/transformation_rule.go
@@ -21,7 +21,7 @@ import "github.com/apache/incubator-devlake/models/common"
type JenkinsTransformationRule struct {
common.Model `mapstructure:"-"`
- Name string `gorm:"type:varchar(255)" mapstructure:"name" json:"name"`
+ Name string `gorm:"type:varchar(255);index:idx_name,unique" validate:"required" mapstructure:"name" json:"name"`
DeploymentPattern string `gorm:"type:varchar(255)" mapstructure:"deploymentPattern,omitempty" json:"deploymentPattern"`
ProductionPattern string `gorm:"type:varchar(255)" mapstructure:"productionPattern,omitempty" json:"productionPattern"`
}
diff --git a/plugins/jira/api/transformation_rule.go b/plugins/jira/api/transformation_rule.go
index 1517d269f..37a99f521 100644
--- a/plugins/jira/api/transformation_rule.go
+++ b/plugins/jira/api/transformation_rule.go
@@ -27,7 +27,6 @@ import (
"github.com/apache/incubator-devlake/plugins/helper"
"github.com/apache/incubator-devlake/plugins/jira/models"
"github.com/apache/incubator-devlake/plugins/jira/tasks"
- "github.com/mitchellh/mapstructure"
)
// CreateTransformationRule create transformation rule for Jira
@@ -43,11 +42,14 @@ import (
func CreateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOutput, errors.Error) {
rule, err := makeDbTransformationRuleFromInput(input)
if err != nil {
- return nil, errors.Default.Wrap(err, "error in makeJiraTransformationRule")
+ return nil, errors.BadInput.Wrap(err, "error in makeJiraTransformationRule")
}
err = basicRes.GetDal().Create(&rule)
if err != nil {
- return nil, errors.Default.Wrap(err, "error on saving TransformationRule")
+ if basicRes.GetDal().IsDuplicationError(err) {
+ return nil, errors.BadInput.New("there was a transformation rule with the same name, please choose another name")
+ }
+ return nil, errors.BadInput.Wrap(err, "error on saving TransformationRule")
}
return &core.ApiResourceOutput{Body: rule, Status: http.StatusOK}, nil
}
@@ -64,12 +66,12 @@ func CreateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOu
// @Failure 500 {object} shared.ApiBody "Internal Error"
// @Router /plugins/jira/transformation_rules/{id} [PATCH]
func UpdateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOutput, errors.Error) {
- transformationRuleId, err := strconv.ParseUint(input.Params["id"], 10, 64)
- if err != nil {
- return nil, errors.Default.Wrap(err, "the transformation rule ID should be an integer")
+ transformationRuleId, e := strconv.ParseUint(input.Params["id"], 10, 64)
+ if e != nil {
+ return nil, errors.Default.Wrap(e, "the transformation rule ID should be an integer")
}
var old models.JiraTransformationRule
- err = basicRes.GetDal().First(&old, dal.Where("id = ?", transformationRuleId))
+ err := basicRes.GetDal().First(&old, dal.Where("id = ?", transformationRuleId))
if err != nil {
return nil, errors.Default.Wrap(err, "error on saving TransformationRule")
}
@@ -80,16 +82,19 @@ func UpdateTransformationRule(input *core.ApiResourceInput) (*core.ApiResourceOu
old.ID = transformationRuleId
err = basicRes.GetDal().Update(&old, dal.Where("id = ?", transformationRuleId))
if err != nil {
- return nil, errors.Default.Wrap(err, "error on saving TransformationRule")
+ if basicRes.GetDal().IsDuplicationError(err) {
+ return nil, errors.BadInput.New("there was a transformation rule with the same name, please choose another name")
+ }
+ return nil, errors.BadInput.Wrap(err, "error on saving TransformationRule")
}
return &core.ApiResourceOutput{Body: old, Status: http.StatusOK}, nil
}
func makeDbTransformationRuleFromInput(input *core.ApiResourceInput) (*models.JiraTransformationRule, errors.Error) {
var req tasks.JiraTransformationRule
- err := mapstructure.Decode(input.Body, &req)
+ err := helper.Decode(input.Body, &req, vld)
if err != nil {
- return nil, errors.Default.Wrap(err, "error decoding map into transformationRule")
+ return nil, err
}
return req.ToDb()
}
diff --git a/plugins/jira/models/migrationscripts/20221116_add_trasformation_rule_table.go b/plugins/jira/models/migrationscripts/20221116_add_trasformation_rule_table.go
index 475388c88..a436220bf 100644
--- a/plugins/jira/models/migrationscripts/20221116_add_trasformation_rule_table.go
+++ b/plugins/jira/models/migrationscripts/20221116_add_trasformation_rule_table.go
@@ -39,7 +39,7 @@ func (script *addTransformationRule20221116) Up(basicRes core.BasicRes) errors.E
}
func (*addTransformationRule20221116) Version() uint64 {
- return 20221117122532
+ return 20221117122534
}
func (*addTransformationRule20221116) Name() string {
diff --git a/plugins/jira/models/migrationscripts/archived/transformation_rule.go b/plugins/jira/models/migrationscripts/archived/transformation_rule.go
index fab95a991..929e26dd3 100644
--- a/plugins/jira/models/migrationscripts/archived/transformation_rule.go
+++ b/plugins/jira/models/migrationscripts/archived/transformation_rule.go
@@ -25,7 +25,7 @@ import (
type JiraTransformationRule struct {
archived.Model
- Name string `gorm:"type:varchar(255)"`
+ Name string `gorm:"type:varchar(255);index:idx_name,unique" validate:"required"`
EpicKeyField string `json:"epicKeyField" gorm:"type:varchar(255)"`
StoryPointField string `json:"storyPointField" gorm:"type:varchar(255)"`
RemotelinkCommitShaPattern string `json:"remotelinkCommitShaPattern" gorm:"type:varchar(255)"`
diff --git a/plugins/jira/models/transformation_rules.go b/plugins/jira/models/transformation_rules.go
index 448bcab6e..2ebc7c045 100644
--- a/plugins/jira/models/transformation_rules.go
+++ b/plugins/jira/models/transformation_rules.go
@@ -25,7 +25,7 @@ import (
type JiraTransformationRule struct {
common.Model `mapstructure:"-"`
- Name string `mapstructure:"name" json:"name" gorm:"type:varchar(255)"`
+ Name string `mapstructure:"name" json:"name" gorm:"type:varchar(255);index:idx_name,unique" validate:"required"`
EpicKeyField string `mapstructure:"epicKeyField,omitempty" json:"epicKeyField" gorm:"type:varchar(255)"`
StoryPointField string `mapstructure:"storyPointField,omitempty" json:"storyPointField" gorm:"type:varchar(255)"`
RemotelinkCommitShaPattern string `mapstructure:"remotelinkCommitShaPattern,omitempty" json:"remotelinkCommitShaPattern" gorm:"type:varchar(255)"`
diff --git a/plugins/jira/tasks/task_data.go b/plugins/jira/tasks/task_data.go
index 1e998128e..866accb65 100644
--- a/plugins/jira/tasks/task_data.go
+++ b/plugins/jira/tasks/task_data.go
@@ -41,7 +41,7 @@ type TypeMapping struct {
type TypeMappings map[string]TypeMapping
type JiraTransformationRule struct {
- Name string `gorm:"type:varchar(255)"`
+ Name string `gorm:"type:varchar(255)" validate:"required"`
EpicKeyField string `json:"epicKeyField"`
StoryPointField string `json:"storyPointField"`
RemotelinkCommitShaPattern string `json:"remotelinkCommitShaPattern"`