You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2017/04/01 03:33:29 UTC
[02/25] hbase-site git commit: Published site at
9facfa550f1e7386be3a04d84f7e8013f5002965.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/993199fc/testdevapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/TestHFileCleaner.DummyServer.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/TestHFileCleaner.DummyServer.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/TestHFileCleaner.DummyServer.html
index 5c9f96e..2bb994d 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/TestHFileCleaner.DummyServer.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/cleaner/TestHFileCleaner.DummyServer.html
@@ -30,245 +30,397 @@
<span class="sourceLineNo">022</span>import static org.junit.Assert.assertTrue;<a name="line.22"></a>
<span class="sourceLineNo">023</span><a name="line.23"></a>
<span class="sourceLineNo">024</span>import java.io.IOException;<a name="line.24"></a>
-<span class="sourceLineNo">025</span><a name="line.25"></a>
-<span class="sourceLineNo">026</span>import org.apache.commons.logging.Log;<a name="line.26"></a>
-<span class="sourceLineNo">027</span>import org.apache.commons.logging.LogFactory;<a name="line.27"></a>
-<span class="sourceLineNo">028</span>import org.apache.hadoop.conf.Configuration;<a name="line.28"></a>
-<span class="sourceLineNo">029</span>import org.apache.hadoop.fs.FileStatus;<a name="line.29"></a>
-<span class="sourceLineNo">030</span>import org.apache.hadoop.fs.FileSystem;<a name="line.30"></a>
-<span class="sourceLineNo">031</span>import org.apache.hadoop.fs.Path;<a name="line.31"></a>
-<span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.ChoreService;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.CoordinatedStateManager;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.HConstants;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.Server;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.ServerName;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.client.ClusterConnection;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.testclassification.MasterTests;<a name="line.39"></a>
-<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.40"></a>
-<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.util.EnvironmentEdge;<a name="line.41"></a>
-<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;<a name="line.42"></a>
-<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.zookeeper.MetaTableLocator;<a name="line.43"></a>
-<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher;<a name="line.44"></a>
-<span class="sourceLineNo">045</span>import org.junit.AfterClass;<a name="line.45"></a>
-<span class="sourceLineNo">046</span>import org.junit.BeforeClass;<a name="line.46"></a>
-<span class="sourceLineNo">047</span>import org.junit.Test;<a name="line.47"></a>
-<span class="sourceLineNo">048</span>import org.junit.experimental.categories.Category;<a name="line.48"></a>
-<span class="sourceLineNo">049</span><a name="line.49"></a>
-<span class="sourceLineNo">050</span>@Category({MasterTests.class, MediumTests.class})<a name="line.50"></a>
-<span class="sourceLineNo">051</span>public class TestHFileCleaner {<a name="line.51"></a>
-<span class="sourceLineNo">052</span> private static final Log LOG = LogFactory.getLog(TestHFileCleaner.class);<a name="line.52"></a>
-<span class="sourceLineNo">053</span><a name="line.53"></a>
-<span class="sourceLineNo">054</span> private final static HBaseTestingUtility UTIL = new HBaseTestingUtility();<a name="line.54"></a>
-<span class="sourceLineNo">055</span><a name="line.55"></a>
-<span class="sourceLineNo">056</span> @BeforeClass<a name="line.56"></a>
-<span class="sourceLineNo">057</span> public static void setupCluster() throws Exception {<a name="line.57"></a>
-<span class="sourceLineNo">058</span> // have to use a minidfs cluster because the localfs doesn't modify file times correctly<a name="line.58"></a>
-<span class="sourceLineNo">059</span> UTIL.startMiniDFSCluster(1);<a name="line.59"></a>
-<span class="sourceLineNo">060</span> }<a name="line.60"></a>
-<span class="sourceLineNo">061</span><a name="line.61"></a>
-<span class="sourceLineNo">062</span> @AfterClass<a name="line.62"></a>
-<span class="sourceLineNo">063</span> public static void shutdownCluster() throws IOException {<a name="line.63"></a>
-<span class="sourceLineNo">064</span> UTIL.shutdownMiniDFSCluster();<a name="line.64"></a>
-<span class="sourceLineNo">065</span> }<a name="line.65"></a>
-<span class="sourceLineNo">066</span><a name="line.66"></a>
-<span class="sourceLineNo">067</span> @Test<a name="line.67"></a>
-<span class="sourceLineNo">068</span> public void testTTLCleaner() throws IOException, InterruptedException {<a name="line.68"></a>
-<span class="sourceLineNo">069</span> FileSystem fs = UTIL.getDFSCluster().getFileSystem();<a name="line.69"></a>
-<span class="sourceLineNo">070</span> Path root = UTIL.getDataTestDirOnTestFS();<a name="line.70"></a>
-<span class="sourceLineNo">071</span> Path file = new Path(root, "file");<a name="line.71"></a>
-<span class="sourceLineNo">072</span> fs.createNewFile(file);<a name="line.72"></a>
-<span class="sourceLineNo">073</span> long createTime = System.currentTimeMillis();<a name="line.73"></a>
-<span class="sourceLineNo">074</span> assertTrue("Test file not created!", fs.exists(file));<a name="line.74"></a>
-<span class="sourceLineNo">075</span> TimeToLiveHFileCleaner cleaner = new TimeToLiveHFileCleaner();<a name="line.75"></a>
-<span class="sourceLineNo">076</span> // update the time info for the file, so the cleaner removes it<a name="line.76"></a>
-<span class="sourceLineNo">077</span> fs.setTimes(file, createTime - 100, -1);<a name="line.77"></a>
-<span class="sourceLineNo">078</span> Configuration conf = UTIL.getConfiguration();<a name="line.78"></a>
-<span class="sourceLineNo">079</span> conf.setLong(TimeToLiveHFileCleaner.TTL_CONF_KEY, 100);<a name="line.79"></a>
-<span class="sourceLineNo">080</span> cleaner.setConf(conf);<a name="line.80"></a>
-<span class="sourceLineNo">081</span> assertTrue("File not set deletable - check mod time:" + getFileStats(file, fs)<a name="line.81"></a>
-<span class="sourceLineNo">082</span> + " with create time:" + createTime, cleaner.isFileDeletable(fs.getFileStatus(file)));<a name="line.82"></a>
-<span class="sourceLineNo">083</span> }<a name="line.83"></a>
-<span class="sourceLineNo">084</span><a name="line.84"></a>
-<span class="sourceLineNo">085</span> /**<a name="line.85"></a>
-<span class="sourceLineNo">086</span> * @param file to check<a name="line.86"></a>
-<span class="sourceLineNo">087</span> * @return loggable information about the file<a name="line.87"></a>
-<span class="sourceLineNo">088</span> */<a name="line.88"></a>
-<span class="sourceLineNo">089</span> private String getFileStats(Path file, FileSystem fs) throws IOException {<a name="line.89"></a>
-<span class="sourceLineNo">090</span> FileStatus status = fs.getFileStatus(file);<a name="line.90"></a>
-<span class="sourceLineNo">091</span> return "File" + file + ", mtime:" + status.getModificationTime() + ", atime:"<a name="line.91"></a>
-<span class="sourceLineNo">092</span> + status.getAccessTime();<a name="line.92"></a>
-<span class="sourceLineNo">093</span> }<a name="line.93"></a>
-<span class="sourceLineNo">094</span><a name="line.94"></a>
-<span class="sourceLineNo">095</span> @Test(timeout = 60 *1000)<a name="line.95"></a>
-<span class="sourceLineNo">096</span> public void testHFileCleaning() throws Exception {<a name="line.96"></a>
-<span class="sourceLineNo">097</span> final EnvironmentEdge originalEdge = EnvironmentEdgeManager.getDelegate();<a name="line.97"></a>
-<span class="sourceLineNo">098</span> String prefix = "someHFileThatWouldBeAUUID";<a name="line.98"></a>
-<span class="sourceLineNo">099</span> Configuration conf = UTIL.getConfiguration();<a name="line.99"></a>
-<span class="sourceLineNo">100</span> // set TTL<a name="line.100"></a>
-<span class="sourceLineNo">101</span> long ttl = 2000;<a name="line.101"></a>
-<span class="sourceLineNo">102</span> conf.set(HFileCleaner.MASTER_HFILE_CLEANER_PLUGINS,<a name="line.102"></a>
-<span class="sourceLineNo">103</span> "org.apache.hadoop.hbase.master.cleaner.TimeToLiveHFileCleaner");<a name="line.103"></a>
-<span class="sourceLineNo">104</span> conf.setLong(TimeToLiveHFileCleaner.TTL_CONF_KEY, ttl);<a name="line.104"></a>
-<span class="sourceLineNo">105</span> Server server = new DummyServer();<a name="line.105"></a>
-<span class="sourceLineNo">106</span> Path archivedHfileDir = new Path(UTIL.getDataTestDirOnTestFS(), HConstants.HFILE_ARCHIVE_DIRECTORY);<a name="line.106"></a>
-<span class="sourceLineNo">107</span> FileSystem fs = FileSystem.get(conf);<a name="line.107"></a>
-<span class="sourceLineNo">108</span> HFileCleaner cleaner = new HFileCleaner(1000, server, conf, fs, archivedHfileDir);<a name="line.108"></a>
-<span class="sourceLineNo">109</span><a name="line.109"></a>
-<span class="sourceLineNo">110</span> // Create 2 invalid files, 1 "recent" file, 1 very new file and 30 old files<a name="line.110"></a>
-<span class="sourceLineNo">111</span> final long createTime = System.currentTimeMillis();<a name="line.111"></a>
-<span class="sourceLineNo">112</span> fs.delete(archivedHfileDir, true);<a name="line.112"></a>
-<span class="sourceLineNo">113</span> fs.mkdirs(archivedHfileDir);<a name="line.113"></a>
-<span class="sourceLineNo">114</span> // Case 1: 1 invalid file, which should be deleted directly<a name="line.114"></a>
-<span class="sourceLineNo">115</span> fs.createNewFile(new Path(archivedHfileDir, "dfd-dfd"));<a name="line.115"></a>
-<span class="sourceLineNo">116</span> // Case 2: 1 "recent" file, not even deletable for the first log cleaner<a name="line.116"></a>
-<span class="sourceLineNo">117</span> // (TimeToLiveLogCleaner), so we are not going down the chain<a name="line.117"></a>
-<span class="sourceLineNo">118</span> LOG.debug("Now is: " + createTime);<a name="line.118"></a>
-<span class="sourceLineNo">119</span> for (int i = 1; i < 32; i++) {<a name="line.119"></a>
-<span class="sourceLineNo">120</span> // Case 3: old files which would be deletable for the first log cleaner<a name="line.120"></a>
-<span class="sourceLineNo">121</span> // (TimeToLiveHFileCleaner),<a name="line.121"></a>
-<span class="sourceLineNo">122</span> Path fileName = new Path(archivedHfileDir, (prefix + "." + (createTime + i)));<a name="line.122"></a>
-<span class="sourceLineNo">123</span> fs.createNewFile(fileName);<a name="line.123"></a>
-<span class="sourceLineNo">124</span> // set the creation time past ttl to ensure that it gets removed<a name="line.124"></a>
-<span class="sourceLineNo">125</span> fs.setTimes(fileName, createTime - ttl - 1, -1);<a name="line.125"></a>
-<span class="sourceLineNo">126</span> LOG.debug("Creating " + getFileStats(fileName, fs));<a name="line.126"></a>
-<span class="sourceLineNo">127</span> }<a name="line.127"></a>
-<span class="sourceLineNo">128</span><a name="line.128"></a>
-<span class="sourceLineNo">129</span> // Case 2: 1 newer file, not even deletable for the first log cleaner<a name="line.129"></a>
-<span class="sourceLineNo">130</span> // (TimeToLiveLogCleaner), so we are not going down the chain<a name="line.130"></a>
-<span class="sourceLineNo">131</span> Path saved = new Path(archivedHfileDir, prefix + ".00000000000");<a name="line.131"></a>
-<span class="sourceLineNo">132</span> fs.createNewFile(saved);<a name="line.132"></a>
-<span class="sourceLineNo">133</span> // set creation time within the ttl<a name="line.133"></a>
-<span class="sourceLineNo">134</span> fs.setTimes(saved, createTime - ttl / 2, -1);<a name="line.134"></a>
-<span class="sourceLineNo">135</span> LOG.debug("Creating " + getFileStats(saved, fs));<a name="line.135"></a>
-<span class="sourceLineNo">136</span> for (FileStatus stat : fs.listStatus(archivedHfileDir)) {<a name="line.136"></a>
-<span class="sourceLineNo">137</span> LOG.debug(stat.getPath().toString());<a name="line.137"></a>
-<span class="sourceLineNo">138</span> }<a name="line.138"></a>
-<span class="sourceLineNo">139</span><a name="line.139"></a>
-<span class="sourceLineNo">140</span> assertEquals(33, fs.listStatus(archivedHfileDir).length);<a name="line.140"></a>
-<span class="sourceLineNo">141</span><a name="line.141"></a>
-<span class="sourceLineNo">142</span> // set a custom edge manager to handle time checking<a name="line.142"></a>
-<span class="sourceLineNo">143</span> EnvironmentEdge setTime = new EnvironmentEdge() {<a name="line.143"></a>
-<span class="sourceLineNo">144</span> @Override<a name="line.144"></a>
-<span class="sourceLineNo">145</span> public long currentTime() {<a name="line.145"></a>
-<span class="sourceLineNo">146</span> return createTime;<a name="line.146"></a>
-<span class="sourceLineNo">147</span> }<a name="line.147"></a>
-<span class="sourceLineNo">148</span> };<a name="line.148"></a>
-<span class="sourceLineNo">149</span> EnvironmentEdgeManager.injectEdge(setTime);<a name="line.149"></a>
-<span class="sourceLineNo">150</span><a name="line.150"></a>
-<span class="sourceLineNo">151</span> // run the chore<a name="line.151"></a>
-<span class="sourceLineNo">152</span> cleaner.chore();<a name="line.152"></a>
+<span class="sourceLineNo">025</span>import java.util.Random;<a name="line.25"></a>
+<span class="sourceLineNo">026</span><a name="line.26"></a>
+<span class="sourceLineNo">027</span>import org.apache.commons.logging.Log;<a name="line.27"></a>
+<span class="sourceLineNo">028</span>import org.apache.commons.logging.LogFactory;<a name="line.28"></a>
+<span class="sourceLineNo">029</span>import org.apache.hadoop.conf.Configuration;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import org.apache.hadoop.fs.FSDataOutputStream;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import org.apache.hadoop.fs.FileStatus;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.apache.hadoop.fs.FileSystem;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import org.apache.hadoop.fs.Path;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.ChoreService;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.CoordinatedStateManager;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.HConstants;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.Server;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.ServerName;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.client.ClusterConnection;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.testclassification.MasterTests;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.util.EnvironmentEdge;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.zookeeper.MetaTableLocator;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.junit.AfterClass;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.junit.Assert;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.junit.BeforeClass;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.junit.Test;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.junit.experimental.categories.Category;<a name="line.51"></a>
+<span class="sourceLineNo">052</span><a name="line.52"></a>
+<span class="sourceLineNo">053</span>@Category({MasterTests.class, MediumTests.class})<a name="line.53"></a>
+<span class="sourceLineNo">054</span>public class TestHFileCleaner {<a name="line.54"></a>
+<span class="sourceLineNo">055</span> private static final Log LOG = LogFactory.getLog(TestHFileCleaner.class);<a name="line.55"></a>
+<span class="sourceLineNo">056</span><a name="line.56"></a>
+<span class="sourceLineNo">057</span> private final static HBaseTestingUtility UTIL = new HBaseTestingUtility();<a name="line.57"></a>
+<span class="sourceLineNo">058</span><a name="line.58"></a>
+<span class="sourceLineNo">059</span> @BeforeClass<a name="line.59"></a>
+<span class="sourceLineNo">060</span> public static void setupCluster() throws Exception {<a name="line.60"></a>
+<span class="sourceLineNo">061</span> // have to use a minidfs cluster because the localfs doesn't modify file times correctly<a name="line.61"></a>
+<span class="sourceLineNo">062</span> UTIL.startMiniDFSCluster(1);<a name="line.62"></a>
+<span class="sourceLineNo">063</span> }<a name="line.63"></a>
+<span class="sourceLineNo">064</span><a name="line.64"></a>
+<span class="sourceLineNo">065</span> @AfterClass<a name="line.65"></a>
+<span class="sourceLineNo">066</span> public static void shutdownCluster() throws IOException {<a name="line.66"></a>
+<span class="sourceLineNo">067</span> UTIL.shutdownMiniDFSCluster();<a name="line.67"></a>
+<span class="sourceLineNo">068</span> }<a name="line.68"></a>
+<span class="sourceLineNo">069</span><a name="line.69"></a>
+<span class="sourceLineNo">070</span> @Test<a name="line.70"></a>
+<span class="sourceLineNo">071</span> public void testTTLCleaner() throws IOException, InterruptedException {<a name="line.71"></a>
+<span class="sourceLineNo">072</span> FileSystem fs = UTIL.getDFSCluster().getFileSystem();<a name="line.72"></a>
+<span class="sourceLineNo">073</span> Path root = UTIL.getDataTestDirOnTestFS();<a name="line.73"></a>
+<span class="sourceLineNo">074</span> Path file = new Path(root, "file");<a name="line.74"></a>
+<span class="sourceLineNo">075</span> fs.createNewFile(file);<a name="line.75"></a>
+<span class="sourceLineNo">076</span> long createTime = System.currentTimeMillis();<a name="line.76"></a>
+<span class="sourceLineNo">077</span> assertTrue("Test file not created!", fs.exists(file));<a name="line.77"></a>
+<span class="sourceLineNo">078</span> TimeToLiveHFileCleaner cleaner = new TimeToLiveHFileCleaner();<a name="line.78"></a>
+<span class="sourceLineNo">079</span> // update the time info for the file, so the cleaner removes it<a name="line.79"></a>
+<span class="sourceLineNo">080</span> fs.setTimes(file, createTime - 100, -1);<a name="line.80"></a>
+<span class="sourceLineNo">081</span> Configuration conf = UTIL.getConfiguration();<a name="line.81"></a>
+<span class="sourceLineNo">082</span> conf.setLong(TimeToLiveHFileCleaner.TTL_CONF_KEY, 100);<a name="line.82"></a>
+<span class="sourceLineNo">083</span> cleaner.setConf(conf);<a name="line.83"></a>
+<span class="sourceLineNo">084</span> assertTrue("File not set deletable - check mod time:" + getFileStats(file, fs)<a name="line.84"></a>
+<span class="sourceLineNo">085</span> + " with create time:" + createTime, cleaner.isFileDeletable(fs.getFileStatus(file)));<a name="line.85"></a>
+<span class="sourceLineNo">086</span> }<a name="line.86"></a>
+<span class="sourceLineNo">087</span><a name="line.87"></a>
+<span class="sourceLineNo">088</span> /**<a name="line.88"></a>
+<span class="sourceLineNo">089</span> * @param file to check<a name="line.89"></a>
+<span class="sourceLineNo">090</span> * @return loggable information about the file<a name="line.90"></a>
+<span class="sourceLineNo">091</span> */<a name="line.91"></a>
+<span class="sourceLineNo">092</span> private String getFileStats(Path file, FileSystem fs) throws IOException {<a name="line.92"></a>
+<span class="sourceLineNo">093</span> FileStatus status = fs.getFileStatus(file);<a name="line.93"></a>
+<span class="sourceLineNo">094</span> return "File" + file + ", mtime:" + status.getModificationTime() + ", atime:"<a name="line.94"></a>
+<span class="sourceLineNo">095</span> + status.getAccessTime();<a name="line.95"></a>
+<span class="sourceLineNo">096</span> }<a name="line.96"></a>
+<span class="sourceLineNo">097</span><a name="line.97"></a>
+<span class="sourceLineNo">098</span> @Test(timeout = 60 *1000)<a name="line.98"></a>
+<span class="sourceLineNo">099</span> public void testHFileCleaning() throws Exception {<a name="line.99"></a>
+<span class="sourceLineNo">100</span> final EnvironmentEdge originalEdge = EnvironmentEdgeManager.getDelegate();<a name="line.100"></a>
+<span class="sourceLineNo">101</span> String prefix = "someHFileThatWouldBeAUUID";<a name="line.101"></a>
+<span class="sourceLineNo">102</span> Configuration conf = UTIL.getConfiguration();<a name="line.102"></a>
+<span class="sourceLineNo">103</span> // set TTL<a name="line.103"></a>
+<span class="sourceLineNo">104</span> long ttl = 2000;<a name="line.104"></a>
+<span class="sourceLineNo">105</span> conf.set(HFileCleaner.MASTER_HFILE_CLEANER_PLUGINS,<a name="line.105"></a>
+<span class="sourceLineNo">106</span> "org.apache.hadoop.hbase.master.cleaner.TimeToLiveHFileCleaner");<a name="line.106"></a>
+<span class="sourceLineNo">107</span> conf.setLong(TimeToLiveHFileCleaner.TTL_CONF_KEY, ttl);<a name="line.107"></a>
+<span class="sourceLineNo">108</span> Server server = new DummyServer();<a name="line.108"></a>
+<span class="sourceLineNo">109</span> Path archivedHfileDir = new Path(UTIL.getDataTestDirOnTestFS(), HConstants.HFILE_ARCHIVE_DIRECTORY);<a name="line.109"></a>
+<span class="sourceLineNo">110</span> FileSystem fs = FileSystem.get(conf);<a name="line.110"></a>
+<span class="sourceLineNo">111</span> HFileCleaner cleaner = new HFileCleaner(1000, server, conf, fs, archivedHfileDir);<a name="line.111"></a>
+<span class="sourceLineNo">112</span><a name="line.112"></a>
+<span class="sourceLineNo">113</span> // Create 2 invalid files, 1 "recent" file, 1 very new file and 30 old files<a name="line.113"></a>
+<span class="sourceLineNo">114</span> final long createTime = System.currentTimeMillis();<a name="line.114"></a>
+<span class="sourceLineNo">115</span> fs.delete(archivedHfileDir, true);<a name="line.115"></a>
+<span class="sourceLineNo">116</span> fs.mkdirs(archivedHfileDir);<a name="line.116"></a>
+<span class="sourceLineNo">117</span> // Case 1: 1 invalid file, which should be deleted directly<a name="line.117"></a>
+<span class="sourceLineNo">118</span> fs.createNewFile(new Path(archivedHfileDir, "dfd-dfd"));<a name="line.118"></a>
+<span class="sourceLineNo">119</span> // Case 2: 1 "recent" file, not even deletable for the first log cleaner<a name="line.119"></a>
+<span class="sourceLineNo">120</span> // (TimeToLiveLogCleaner), so we are not going down the chain<a name="line.120"></a>
+<span class="sourceLineNo">121</span> LOG.debug("Now is: " + createTime);<a name="line.121"></a>
+<span class="sourceLineNo">122</span> for (int i = 1; i < 32; i++) {<a name="line.122"></a>
+<span class="sourceLineNo">123</span> // Case 3: old files which would be deletable for the first log cleaner<a name="line.123"></a>
+<span class="sourceLineNo">124</span> // (TimeToLiveHFileCleaner),<a name="line.124"></a>
+<span class="sourceLineNo">125</span> Path fileName = new Path(archivedHfileDir, (prefix + "." + (createTime + i)));<a name="line.125"></a>
+<span class="sourceLineNo">126</span> fs.createNewFile(fileName);<a name="line.126"></a>
+<span class="sourceLineNo">127</span> // set the creation time past ttl to ensure that it gets removed<a name="line.127"></a>
+<span class="sourceLineNo">128</span> fs.setTimes(fileName, createTime - ttl - 1, -1);<a name="line.128"></a>
+<span class="sourceLineNo">129</span> LOG.debug("Creating " + getFileStats(fileName, fs));<a name="line.129"></a>
+<span class="sourceLineNo">130</span> }<a name="line.130"></a>
+<span class="sourceLineNo">131</span><a name="line.131"></a>
+<span class="sourceLineNo">132</span> // Case 2: 1 newer file, not even deletable for the first log cleaner<a name="line.132"></a>
+<span class="sourceLineNo">133</span> // (TimeToLiveLogCleaner), so we are not going down the chain<a name="line.133"></a>
+<span class="sourceLineNo">134</span> Path saved = new Path(archivedHfileDir, prefix + ".00000000000");<a name="line.134"></a>
+<span class="sourceLineNo">135</span> fs.createNewFile(saved);<a name="line.135"></a>
+<span class="sourceLineNo">136</span> // set creation time within the ttl<a name="line.136"></a>
+<span class="sourceLineNo">137</span> fs.setTimes(saved, createTime - ttl / 2, -1);<a name="line.137"></a>
+<span class="sourceLineNo">138</span> LOG.debug("Creating " + getFileStats(saved, fs));<a name="line.138"></a>
+<span class="sourceLineNo">139</span> for (FileStatus stat : fs.listStatus(archivedHfileDir)) {<a name="line.139"></a>
+<span class="sourceLineNo">140</span> LOG.debug(stat.getPath().toString());<a name="line.140"></a>
+<span class="sourceLineNo">141</span> }<a name="line.141"></a>
+<span class="sourceLineNo">142</span><a name="line.142"></a>
+<span class="sourceLineNo">143</span> assertEquals(33, fs.listStatus(archivedHfileDir).length);<a name="line.143"></a>
+<span class="sourceLineNo">144</span><a name="line.144"></a>
+<span class="sourceLineNo">145</span> // set a custom edge manager to handle time checking<a name="line.145"></a>
+<span class="sourceLineNo">146</span> EnvironmentEdge setTime = new EnvironmentEdge() {<a name="line.146"></a>
+<span class="sourceLineNo">147</span> @Override<a name="line.147"></a>
+<span class="sourceLineNo">148</span> public long currentTime() {<a name="line.148"></a>
+<span class="sourceLineNo">149</span> return createTime;<a name="line.149"></a>
+<span class="sourceLineNo">150</span> }<a name="line.150"></a>
+<span class="sourceLineNo">151</span> };<a name="line.151"></a>
+<span class="sourceLineNo">152</span> EnvironmentEdgeManager.injectEdge(setTime);<a name="line.152"></a>
<span class="sourceLineNo">153</span><a name="line.153"></a>
-<span class="sourceLineNo">154</span> // ensure we only end up with the saved file<a name="line.154"></a>
-<span class="sourceLineNo">155</span> assertEquals(1, fs.listStatus(archivedHfileDir).length);<a name="line.155"></a>
+<span class="sourceLineNo">154</span> // run the chore<a name="line.154"></a>
+<span class="sourceLineNo">155</span> cleaner.chore();<a name="line.155"></a>
<span class="sourceLineNo">156</span><a name="line.156"></a>
-<span class="sourceLineNo">157</span> for (FileStatus file : fs.listStatus(archivedHfileDir)) {<a name="line.157"></a>
-<span class="sourceLineNo">158</span> LOG.debug("Kept hfiles: " + file.getPath().getName());<a name="line.158"></a>
-<span class="sourceLineNo">159</span> }<a name="line.159"></a>
-<span class="sourceLineNo">160</span><a name="line.160"></a>
-<span class="sourceLineNo">161</span> // reset the edge back to the original edge<a name="line.161"></a>
-<span class="sourceLineNo">162</span> EnvironmentEdgeManager.injectEdge(originalEdge);<a name="line.162"></a>
-<span class="sourceLineNo">163</span> }<a name="line.163"></a>
-<span class="sourceLineNo">164</span><a name="line.164"></a>
-<span class="sourceLineNo">165</span> @Test<a name="line.165"></a>
-<span class="sourceLineNo">166</span> public void testRemovesEmptyDirectories() throws Exception {<a name="line.166"></a>
-<span class="sourceLineNo">167</span> Configuration conf = UTIL.getConfiguration();<a name="line.167"></a>
-<span class="sourceLineNo">168</span> // no cleaner policies = delete all files<a name="line.168"></a>
-<span class="sourceLineNo">169</span> conf.setStrings(HFileCleaner.MASTER_HFILE_CLEANER_PLUGINS, "");<a name="line.169"></a>
-<span class="sourceLineNo">170</span> Server server = new DummyServer();<a name="line.170"></a>
-<span class="sourceLineNo">171</span> Path archivedHfileDir = new Path(UTIL.getDataTestDirOnTestFS(), HConstants.HFILE_ARCHIVE_DIRECTORY);<a name="line.171"></a>
-<span class="sourceLineNo">172</span><a name="line.172"></a>
-<span class="sourceLineNo">173</span> // setup the cleaner<a name="line.173"></a>
-<span class="sourceLineNo">174</span> FileSystem fs = UTIL.getDFSCluster().getFileSystem();<a name="line.174"></a>
-<span class="sourceLineNo">175</span> HFileCleaner cleaner = new HFileCleaner(1000, server, conf, fs, archivedHfileDir);<a name="line.175"></a>
-<span class="sourceLineNo">176</span><a name="line.176"></a>
-<span class="sourceLineNo">177</span> // make all the directories for archiving files<a name="line.177"></a>
-<span class="sourceLineNo">178</span> Path table = new Path(archivedHfileDir, "table");<a name="line.178"></a>
-<span class="sourceLineNo">179</span> Path region = new Path(table, "regionsomthing");<a name="line.179"></a>
-<span class="sourceLineNo">180</span> Path family = new Path(region, "fam");<a name="line.180"></a>
-<span class="sourceLineNo">181</span> Path file = new Path(family, "file12345");<a name="line.181"></a>
-<span class="sourceLineNo">182</span> fs.mkdirs(family);<a name="line.182"></a>
-<span class="sourceLineNo">183</span> if (!fs.exists(family)) throw new RuntimeException("Couldn't create test family:" + family);<a name="line.183"></a>
-<span class="sourceLineNo">184</span> fs.create(file).close();<a name="line.184"></a>
-<span class="sourceLineNo">185</span> if (!fs.exists(file)) throw new RuntimeException("Test file didn't get created:" + file);<a name="line.185"></a>
-<span class="sourceLineNo">186</span><a name="line.186"></a>
-<span class="sourceLineNo">187</span> // run the chore to cleanup the files (and the directories above it)<a name="line.187"></a>
-<span class="sourceLineNo">188</span> cleaner.chore();<a name="line.188"></a>
+<span class="sourceLineNo">157</span> // ensure we only end up with the saved file<a name="line.157"></a>
+<span class="sourceLineNo">158</span> assertEquals(1, fs.listStatus(archivedHfileDir).length);<a name="line.158"></a>
+<span class="sourceLineNo">159</span><a name="line.159"></a>
+<span class="sourceLineNo">160</span> for (FileStatus file : fs.listStatus(archivedHfileDir)) {<a name="line.160"></a>
+<span class="sourceLineNo">161</span> LOG.debug("Kept hfiles: " + file.getPath().getName());<a name="line.161"></a>
+<span class="sourceLineNo">162</span> }<a name="line.162"></a>
+<span class="sourceLineNo">163</span><a name="line.163"></a>
+<span class="sourceLineNo">164</span> // reset the edge back to the original edge<a name="line.164"></a>
+<span class="sourceLineNo">165</span> EnvironmentEdgeManager.injectEdge(originalEdge);<a name="line.165"></a>
+<span class="sourceLineNo">166</span> }<a name="line.166"></a>
+<span class="sourceLineNo">167</span><a name="line.167"></a>
+<span class="sourceLineNo">168</span> @Test<a name="line.168"></a>
+<span class="sourceLineNo">169</span> public void testRemovesEmptyDirectories() throws Exception {<a name="line.169"></a>
+<span class="sourceLineNo">170</span> Configuration conf = UTIL.getConfiguration();<a name="line.170"></a>
+<span class="sourceLineNo">171</span> // no cleaner policies = delete all files<a name="line.171"></a>
+<span class="sourceLineNo">172</span> conf.setStrings(HFileCleaner.MASTER_HFILE_CLEANER_PLUGINS, "");<a name="line.172"></a>
+<span class="sourceLineNo">173</span> Server server = new DummyServer();<a name="line.173"></a>
+<span class="sourceLineNo">174</span> Path archivedHfileDir = new Path(UTIL.getDataTestDirOnTestFS(), HConstants.HFILE_ARCHIVE_DIRECTORY);<a name="line.174"></a>
+<span class="sourceLineNo">175</span><a name="line.175"></a>
+<span class="sourceLineNo">176</span> // setup the cleaner<a name="line.176"></a>
+<span class="sourceLineNo">177</span> FileSystem fs = UTIL.getDFSCluster().getFileSystem();<a name="line.177"></a>
+<span class="sourceLineNo">178</span> HFileCleaner cleaner = new HFileCleaner(1000, server, conf, fs, archivedHfileDir);<a name="line.178"></a>
+<span class="sourceLineNo">179</span><a name="line.179"></a>
+<span class="sourceLineNo">180</span> // make all the directories for archiving files<a name="line.180"></a>
+<span class="sourceLineNo">181</span> Path table = new Path(archivedHfileDir, "table");<a name="line.181"></a>
+<span class="sourceLineNo">182</span> Path region = new Path(table, "regionsomthing");<a name="line.182"></a>
+<span class="sourceLineNo">183</span> Path family = new Path(region, "fam");<a name="line.183"></a>
+<span class="sourceLineNo">184</span> Path file = new Path(family, "file12345");<a name="line.184"></a>
+<span class="sourceLineNo">185</span> fs.mkdirs(family);<a name="line.185"></a>
+<span class="sourceLineNo">186</span> if (!fs.exists(family)) throw new RuntimeException("Couldn't create test family:" + family);<a name="line.186"></a>
+<span class="sourceLineNo">187</span> fs.create(file).close();<a name="line.187"></a>
+<span class="sourceLineNo">188</span> if (!fs.exists(file)) throw new RuntimeException("Test file didn't get created:" + file);<a name="line.188"></a>
<span class="sourceLineNo">189</span><a name="line.189"></a>
-<span class="sourceLineNo">190</span> // make sure all the parent directories get removed<a name="line.190"></a>
-<span class="sourceLineNo">191</span> assertFalse("family directory not removed for empty directory", fs.exists(family));<a name="line.191"></a>
-<span class="sourceLineNo">192</span> assertFalse("region directory not removed for empty directory", fs.exists(region));<a name="line.192"></a>
-<span class="sourceLineNo">193</span> assertFalse("table directory not removed for empty directory", fs.exists(table));<a name="line.193"></a>
-<span class="sourceLineNo">194</span> assertTrue("archive directory", fs.exists(archivedHfileDir));<a name="line.194"></a>
-<span class="sourceLineNo">195</span> }<a name="line.195"></a>
-<span class="sourceLineNo">196</span><a name="line.196"></a>
-<span class="sourceLineNo">197</span> static class DummyServer implements Server {<a name="line.197"></a>
-<span class="sourceLineNo">198</span><a name="line.198"></a>
-<span class="sourceLineNo">199</span> @Override<a name="line.199"></a>
-<span class="sourceLineNo">200</span> public Configuration getConfiguration() {<a name="line.200"></a>
-<span class="sourceLineNo">201</span> return UTIL.getConfiguration();<a name="line.201"></a>
-<span class="sourceLineNo">202</span> }<a name="line.202"></a>
-<span class="sourceLineNo">203</span><a name="line.203"></a>
-<span class="sourceLineNo">204</span> @Override<a name="line.204"></a>
-<span class="sourceLineNo">205</span> public ZooKeeperWatcher getZooKeeper() {<a name="line.205"></a>
-<span class="sourceLineNo">206</span> try {<a name="line.206"></a>
-<span class="sourceLineNo">207</span> return new ZooKeeperWatcher(getConfiguration(), "dummy server", this);<a name="line.207"></a>
-<span class="sourceLineNo">208</span> } catch (IOException e) {<a name="line.208"></a>
-<span class="sourceLineNo">209</span> e.printStackTrace();<a name="line.209"></a>
-<span class="sourceLineNo">210</span> }<a name="line.210"></a>
-<span class="sourceLineNo">211</span> return null;<a name="line.211"></a>
-<span class="sourceLineNo">212</span> }<a name="line.212"></a>
-<span class="sourceLineNo">213</span><a name="line.213"></a>
-<span class="sourceLineNo">214</span> @Override<a name="line.214"></a>
-<span class="sourceLineNo">215</span> public CoordinatedStateManager getCoordinatedStateManager() {<a name="line.215"></a>
-<span class="sourceLineNo">216</span> return null;<a name="line.216"></a>
-<span class="sourceLineNo">217</span> }<a name="line.217"></a>
-<span class="sourceLineNo">218</span><a name="line.218"></a>
-<span class="sourceLineNo">219</span> @Override<a name="line.219"></a>
-<span class="sourceLineNo">220</span> public ClusterConnection getConnection() {<a name="line.220"></a>
-<span class="sourceLineNo">221</span> return null;<a name="line.221"></a>
-<span class="sourceLineNo">222</span> }<a name="line.222"></a>
-<span class="sourceLineNo">223</span><a name="line.223"></a>
-<span class="sourceLineNo">224</span> @Override<a name="line.224"></a>
-<span class="sourceLineNo">225</span> public MetaTableLocator getMetaTableLocator() {<a name="line.225"></a>
-<span class="sourceLineNo">226</span> return null;<a name="line.226"></a>
-<span class="sourceLineNo">227</span> }<a name="line.227"></a>
-<span class="sourceLineNo">228</span><a name="line.228"></a>
-<span class="sourceLineNo">229</span> @Override<a name="line.229"></a>
-<span class="sourceLineNo">230</span> public ServerName getServerName() {<a name="line.230"></a>
-<span class="sourceLineNo">231</span> return ServerName.valueOf("regionserver,60020,000000");<a name="line.231"></a>
-<span class="sourceLineNo">232</span> }<a name="line.232"></a>
-<span class="sourceLineNo">233</span><a name="line.233"></a>
-<span class="sourceLineNo">234</span> @Override<a name="line.234"></a>
-<span class="sourceLineNo">235</span> public void abort(String why, Throwable e) {<a name="line.235"></a>
-<span class="sourceLineNo">236</span> }<a name="line.236"></a>
-<span class="sourceLineNo">237</span><a name="line.237"></a>
-<span class="sourceLineNo">238</span> @Override<a name="line.238"></a>
-<span class="sourceLineNo">239</span> public boolean isAborted() {<a name="line.239"></a>
-<span class="sourceLineNo">240</span> return false;<a name="line.240"></a>
-<span class="sourceLineNo">241</span> }<a name="line.241"></a>
-<span class="sourceLineNo">242</span><a name="line.242"></a>
-<span class="sourceLineNo">243</span> @Override<a name="line.243"></a>
-<span class="sourceLineNo">244</span> public void stop(String why) {<a name="line.244"></a>
-<span class="sourceLineNo">245</span> }<a name="line.245"></a>
-<span class="sourceLineNo">246</span><a name="line.246"></a>
-<span class="sourceLineNo">247</span> @Override<a name="line.247"></a>
-<span class="sourceLineNo">248</span> public boolean isStopped() {<a name="line.248"></a>
-<span class="sourceLineNo">249</span> return false;<a name="line.249"></a>
-<span class="sourceLineNo">250</span> }<a name="line.250"></a>
-<span class="sourceLineNo">251</span><a name="line.251"></a>
-<span class="sourceLineNo">252</span> @Override<a name="line.252"></a>
-<span class="sourceLineNo">253</span> public ChoreService getChoreService() {<a name="line.253"></a>
-<span class="sourceLineNo">254</span> return null;<a name="line.254"></a>
-<span class="sourceLineNo">255</span> }<a name="line.255"></a>
-<span class="sourceLineNo">256</span><a name="line.256"></a>
-<span class="sourceLineNo">257</span> @Override<a name="line.257"></a>
-<span class="sourceLineNo">258</span> public ClusterConnection getClusterConnection() {<a name="line.258"></a>
-<span class="sourceLineNo">259</span> // TODO Auto-generated method stub<a name="line.259"></a>
-<span class="sourceLineNo">260</span> return null;<a name="line.260"></a>
-<span class="sourceLineNo">261</span> }<a name="line.261"></a>
-<span class="sourceLineNo">262</span> }<a name="line.262"></a>
-<span class="sourceLineNo">263</span>}<a name="line.263"></a>
+<span class="sourceLineNo">190</span> // run the chore to cleanup the files (and the directories above it)<a name="line.190"></a>
+<span class="sourceLineNo">191</span> cleaner.chore();<a name="line.191"></a>
+<span class="sourceLineNo">192</span><a name="line.192"></a>
+<span class="sourceLineNo">193</span> // make sure all the parent directories get removed<a name="line.193"></a>
+<span class="sourceLineNo">194</span> assertFalse("family directory not removed for empty directory", fs.exists(family));<a name="line.194"></a>
+<span class="sourceLineNo">195</span> assertFalse("region directory not removed for empty directory", fs.exists(region));<a name="line.195"></a>
+<span class="sourceLineNo">196</span> assertFalse("table directory not removed for empty directory", fs.exists(table));<a name="line.196"></a>
+<span class="sourceLineNo">197</span> assertTrue("archive directory", fs.exists(archivedHfileDir));<a name="line.197"></a>
+<span class="sourceLineNo">198</span> }<a name="line.198"></a>
+<span class="sourceLineNo">199</span><a name="line.199"></a>
+<span class="sourceLineNo">200</span> static class DummyServer implements Server {<a name="line.200"></a>
+<span class="sourceLineNo">201</span><a name="line.201"></a>
+<span class="sourceLineNo">202</span> @Override<a name="line.202"></a>
+<span class="sourceLineNo">203</span> public Configuration getConfiguration() {<a name="line.203"></a>
+<span class="sourceLineNo">204</span> return UTIL.getConfiguration();<a name="line.204"></a>
+<span class="sourceLineNo">205</span> }<a name="line.205"></a>
+<span class="sourceLineNo">206</span><a name="line.206"></a>
+<span class="sourceLineNo">207</span> @Override<a name="line.207"></a>
+<span class="sourceLineNo">208</span> public ZooKeeperWatcher getZooKeeper() {<a name="line.208"></a>
+<span class="sourceLineNo">209</span> try {<a name="line.209"></a>
+<span class="sourceLineNo">210</span> return new ZooKeeperWatcher(getConfiguration(), "dummy server", this);<a name="line.210"></a>
+<span class="sourceLineNo">211</span> } catch (IOException e) {<a name="line.211"></a>
+<span class="sourceLineNo">212</span> e.printStackTrace();<a name="line.212"></a>
+<span class="sourceLineNo">213</span> }<a name="line.213"></a>
+<span class="sourceLineNo">214</span> return null;<a name="line.214"></a>
+<span class="sourceLineNo">215</span> }<a name="line.215"></a>
+<span class="sourceLineNo">216</span><a name="line.216"></a>
+<span class="sourceLineNo">217</span> @Override<a name="line.217"></a>
+<span class="sourceLineNo">218</span> public CoordinatedStateManager getCoordinatedStateManager() {<a name="line.218"></a>
+<span class="sourceLineNo">219</span> return null;<a name="line.219"></a>
+<span class="sourceLineNo">220</span> }<a name="line.220"></a>
+<span class="sourceLineNo">221</span><a name="line.221"></a>
+<span class="sourceLineNo">222</span> @Override<a name="line.222"></a>
+<span class="sourceLineNo">223</span> public ClusterConnection getConnection() {<a name="line.223"></a>
+<span class="sourceLineNo">224</span> return null;<a name="line.224"></a>
+<span class="sourceLineNo">225</span> }<a name="line.225"></a>
+<span class="sourceLineNo">226</span><a name="line.226"></a>
+<span class="sourceLineNo">227</span> @Override<a name="line.227"></a>
+<span class="sourceLineNo">228</span> public MetaTableLocator getMetaTableLocator() {<a name="line.228"></a>
+<span class="sourceLineNo">229</span> return null;<a name="line.229"></a>
+<span class="sourceLineNo">230</span> }<a name="line.230"></a>
+<span class="sourceLineNo">231</span><a name="line.231"></a>
+<span class="sourceLineNo">232</span> @Override<a name="line.232"></a>
+<span class="sourceLineNo">233</span> public ServerName getServerName() {<a name="line.233"></a>
+<span class="sourceLineNo">234</span> return ServerName.valueOf("regionserver,60020,000000");<a name="line.234"></a>
+<span class="sourceLineNo">235</span> }<a name="line.235"></a>
+<span class="sourceLineNo">236</span><a name="line.236"></a>
+<span class="sourceLineNo">237</span> @Override<a name="line.237"></a>
+<span class="sourceLineNo">238</span> public void abort(String why, Throwable e) {<a name="line.238"></a>
+<span class="sourceLineNo">239</span> }<a name="line.239"></a>
+<span class="sourceLineNo">240</span><a name="line.240"></a>
+<span class="sourceLineNo">241</span> @Override<a name="line.241"></a>
+<span class="sourceLineNo">242</span> public boolean isAborted() {<a name="line.242"></a>
+<span class="sourceLineNo">243</span> return false;<a name="line.243"></a>
+<span class="sourceLineNo">244</span> }<a name="line.244"></a>
+<span class="sourceLineNo">245</span><a name="line.245"></a>
+<span class="sourceLineNo">246</span> @Override<a name="line.246"></a>
+<span class="sourceLineNo">247</span> public void stop(String why) {<a name="line.247"></a>
+<span class="sourceLineNo">248</span> }<a name="line.248"></a>
+<span class="sourceLineNo">249</span><a name="line.249"></a>
+<span class="sourceLineNo">250</span> @Override<a name="line.250"></a>
+<span class="sourceLineNo">251</span> public boolean isStopped() {<a name="line.251"></a>
+<span class="sourceLineNo">252</span> return false;<a name="line.252"></a>
+<span class="sourceLineNo">253</span> }<a name="line.253"></a>
+<span class="sourceLineNo">254</span><a name="line.254"></a>
+<span class="sourceLineNo">255</span> @Override<a name="line.255"></a>
+<span class="sourceLineNo">256</span> public ChoreService getChoreService() {<a name="line.256"></a>
+<span class="sourceLineNo">257</span> return null;<a name="line.257"></a>
+<span class="sourceLineNo">258</span> }<a name="line.258"></a>
+<span class="sourceLineNo">259</span><a name="line.259"></a>
+<span class="sourceLineNo">260</span> @Override<a name="line.260"></a>
+<span class="sourceLineNo">261</span> public ClusterConnection getClusterConnection() {<a name="line.261"></a>
+<span class="sourceLineNo">262</span> // TODO Auto-generated method stub<a name="line.262"></a>
+<span class="sourceLineNo">263</span> return null;<a name="line.263"></a>
+<span class="sourceLineNo">264</span> }<a name="line.264"></a>
+<span class="sourceLineNo">265</span> }<a name="line.265"></a>
+<span class="sourceLineNo">266</span><a name="line.266"></a>
+<span class="sourceLineNo">267</span> @Test<a name="line.267"></a>
+<span class="sourceLineNo">268</span> public void testThreadCleanup() throws Exception {<a name="line.268"></a>
+<span class="sourceLineNo">269</span> Configuration conf = UTIL.getConfiguration();<a name="line.269"></a>
+<span class="sourceLineNo">270</span> conf.setStrings(HFileCleaner.MASTER_HFILE_CLEANER_PLUGINS, "");<a name="line.270"></a>
+<span class="sourceLineNo">271</span> Server server = new DummyServer();<a name="line.271"></a>
+<span class="sourceLineNo">272</span> Path archivedHfileDir =<a name="line.272"></a>
+<span class="sourceLineNo">273</span> new Path(UTIL.getDataTestDirOnTestFS(), HConstants.HFILE_ARCHIVE_DIRECTORY);<a name="line.273"></a>
+<span class="sourceLineNo">274</span><a name="line.274"></a>
+<span class="sourceLineNo">275</span> // setup the cleaner<a name="line.275"></a>
+<span class="sourceLineNo">276</span> FileSystem fs = UTIL.getDFSCluster().getFileSystem();<a name="line.276"></a>
+<span class="sourceLineNo">277</span> HFileCleaner cleaner = new HFileCleaner(1000, server, conf, fs, archivedHfileDir);<a name="line.277"></a>
+<span class="sourceLineNo">278</span> // clean up archive directory<a name="line.278"></a>
+<span class="sourceLineNo">279</span> fs.delete(archivedHfileDir, true);<a name="line.279"></a>
+<span class="sourceLineNo">280</span> fs.mkdirs(archivedHfileDir);<a name="line.280"></a>
+<span class="sourceLineNo">281</span> // create some file to delete<a name="line.281"></a>
+<span class="sourceLineNo">282</span> fs.createNewFile(new Path(archivedHfileDir, "dfd-dfd"));<a name="line.282"></a>
+<span class="sourceLineNo">283</span> // launch the chore<a name="line.283"></a>
+<span class="sourceLineNo">284</span> cleaner.chore();<a name="line.284"></a>
+<span class="sourceLineNo">285</span> // call cleanup<a name="line.285"></a>
+<span class="sourceLineNo">286</span> cleaner.cleanup();<a name="line.286"></a>
+<span class="sourceLineNo">287</span> // wait awhile for thread to die<a name="line.287"></a>
+<span class="sourceLineNo">288</span> Thread.sleep(100);<a name="line.288"></a>
+<span class="sourceLineNo">289</span> for (Thread thread : cleaner.getCleanerThreads()) {<a name="line.289"></a>
+<span class="sourceLineNo">290</span> Assert.assertFalse(thread.isAlive());<a name="line.290"></a>
+<span class="sourceLineNo">291</span> }<a name="line.291"></a>
+<span class="sourceLineNo">292</span> }<a name="line.292"></a>
+<span class="sourceLineNo">293</span><a name="line.293"></a>
+<span class="sourceLineNo">294</span> @Test<a name="line.294"></a>
+<span class="sourceLineNo">295</span> public void testLargeSmallIsolation() throws Exception {<a name="line.295"></a>
+<span class="sourceLineNo">296</span> Configuration conf = UTIL.getConfiguration();<a name="line.296"></a>
+<span class="sourceLineNo">297</span> // no cleaner policies = delete all files<a name="line.297"></a>
+<span class="sourceLineNo">298</span> conf.setStrings(HFileCleaner.MASTER_HFILE_CLEANER_PLUGINS, "");<a name="line.298"></a>
+<span class="sourceLineNo">299</span> conf.setInt(HFileCleaner.HFILE_DELETE_THROTTLE_THRESHOLD, 512 * 1024);<a name="line.299"></a>
+<span class="sourceLineNo">300</span> Server server = new DummyServer();<a name="line.300"></a>
+<span class="sourceLineNo">301</span> Path archivedHfileDir =<a name="line.301"></a>
+<span class="sourceLineNo">302</span> new Path(UTIL.getDataTestDirOnTestFS(), HConstants.HFILE_ARCHIVE_DIRECTORY);<a name="line.302"></a>
+<span class="sourceLineNo">303</span><a name="line.303"></a>
+<span class="sourceLineNo">304</span> // setup the cleaner<a name="line.304"></a>
+<span class="sourceLineNo">305</span> FileSystem fs = UTIL.getDFSCluster().getFileSystem();<a name="line.305"></a>
+<span class="sourceLineNo">306</span> HFileCleaner cleaner = new HFileCleaner(1000, server, conf, fs, archivedHfileDir);<a name="line.306"></a>
+<span class="sourceLineNo">307</span> // clean up archive directory<a name="line.307"></a>
+<span class="sourceLineNo">308</span> fs.delete(archivedHfileDir, true);<a name="line.308"></a>
+<span class="sourceLineNo">309</span> fs.mkdirs(archivedHfileDir);<a name="line.309"></a>
+<span class="sourceLineNo">310</span> // necessary set up<a name="line.310"></a>
+<span class="sourceLineNo">311</span> final int LARGE_FILE_NUM = 5;<a name="line.311"></a>
+<span class="sourceLineNo">312</span> final int SMALL_FILE_NUM = 20;<a name="line.312"></a>
+<span class="sourceLineNo">313</span> createFilesForTesting(LARGE_FILE_NUM, SMALL_FILE_NUM, fs, archivedHfileDir);<a name="line.313"></a>
+<span class="sourceLineNo">314</span> // call cleanup<a name="line.314"></a>
+<span class="sourceLineNo">315</span> cleaner.chore();<a name="line.315"></a>
+<span class="sourceLineNo">316</span><a name="line.316"></a>
+<span class="sourceLineNo">317</span> Assert.assertEquals(LARGE_FILE_NUM, cleaner.getNumOfDeletedLargeFiles());<a name="line.317"></a>
+<span class="sourceLineNo">318</span> Assert.assertEquals(SMALL_FILE_NUM, cleaner.getNumOfDeletedSmallFiles());<a name="line.318"></a>
+<span class="sourceLineNo">319</span> }<a name="line.319"></a>
+<span class="sourceLineNo">320</span><a name="line.320"></a>
+<span class="sourceLineNo">321</span> @Test(timeout = 60 * 1000)<a name="line.321"></a>
+<span class="sourceLineNo">322</span> public void testOnConfigurationChange() throws Exception {<a name="line.322"></a>
+<span class="sourceLineNo">323</span> // constants<a name="line.323"></a>
+<span class="sourceLineNo">324</span> final int ORIGINAL_THROTTLE_POINT = 512 * 1024;<a name="line.324"></a>
+<span class="sourceLineNo">325</span> final int ORIGINAL_QUEUE_SIZE = 512;<a name="line.325"></a>
+<span class="sourceLineNo">326</span> final int UPDATE_THROTTLE_POINT = 1024;// small enough to change large/small check<a name="line.326"></a>
+<span class="sourceLineNo">327</span> final int UPDATE_QUEUE_SIZE = 1024;<a name="line.327"></a>
+<span class="sourceLineNo">328</span> final int LARGE_FILE_NUM = 5;<a name="line.328"></a>
+<span class="sourceLineNo">329</span> final int SMALL_FILE_NUM = 20;<a name="line.329"></a>
+<span class="sourceLineNo">330</span><a name="line.330"></a>
+<span class="sourceLineNo">331</span> Configuration conf = UTIL.getConfiguration();<a name="line.331"></a>
+<span class="sourceLineNo">332</span> // no cleaner policies = delete all files<a name="line.332"></a>
+<span class="sourceLineNo">333</span> conf.setStrings(HFileCleaner.MASTER_HFILE_CLEANER_PLUGINS, "");<a name="line.333"></a>
+<span class="sourceLineNo">334</span> conf.setInt(HFileCleaner.HFILE_DELETE_THROTTLE_THRESHOLD, ORIGINAL_THROTTLE_POINT);<a name="line.334"></a>
+<span class="sourceLineNo">335</span> conf.setInt(HFileCleaner.LARGE_HFILE_DELETE_QUEUE_SIZE, ORIGINAL_QUEUE_SIZE);<a name="line.335"></a>
+<span class="sourceLineNo">336</span> conf.setInt(HFileCleaner.SMALL_HFILE_DELETE_QUEUE_SIZE, ORIGINAL_QUEUE_SIZE);<a name="line.336"></a>
+<span class="sourceLineNo">337</span> Server server = new DummyServer();<a name="line.337"></a>
+<span class="sourceLineNo">338</span> Path archivedHfileDir =<a name="line.338"></a>
+<span class="sourceLineNo">339</span> new Path(UTIL.getDataTestDirOnTestFS(), HConstants.HFILE_ARCHIVE_DIRECTORY);<a name="line.339"></a>
+<span class="sourceLineNo">340</span><a name="line.340"></a>
+<span class="sourceLineNo">341</span> // setup the cleaner<a name="line.341"></a>
+<span class="sourceLineNo">342</span> FileSystem fs = UTIL.getDFSCluster().getFileSystem();<a name="line.342"></a>
+<span class="sourceLineNo">343</span> final HFileCleaner cleaner = new HFileCleaner(1000, server, conf, fs, archivedHfileDir);<a name="line.343"></a>
+<span class="sourceLineNo">344</span> Assert.assertEquals(ORIGINAL_THROTTLE_POINT, cleaner.getThrottlePoint());<a name="line.344"></a>
+<span class="sourceLineNo">345</span> Assert.assertEquals(ORIGINAL_QUEUE_SIZE, cleaner.getLargeQueueSize());<a name="line.345"></a>
+<span class="sourceLineNo">346</span> Assert.assertEquals(ORIGINAL_QUEUE_SIZE, cleaner.getSmallQueueSize());<a name="line.346"></a>
+<span class="sourceLineNo">347</span><a name="line.347"></a>
+<span class="sourceLineNo">348</span> // clean up archive directory and create files for testing<a name="line.348"></a>
+<span class="sourceLineNo">349</span> fs.delete(archivedHfileDir, true);<a name="line.349"></a>
+<span class="sourceLineNo">350</span> fs.mkdirs(archivedHfileDir);<a name="line.350"></a>
+<span class="sourceLineNo">351</span> createFilesForTesting(LARGE_FILE_NUM, SMALL_FILE_NUM, fs, archivedHfileDir);<a name="line.351"></a>
+<span class="sourceLineNo">352</span><a name="line.352"></a>
+<span class="sourceLineNo">353</span> // call cleaner, run as daemon to test the interrupt-at-middle case<a name="line.353"></a>
+<span class="sourceLineNo">354</span> Thread t = new Thread() {<a name="line.354"></a>
+<span class="sourceLineNo">355</span> @Override<a name="line.355"></a>
+<span class="sourceLineNo">356</span> public void run() {<a name="line.356"></a>
+<span class="sourceLineNo">357</span> cleaner.chore();<a name="line.357"></a>
+<span class="sourceLineNo">358</span> }<a name="line.358"></a>
+<span class="sourceLineNo">359</span> };<a name="line.359"></a>
+<span class="sourceLineNo">360</span> t.setDaemon(true);<a name="line.360"></a>
+<span class="sourceLineNo">361</span> t.start();<a name="line.361"></a>
+<span class="sourceLineNo">362</span> // let the cleaner run for some while<a name="line.362"></a>
+<span class="sourceLineNo">363</span> Thread.sleep(20);<a name="line.363"></a>
+<span class="sourceLineNo">364</span><a name="line.364"></a>
+<span class="sourceLineNo">365</span> // trigger configuration change<a name="line.365"></a>
+<span class="sourceLineNo">366</span> Configuration newConf = new Configuration(conf);<a name="line.366"></a>
+<span class="sourceLineNo">367</span> newConf.setInt(HFileCleaner.HFILE_DELETE_THROTTLE_THRESHOLD, UPDATE_THROTTLE_POINT);<a name="line.367"></a>
+<span class="sourceLineNo">368</span> newConf.setInt(HFileCleaner.LARGE_HFILE_DELETE_QUEUE_SIZE, UPDATE_QUEUE_SIZE);<a name="line.368"></a>
+<span class="sourceLineNo">369</span> newConf.setInt(HFileCleaner.SMALL_HFILE_DELETE_QUEUE_SIZE, UPDATE_QUEUE_SIZE);<a name="line.369"></a>
+<span class="sourceLineNo">370</span> cleaner.onConfigurationChange(newConf);<a name="line.370"></a>
+<span class="sourceLineNo">371</span> LOG.debug("File deleted from large queue: " + cleaner.getNumOfDeletedLargeFiles()<a name="line.371"></a>
+<span class="sourceLineNo">372</span> + "; from small queue: " + cleaner.getNumOfDeletedSmallFiles());<a name="line.372"></a>
+<span class="sourceLineNo">373</span><a name="line.373"></a>
+<span class="sourceLineNo">374</span> // check values after change<a name="line.374"></a>
+<span class="sourceLineNo">375</span> Assert.assertEquals(UPDATE_THROTTLE_POINT, cleaner.getThrottlePoint());<a name="line.375"></a>
+<span class="sourceLineNo">376</span> Assert.assertEquals(UPDATE_QUEUE_SIZE, cleaner.getLargeQueueSize());<a name="line.376"></a>
+<span class="sourceLineNo">377</span> Assert.assertEquals(UPDATE_QUEUE_SIZE, cleaner.getSmallQueueSize());<a name="line.377"></a>
+<span class="sourceLineNo">378</span> Assert.assertEquals(2, cleaner.getCleanerThreads().size());<a name="line.378"></a>
+<span class="sourceLineNo">379</span><a name="line.379"></a>
+<span class="sourceLineNo">380</span> // wait until clean done and check<a name="line.380"></a>
+<span class="sourceLineNo">381</span> t.join();<a name="line.381"></a>
+<span class="sourceLineNo">382</span> LOG.debug("File deleted from large queue: " + cleaner.getNumOfDeletedLargeFiles()<a name="line.382"></a>
+<span class="sourceLineNo">383</span> + "; from small queue: " + cleaner.getNumOfDeletedSmallFiles());<a name="line.383"></a>
+<span class="sourceLineNo">384</span> Assert.assertTrue("Should delete more than " + LARGE_FILE_NUM<a name="line.384"></a>
+<span class="sourceLineNo">385</span> + " files from large queue but actually " + cleaner.getNumOfDeletedLargeFiles(),<a name="line.385"></a>
+<span class="sourceLineNo">386</span> cleaner.getNumOfDeletedLargeFiles() > LARGE_FILE_NUM);<a name="line.386"></a>
+<span class="sourceLineNo">387</span> Assert.assertTrue("Should delete less than " + SMALL_FILE_NUM<a name="line.387"></a>
+<span class="sourceLineNo">388</span> + " files from small queue but actually " + cleaner.getNumOfDeletedSmallFiles(),<a name="line.388"></a>
+<span class="sourceLineNo">389</span> cleaner.getNumOfDeletedSmallFiles() < SMALL_FILE_NUM);<a name="line.389"></a>
+<span class="sourceLineNo">390</span> }<a name="line.390"></a>
+<span class="sourceLineNo">391</span><a name="line.391"></a>
+<span class="sourceLineNo">392</span> private void createFilesForTesting(int largeFileNum, int smallFileNum, FileSystem fs,<a name="line.392"></a>
+<span class="sourceLineNo">393</span> Path archivedHfileDir) throws IOException {<a name="line.393"></a>
+<span class="sourceLineNo">394</span> final Random rand = new Random();<a name="line.394"></a>
+<span class="sourceLineNo">395</span> final byte[] large = new byte[1024 * 1024];<a name="line.395"></a>
+<span class="sourceLineNo">396</span> for (int i = 0; i < large.length; i++) {<a name="line.396"></a>
+<span class="sourceLineNo">397</span> large[i] = (byte) rand.nextInt(128);<a name="line.397"></a>
+<span class="sourceLineNo">398</span> }<a name="line.398"></a>
+<span class="sourceLineNo">399</span> final byte[] small = new byte[1024];<a name="line.399"></a>
+<span class="sourceLineNo">400</span> for (int i = 0; i < small.length; i++) {<a name="line.400"></a>
+<span class="sourceLineNo">401</span> small[i] = (byte) rand.nextInt(128);<a name="line.401"></a>
+<span class="sourceLineNo">402</span> }<a name="line.402"></a>
+<span class="sourceLineNo">403</span> // create large and small files<a name="line.403"></a>
+<span class="sourceLineNo">404</span> for (int i = 1; i <= largeFileNum; i++) {<a name="line.404"></a>
+<span class="sourceLineNo">405</span> FSDataOutputStream out = fs.create(new Path(archivedHfileDir, "large-file-" + i));<a name="line.405"></a>
+<span class="sourceLineNo">406</span> out.write(large);<a name="line.406"></a>
+<span class="sourceLineNo">407</span> out.close();<a name="line.407"></a>
+<span class="sourceLineNo">408</span> }<a name="line.408"></a>
+<span class="sourceLineNo">409</span> for (int i = 1; i <= smallFileNum; i++) {<a name="line.409"></a>
+<span class="sourceLineNo">410</span> FSDataOutputStream out = fs.create(new Path(archivedHfileDir, "small-file-" + i));<a name="line.410"></a>
+<span class="sourceLineNo">411</span> out.write(small);<a name="line.411"></a>
+<span class="sourceLineNo">412</span> out.close();<a name="line.412"></a>
+<span class="sourceLineNo">413</span> }<a name="line.413"></a>
+<span class="sourceLineNo">414</span> }<a name="line.414"></a>
+<span class="sourceLineNo">415</span>}<a name="line.415"></a>