You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "RaigorJiang (via GitHub)" <gi...@apache.org> on 2023/02/03 05:32:16 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new issue, #23953: Remove Hint DistSQL
RaigorJiang opened a new issue, #23953:
URL: https://github.com/apache/shardingsphere/issues/23953
Hi community,
Since [SQL Hint](https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-jdbc/special-api/sharding/hint/#use-special-sql-comments) is more convenient and compatible with Proxy, I think it is time to consider removing [Hint DistSQL](https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-proxy/distsql/syntax/ral/hint/).
#### Using DistSQL to implement Hint has the following problems:
1. To execute a query, the user needs to send `Hint DistSQL` and `DML SQL` separately, which is not friendly to use;
2. After using `Hint DistSQL`, the user needs to send an additional `CLEAR` statement;
3. When Hint is enabled, Proxy needs to make a special judgment on the connected thread, which increases the complexity; ([link](https://github.com/apache/shardingsphere/blob/efe9ee21266d6507dee4639eb0c19a6d98992325/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/state/impl/OKProxyState.java#L61))
Now, SQL Hint can perfectly solve the above problems, so I suggest to start the work of removing Hint DistSQL, with the following tasks:
- [ ] Remove `HintRALStatementExecutor` and implementation
- [ ] Remove `HintRALBackendHandler`
- [ ] Remove `HintRALStatement` and subclasses
- [ ] Remove Hint DistSQL documentation
- [ ] Remove the judgment related to Hint in `OKProxyState`
- [ ] Remove the configuration item: `proxy-hint-enabled`
- [ ] Remove related test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] anmui commented on issue #23953: Remove Hint DistSQL
Posted by "anmui (via GitHub)" <gi...@apache.org>.
anmui commented on issue #23953:
URL: https://github.com/apache/shardingsphere/issues/23953#issuecomment-1502626173
> Please try removing `proxy-hint-enabled` again. Proxy has introduced flow control in frontend #25081.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o commented on issue #23953: Remove Hint DistSQL
Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on issue #23953:
URL: https://github.com/apache/shardingsphere/issues/23953#issuecomment-1434079918
Hi @RaigorJiang , i want to join.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] anmui commented on issue #23953: Remove Hint DistSQL
Posted by "anmui (via GitHub)" <gi...@apache.org>.
anmui commented on issue #23953:
URL: https://github.com/apache/shardingsphere/issues/23953#issuecomment-1415639165
hi!i want to try,can i do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] anmui commented on issue #23953: Remove Hint DistSQL
Posted by "anmui (via GitHub)" <gi...@apache.org>.
anmui commented on issue #23953:
URL: https://github.com/apache/shardingsphere/issues/23953#issuecomment-1434775133
hi,I have completed 1,2,3,5,8….Can I still submit it？🥹
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang closed issue #23953: Remove Hint DistSQL
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang closed issue #23953: Remove Hint DistSQL
URL: https://github.com/apache/shardingsphere/issues/23953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #23953: Remove Hint DistSQL
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #23953:
URL: https://github.com/apache/shardingsphere/issues/23953#issuecomment-1415695925
Hi @anmui ,
Welcome here! This task affects many files and may not be suitable for beginners, but you can try to submit PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 closed issue #23953: Remove Hint DistSQL
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 closed issue #23953: Remove Hint DistSQL
URL: https://github.com/apache/shardingsphere/issues/23953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on issue #23953: Remove Hint DistSQL
Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on issue #23953:
URL: https://github.com/apache/shardingsphere/issues/23953#issuecomment-1502617476
Please try removing `proxy-hint-enabled` again. Proxy has introduced flow control in frontend #25081.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o commented on issue #23953: Remove Hint DistSQL
Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on issue #23953:
URL: https://github.com/apache/shardingsphere/issues/23953#issuecomment-1434794029
@anmui Ok, welcome, you submit pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #23953: Remove Hint DistSQL
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #23953:
URL: https://github.com/apache/shardingsphere/issues/23953#issuecomment-1441901047
According to the discussion in #24227, `proxy-hint-enabled` has not been removed, this needs to be investigated further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org