You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/08/24 19:06:24 UTC
[GitHub] [solr] stillalex opened a new pull request, #985: SOLR-16357 CaffeineCache ramBytes incorrect accounting on updates and deletes
stillalex opened a new pull request, #985:
URL: https://github.com/apache/solr/pull/985
SOLR-16357 CaffeineCache ramBytes incorrect accounting on updates and deletes
2 problematic scenarios:
* updates over existing value will double-add the key
* deletes will double-delete: once due to manual bookkeeping in the remove method and second due to the onRemoval callback
I also removed metricNames variable because it looked unused. Can rollback this change if needed.
https://issues.apache.org/jira/browse/SOLR-16357
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
CaffeineCache ramBytes accounting is incorrect on deletes and updates over exiting values.
# Solution
Updated ramBytes tracking code.
# Tests
Added basic tests for tracking changes to ramBytes value
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a diff in pull request #985: SOLR-16357 CaffeineCache ramBytes incorrect accounting on updates and deletes
Posted by GitBox <gi...@apache.org>.
madrob commented on code in PR #985:
URL: https://github.com/apache/solr/pull/985#discussion_r958504710
##########
solr/CHANGES.txt:
##########
@@ -118,6 +118,8 @@ Bug Fixes
* SOLR-16316: Fix debugQuery clicking on the Query UI does not show the debug.explain.structured option. (Shiming Li via Eric Pugh)
+* SOLR-16357: CaffeineCache ramBytes incorrect accounting on updates and deletes
Review Comment:
Typically we include the author in parenthesis here to allow proper attribution and recognition. How would you like to be credited? `stillalex`? Just `Alex`? Something else? If you'd prefer not to be included then we can merge as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #985: SOLR-16357 CaffeineCache ramBytes incorrect accounting on updates and deletes
Posted by GitBox <gi...@apache.org>.
madrob commented on PR #985:
URL: https://github.com/apache/solr/pull/985#issuecomment-1227237388
This looks good to me, can you add an entry to CHANGES.txt (probably under 9.1 section) and then we'll be good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on pull request #985: SOLR-16357 CaffeineCache ramBytes incorrect accounting on updates and deletes
Posted by GitBox <gi...@apache.org>.
stillalex commented on PR #985:
URL: https://github.com/apache/solr/pull/985#issuecomment-1227460587
thanks @madrob! updated the changes file too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on a diff in pull request #985: SOLR-16357 CaffeineCache ramBytes incorrect accounting on updates and deletes
Posted by GitBox <gi...@apache.org>.
stillalex commented on code in PR #985:
URL: https://github.com/apache/solr/pull/985#discussion_r959131445
##########
solr/CHANGES.txt:
##########
@@ -118,6 +118,8 @@ Bug Fixes
* SOLR-16316: Fix debugQuery clicking on the Query UI does not show the debug.explain.structured option. (Shiming Li via Eric Pugh)
+* SOLR-16357: CaffeineCache ramBytes incorrect accounting on updates and deletes
Review Comment:
@madrob you are right, thank you for the ping, totally forgot about this. updated now, please take another look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob merged pull request #985: SOLR-16357 CaffeineCache ramBytes incorrect accounting on updates and deletes
Posted by GitBox <gi...@apache.org>.
madrob merged PR #985:
URL: https://github.com/apache/solr/pull/985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org