You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/05/31 05:09:08 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5037: Updated PowerFlex/ScaleIO gateway client with some improvements.

sureshanaparti commented on a change in pull request #5037:
URL: https://github.com/apache/cloudstack/pull/5037#discussion_r642212778



##########
File path: engine/components-api/src/main/java/com/cloud/storage/StorageManager.java
##########
@@ -124,7 +124,7 @@
             "Storage",
             "60",
             "Timeout (in secs) for the storage pool client connection timeout (for managed pools). Currently only supported for PowerFlex.",
-            true,
+            false,

Review comment:
       > Just out of curiosity. Why is `STORAGE_POOL_CLIENT_TIMEOUT` changed from dynamic to static?
   
   @GabrielBrascher This config is currently support for ScaleIO only. It's value is picked by the ScaleIO client when it is created, which is either on the primary storage addition or management server (re)start (for existing pools). In order to apply this config value for existing pools, it is required to restart the management server. Changing this config to 'static' prompts the operator, to restart the management server to apply the new value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org