[GitHub] [trafficcontrol] rob05c opened a new pull request, #6933: Fix tc-health-client to handle credentials files with special characters.

[GitBox <gi...@apache.org>]

rob05c opened a new pull request, #6933:
URL: https://github.com/apache/trafficcontrol/pull/6933

   Currently, the tc-health-client does its own parsing of the credentials file, and doesn't correctly parse variables with special characters like `=` and ` ` in them.
   
   This fixes it to use `sh` to do the parsing, and return the result of declared variables. This will make it handle all special characters, comments, etc exactly like sh/bash, and should prevent any future issues with parsing.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Control Health Client (tc-health-client)
   
   ## What is the best way to verify this PR?
   Run tc-health-client with a credentials file with ` ` or `=` in the user, password, or URL variables, verify it works correctly.
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   - 6.1.x (but the Health Client is considered experimental)
   
   ## PR submission checklist
   - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
   - ~[x] This PR has documentation~ no docs, no interface change <!-- If not, please delete this text and explain why this PR does not need documentation. -->
   - [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp merged pull request #6933: Fix tc-health-client to handle credentials files with special characters.

[GitBox <gi...@apache.org>]

rawlinp merged PR #6933:
URL: https://github.com/apache/trafficcontrol/pull/6933


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org