You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apisix.apache.org by JunXu Chen <ch...@apache.org> on 2020/10/29 03:39:42 UTC
[DISCUSS] issues to be solved after the `manager api` refactoring
Hi, Community,
After the manager api refactoring, there are still many problems, as follow:
1. Access log:
Save to a local file, and can customize the path
Support log rotate
Support custom log format
2. Error log:
Currently only panic logs are retained, errors are just responded by apis.
We need to retain error logs.
Support custom error log level
Support saving to a local file, and can customize the file path
Support log rotate
3. Support custom listening IP and port
4. Support https, and custom cert and key path
5. Support IP restriction
6. ETCD configuration:
Currently supports environment variable config, need to change to config in
the config file
Support https connection
Support mTLS connection
Support identity authentication
7. Improve the ENV definition and deal with `dev`, `test` and `release`
accordingly
8. Support custom cup quantity
What do you think?
Thanks !
Re: [DISCUSS] issues to be solved after the `manager api` refactoring
Posted by JunXu Chen <ch...@apache.org>.
I am going to solve the log part today and plan to use the `zap` lib.
What do you think? Any suggestions?
On Thu, Oct 29, 2020 at 4:33 PM Zhiyuan Ju <ju...@apache.org> wrote:
> Just updated the docs and codes, and adding part of vars into the
> configuration file.
>
> [1] https://github.com/apache/apisix-dashboard/blob/v2.0/docs/deploy.md
> [2]
> https://github.com/apache/apisix-dashboard/blob/v2.0/docs/deploy.zh-CN.md
> [3] https://github.com/apache/apisix-dashboard/pull/598
>
> Best Regards!
> @ Zhiyuan Ju <https://www.shaoyaoju.org/>
>
>
> vincixu <vi...@apache.org> 于2020年10月29日周四 下午4:27写道：
>
> > Today, I released dashborad 2.0rc2 internally in the my company. In my
> > opinion, the biggest problems are as follows (the importance decreases in
> > order):
> > -Flatten the directories, and use Makefile to build project in root
> > directory without manually entering the manager-api directory to build
> > after the web build is completed
> > -Need a good configuration library to help us read the configuration from
> > the sources(such as env, json or yaml), so that we can better manage the
> > configuration
> > -Many problems on the code side, I will sort out them later
> >
> > BTW: I think the ENV variable(such as dev, beta, prod), this option is
> > useless for users,because they just care what configuration is.
> >
> > jinwei <gx...@163.com> 于2020年10月29日周四 下午12:12写道：
> >
> > > +1
> > >
> > >
> > >
> > >
> > >
> > > On 10/29/2020 12:11, Ming Wen wrote:
> > > yes, these are basic functions, you can create issues on github to
> track.
> > >
> > > Thanks,
> > > Ming Wen, Apache APISIX & Apache SkyWalking
> > > Twitter: _WenMing
> > >
> > >
> > > JunXu Chen <ch...@apache.org> 于2020年10月29日周四 上午11:39写道：
> > >
> > > > Hi, Community,
> > > >
> > > > After the manager api refactoring, there are still many problems, as
> > > > follow:
> > > >
> > > > 1. Access log:
> > > > Save to a local file, and can customize the path
> > > > Support log rotate
> > > > Support custom log format
> > > >
> > > > 2. Error log:
> > > > Currently only panic logs are retained, errors are just responded by
> > > apis.
> > > > We need to retain error logs.
> > > > Support custom error log level
> > > > Support saving to a local file, and can customize the file path
> > > > Support log rotate
> > > >
> > > > 3. Support custom listening IP and port
> > > >
> > > > 4. Support https, and custom cert and key path
> > > >
> > > > 5. Support IP restriction
> > > >
> > > > 6. ETCD configuration:
> > > > Currently supports environment variable config, need to change to
> > config
> > > in
> > > > the config file
> > > > Support https connection
> > > > Support mTLS connection
> > > > Support identity authentication
> > > >
> > > > 7. Improve the ENV definition and deal with `dev`, `test` and
> `release`
> > > > accordingly
> > > >
> > > > 8. Support custom cup quantity
> > > >
> > > > What do you think?
> > > >
> > > > Thanks !
> > > >
> > >
> >
>
Re: [DISCUSS] issues to be solved after the `manager api` refactoring
Posted by Zhiyuan Ju <ju...@apache.org>.
Just updated the docs and codes, and adding part of vars into the
configuration file.
[1] https://github.com/apache/apisix-dashboard/blob/v2.0/docs/deploy.md
[2]
https://github.com/apache/apisix-dashboard/blob/v2.0/docs/deploy.zh-CN.md
[3] https://github.com/apache/apisix-dashboard/pull/598
Best Regards!
@ Zhiyuan Ju <https://www.shaoyaoju.org/>
vincixu <vi...@apache.org> 于2020年10月29日周四 下午4:27写道：
> Today, I released dashborad 2.0rc2 internally in the my company. In my
> opinion, the biggest problems are as follows (the importance decreases in
> order):
> -Flatten the directories, and use Makefile to build project in root
> directory without manually entering the manager-api directory to build
> after the web build is completed
> -Need a good configuration library to help us read the configuration from
> the sources(such as env, json or yaml), so that we can better manage the
> configuration
> -Many problems on the code side, I will sort out them later
>
> BTW: I think the ENV variable(such as dev, beta, prod), this option is
> useless for users,because they just care what configuration is.
>
> jinwei <gx...@163.com> 于2020年10月29日周四 下午12:12写道：
>
> > +1
> >
> >
> >
> >
> >
> > On 10/29/2020 12:11, Ming Wen wrote:
> > yes, these are basic functions, you can create issues on github to track.
> >
> > Thanks,
> > Ming Wen, Apache APISIX & Apache SkyWalking
> > Twitter: _WenMing
> >
> >
> > JunXu Chen <ch...@apache.org> 于2020年10月29日周四 上午11:39写道：
> >
> > > Hi, Community,
> > >
> > > After the manager api refactoring, there are still many problems, as
> > > follow:
> > >
> > > 1. Access log:
> > > Save to a local file, and can customize the path
> > > Support log rotate
> > > Support custom log format
> > >
> > > 2. Error log:
> > > Currently only panic logs are retained, errors are just responded by
> > apis.
> > > We need to retain error logs.
> > > Support custom error log level
> > > Support saving to a local file, and can customize the file path
> > > Support log rotate
> > >
> > > 3. Support custom listening IP and port
> > >
> > > 4. Support https, and custom cert and key path
> > >
> > > 5. Support IP restriction
> > >
> > > 6. ETCD configuration:
> > > Currently supports environment variable config, need to change to
> config
> > in
> > > the config file
> > > Support https connection
> > > Support mTLS connection
> > > Support identity authentication
> > >
> > > 7. Improve the ENV definition and deal with `dev`, `test` and `release`
> > > accordingly
> > >
> > > 8. Support custom cup quantity
> > >
> > > What do you think?
> > >
> > > Thanks !
> > >
> >
>
Re: [DISCUSS] issues to be solved after the `manager api` refactoring
Posted by Ming Wen <we...@apache.org>.
I can not agreed with you more.
Looking forward to perfecting this project soon
Thanks,
Ming Wen, Apache APISIX & Apache SkyWalking
Twitter: _WenMing
vincixu <vi...@apache.org> 于2020年10月29日周四 下午4:27写道：
> Today, I released dashborad 2.0rc2 internally in the my company. In my
> opinion, the biggest problems are as follows (the importance decreases in
> order):
> -Flatten the directories, and use Makefile to build project in root
> directory without manually entering the manager-api directory to build
> after the web build is completed
> -Need a good configuration library to help us read the configuration from
> the sources(such as env, json or yaml), so that we can better manage the
> configuration
> -Many problems on the code side, I will sort out them later
>
> BTW: I think the ENV variable(such as dev, beta, prod), this option is
> useless for users,because they just care what configuration is.
>
> jinwei <gx...@163.com> 于2020年10月29日周四 下午12:12写道：
>
> > +1
> >
> >
> >
> >
> >
> > On 10/29/2020 12:11, Ming Wen wrote:
> > yes, these are basic functions, you can create issues on github to track.
> >
> > Thanks,
> > Ming Wen, Apache APISIX & Apache SkyWalking
> > Twitter: _WenMing
> >
> >
> > JunXu Chen <ch...@apache.org> 于2020年10月29日周四 上午11:39写道：
> >
> > > Hi, Community,
> > >
> > > After the manager api refactoring, there are still many problems, as
> > > follow:
> > >
> > > 1. Access log:
> > > Save to a local file, and can customize the path
> > > Support log rotate
> > > Support custom log format
> > >
> > > 2. Error log:
> > > Currently only panic logs are retained, errors are just responded by
> > apis.
> > > We need to retain error logs.
> > > Support custom error log level
> > > Support saving to a local file, and can customize the file path
> > > Support log rotate
> > >
> > > 3. Support custom listening IP and port
> > >
> > > 4. Support https, and custom cert and key path
> > >
> > > 5. Support IP restriction
> > >
> > > 6. ETCD configuration:
> > > Currently supports environment variable config, need to change to
> config
> > in
> > > the config file
> > > Support https connection
> > > Support mTLS connection
> > > Support identity authentication
> > >
> > > 7. Improve the ENV definition and deal with `dev`, `test` and `release`
> > > accordingly
> > >
> > > 8. Support custom cup quantity
> > >
> > > What do you think?
> > >
> > > Thanks !
> > >
> >
>
Re: [DISCUSS] issues to be solved after the `manager api` refactoring
Posted by vincixu <vi...@apache.org>.
Today, I released dashborad 2.0rc2 internally in the my company. In my
opinion, the biggest problems are as follows (the importance decreases in
order):
-Flatten the directories, and use Makefile to build project in root
directory without manually entering the manager-api directory to build
after the web build is completed
-Need a good configuration library to help us read the configuration from
the sources(such as env, json or yaml), so that we can better manage the
configuration
-Many problems on the code side, I will sort out them later
BTW: I think the ENV variable(such as dev, beta, prod), this option is
useless for users,because they just care what configuration is.
jinwei <gx...@163.com> 于2020年10月29日周四 下午12:12写道：
> +1
>
>
>
>
>
> On 10/29/2020 12:11, Ming Wen wrote:
> yes, these are basic functions, you can create issues on github to track.
>
> Thanks,
> Ming Wen, Apache APISIX & Apache SkyWalking
> Twitter: _WenMing
>
>
> JunXu Chen <ch...@apache.org> 于2020年10月29日周四 上午11:39写道：
>
> > Hi, Community,
> >
> > After the manager api refactoring, there are still many problems, as
> > follow:
> >
> > 1. Access log:
> > Save to a local file, and can customize the path
> > Support log rotate
> > Support custom log format
> >
> > 2. Error log:
> > Currently only panic logs are retained, errors are just responded by
> apis.
> > We need to retain error logs.
> > Support custom error log level
> > Support saving to a local file, and can customize the file path
> > Support log rotate
> >
> > 3. Support custom listening IP and port
> >
> > 4. Support https, and custom cert and key path
> >
> > 5. Support IP restriction
> >
> > 6. ETCD configuration:
> > Currently supports environment variable config, need to change to config
> in
> > the config file
> > Support https connection
> > Support mTLS connection
> > Support identity authentication
> >
> > 7. Improve the ENV definition and deal with `dev`, `test` and `release`
> > accordingly
> >
> > 8. Support custom cup quantity
> >
> > What do you think?
> >
> > Thanks !
> >
>
Re: [DISCUSS] issues to be solved after the `manager api`
refactoring
Posted by jinwei <gx...@163.com>.
+1
On 10/29/2020 12:11, Ming Wen wrote:
yes, these are basic functions, you can create issues on github to track.
Thanks,
Ming Wen, Apache APISIX & Apache SkyWalking
Twitter: _WenMing
JunXu Chen <ch...@apache.org> 于2020年10月29日周四 上午11:39写道：
> Hi, Community,
>
> After the manager api refactoring, there are still many problems, as
> follow:
>
> 1. Access log:
> Save to a local file, and can customize the path
> Support log rotate
> Support custom log format
>
> 2. Error log:
> Currently only panic logs are retained, errors are just responded by apis.
> We need to retain error logs.
> Support custom error log level
> Support saving to a local file, and can customize the file path
> Support log rotate
>
> 3. Support custom listening IP and port
>
> 4. Support https, and custom cert and key path
>
> 5. Support IP restriction
>
> 6. ETCD configuration:
> Currently supports environment variable config, need to change to config in
> the config file
> Support https connection
> Support mTLS connection
> Support identity authentication
>
> 7. Improve the ENV definition and deal with `dev`, `test` and `release`
> accordingly
>
> 8. Support custom cup quantity
>
> What do you think?
>
> Thanks !
>
Re: [DISCUSS] issues to be solved after the `manager api` refactoring
Posted by Ming Wen <we...@apache.org>.
yes, these are basic functions, you can create issues on github to track.
Thanks,
Ming Wen, Apache APISIX & Apache SkyWalking
Twitter: _WenMing
JunXu Chen <ch...@apache.org> 于2020年10月29日周四 上午11:39写道：
> Hi, Community,
>
> After the manager api refactoring, there are still many problems, as
> follow:
>
> 1. Access log:
> Save to a local file, and can customize the path
> Support log rotate
> Support custom log format
>
> 2. Error log:
> Currently only panic logs are retained, errors are just responded by apis.
> We need to retain error logs.
> Support custom error log level
> Support saving to a local file, and can customize the file path
> Support log rotate
>
> 3. Support custom listening IP and port
>
> 4. Support https, and custom cert and key path
>
> 5. Support IP restriction
>
> 6. ETCD configuration:
> Currently supports environment variable config, need to change to config in
> the config file
> Support https connection
> Support mTLS connection
> Support identity authentication
>
> 7. Improve the ENV definition and deal with `dev`, `test` and `release`
> accordingly
>
> 8. Support custom cup quantity
>
> What do you think?
>
> Thanks !
>
Re: [DISCUSS] issues to be solved after the `manager api` refactoring
Posted by YuanSheng Wang <me...@apache.org>.
we really need this.
and we should check if it works fine in E2E test cases, github issue: [1].
[1] https://github.com/apache/apisix-dashboard/issues/607
On Thu, Oct 29, 2020 at 11:39 AM JunXu Chen <ch...@apache.org> wrote:
> Hi, Community,
>
> After the manager api refactoring, there are still many problems, as
> follow:
>
> 1. Access log:
> Save to a local file, and can customize the path
> Support log rotate
> Support custom log format
>
> 2. Error log:
> Currently only panic logs are retained, errors are just responded by apis.
> We need to retain error logs.
> Support custom error log level
> Support saving to a local file, and can customize the file path
> Support log rotate
>
> 3. Support custom listening IP and port
>
> 4. Support https, and custom cert and key path
>
> 5. Support IP restriction
>
> 6. ETCD configuration:
> Currently supports environment variable config, need to change to config in
> the config file
> Support https connection
> Support mTLS connection
> Support identity authentication
>
> 7. Improve the ENV definition and deal with `dev`, `test` and `release`
> accordingly
>
> 8. Support custom cup quantity
>
> What do you think?
>
> Thanks !
>
--
*MembPhis*
My GitHub: https://github.com/membphis
Apache APISIX: https://github.com/apache/apisix