[GitHub] [nifi] turcsanyip commented on a change in pull request #4893: NIFI-8312: Support PKCS12 and BCFKS truststores in Atlas reporting task

[GitBox <gi...@apache.org>]

turcsanyip commented on a change in pull request #4893:
URL: https://github.com/apache/nifi/pull/4893#discussion_r594939362



##########
File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/reporting/ReportLineageToAtlas.java
##########
@@ -704,33 +699,47 @@ private void setAtlasSSLConfig(Properties atlasProperties, ConfigurationContext
         boolean isAtlasApiSecure = urls.stream().anyMatch(url -> url.toLowerCase().startsWith("https"));
         atlasProperties.put(ATLAS_PROPERTY_ENABLE_TLS, String.valueOf(isAtlasApiSecure));
 
-        // ssl-client.xml must be deleted, Atlas will not regenerate it otherwise
-        Path credStorePath = new File(confDir, CRED_STORE_FILENAME).toPath();
-        Files.deleteIfExists(credStorePath);

Review comment:
       Leaving the cred store file behind should not be a problem because we do not pass `cert.stores.credential.provider.path` property (pointing to the file) to Atlas any more so it will not use it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org