You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/09/04 14:49:33 UTC

[GitHub] [incubator-pekko-connectors] pjfanning opened a new pull request, #245: use test token in tests

pjfanning opened a new pull request, #245:
URL: https://github.com/apache/incubator-pekko-connectors/pull/245

   * the real looking token in existing code is not needed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] pjfanning merged pull request #245: use test token in tests

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #245:
URL: https://github.com/apache/incubator-pekko-connectors/pull/245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] He-Pin commented on a diff in pull request #245: use test token in tests

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #245:
URL: https://github.com/apache/incubator-pekko-connectors/pull/245#discussion_r1315069864


##########
google-cloud-pub-sub/src/test/resources/application.conf:
##########
@@ -29,7 +29,7 @@ pekko.connectors.google {
     provider = none
     none {
       project-id = "pekko-connectors"
-      token = "ya29.Elz4A2XkfGKJ4CoS5x_umUBHsvjGdeWQzu6gRRCnNXI0fuIyoDP_6aYktBQEOI4YAhLNgUl2OpxWQaN8Z3hd5YfFw1y4EGAtr2o28vSID-c8ul_xxHuudE7RmhH9sg"
+      token = "TESTTOKEN"

Review Comment:
   `TEST_TOKEN` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] pjfanning commented on a diff in pull request #245: use test token in tests

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #245:
URL: https://github.com/apache/incubator-pekko-connectors/pull/245#discussion_r1315072595


##########
google-cloud-pub-sub/src/test/resources/application.conf:
##########
@@ -29,7 +29,7 @@ pekko.connectors.google {
     provider = none
     none {
       project-id = "pekko-connectors"
-      token = "ya29.Elz4A2XkfGKJ4CoS5x_umUBHsvjGdeWQzu6gRRCnNXI0fuIyoDP_6aYktBQEOI4YAhLNgUl2OpxWQaN8Z3hd5YfFw1y4EGAtr2o28vSID-c8ul_xxHuudE7RmhH9sg"
+      token = "TESTTOKEN"

Review Comment:
   @mdedetrich suggested this `TESTTOKEN` value because we already have `TESTSECRET` and some similar values.
   
   This is just test code but the aim is to head off any risk that bounty hunters will find a real looking token and start reporting it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #245: use test token in tests

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #245:
URL: https://github.com/apache/incubator-pekko-connectors/pull/245#issuecomment-1705450703

   @pjfanning Need to rebase since my PR got merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #245: use test token in tests

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #245:
URL: https://github.com/apache/incubator-pekko-connectors/pull/245#issuecomment-1705452904

   > @pjfanning Need to rebase since my PR got merged
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org