You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2026/08/31 14:51:57 UTC

[GH] (rocketmq/fix/topic-route-wrapper-npe): Workflow run "Misspell Check" failed!

The GitHub Actions job "Misspell Check" on rocketmq.git/fix/topic-route-wrapper-npe has failed.
Run started by GitHub user yyqdbngt (triggered by yyqdbngt).

Head commit for run:
6a684857dd8407a0347e5c1faf1d8a5895b2ade2 / yyqdbngt <30...@users.noreply.github.com>
fix: guard NPE in TopicRouteWrapper when brokerName is absent from the route

getMasterAddr and getMasterAddrPrefer called
brokerNameRouteData.get(brokerName).getBrokerAddrs() without a null check,
so a brokerName not present in the current route snapshot (e.g. during
broker failover or a stale MessageQueue) threw NullPointerException.

This contradicts the contract the callers rely on: MessageQueueSelector
(buildRead/buildWrite) and ClusterTopicRouteService all check the return
value for null and skip the broker. Return null when the broker is missing
so the existing caller handling works as intended.

Compiled and verified on the build server (mvn -pl proxy -am compile).

Report URL: https://github.com/apache/rocketmq/actions/runs/30704554547

With regards,
GitHub Actions via GitBox