[jira] [Commented] (MWRAPPER-103) Failed to validate Maven Wrapper SHA-256 on Windows

["Guillaume Smet (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MWRAPPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815559#comment-17815559 ] 

Guillaume Smet commented on MWRAPPER-103:
-----------------------------------------

We got hit by this problem in the Quarkus project as the OpenRewrite recipe updating the Maven wrapper is pushing the maven-wrapper.jar checksum to the property file which causes problem on Windows.

Not sure exactly how this could be fixed but one workable option for now could be to turn the error into a warning if the checksum cannot be checked on Windows because Get-File-Hash is not available.

> Failed to validate Maven Wrapper SHA-256 on Windows
> ---------------------------------------------------
>
>                 Key: MWRAPPER-103
>                 URL: https://issues.apache.org/jira/browse/MWRAPPER-103
>             Project: Maven Wrapper
>          Issue Type: Bug
>          Components: Maven Wrapper Scripts
>    Affects Versions: 3.2.0
>            Reporter: Jorge Solórzano
>            Priority: Major
>
> When *wrapperSha256Sum* is set on GitHub Actions for the Windows platform, the script fails as is unable to validate the wrapper jar.
> I don't currently have access to a Windows machine, but this is failing for the following GH Actions configuration:
>  
> {noformat}
> Operating System: Microsoft Windows Server 2022 10.0.20348
> Datacenter
> Image: windows-202
> Version: 20230307.2
> Included Software: https://github.com/actions/runner-images/blob/win22/20230307.2/images/win/Windows2022-Readme.md
> Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F20230307.2  {noformat}
> {noformat}
>   ./mvnw $COMMON_MAVEN_ARGS $JVM_TEST_MAVEN_ARGS install -pl 'integration-tests/devtools'
>       shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
>       env:
>         LANG: en_US.UTF-8
>         COMMON_MAVEN_ARGS: -e -B --settings .github/mvn-settings.xml --fail-at-end
>         NATIVE_TEST_MAVEN_ARGS: -Dtest-containers -Dstart-containers -Dquarkus.native.native-image-xmx=5g -Dnative -Dnative.surefire.skip -Dformat.skip -Dno-descriptor-tests install -DskipDocs
>         JVM_TEST_MAVEN_ARGS: -Dtest-containers -Dstart-containers -Dformat.skip -DskipDocs -Dquarkus.test.hang-detection-timeout=60
>         JAVA_HOME: C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\11.0.18-10\x64
>         JAVA_HOME_11_X64: C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\11.0.18-10\x64
>     Get-FileHash : The term 'Get-FileHash' is not recognized as the name of a cmdlet, function, script file, or operable 
>     program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
>     At line:1 char:13
>     + &{ $hash = (Get-FileHash "D:\a\quarkus\quarkus\.mvn\wrapper\maven-wra ...
>     +             ~~~~~~~~~~~~    
>         + CategoryInfo          : ObjectNotFound: (Get-FileHash:String) [], CommandNotFoundException
>         + FullyQualifiedErrorId : CommandNotFoundException
>     Error: Failed to validate Maven wrapper SHA-256, your Maven wrapper might be compromised.
>     Investigate or delete D:\a\quarkus\quarkus\.mvn\wrapper\maven-wrapper.jar to attempt a clean download.
>     If you updated your Maven version, you need to update the specified wrapperSha256Sum property.{noformat}
> Also, using when using Git Bash:
>  
> {noformat}
>  ./mvnw $COMMON_MAVEN_ARGS install -Dsurefire.timeout=1200 -pl !integration-tests/gradle -pl !integration-tests/maven -pl !integration-tests/devtools -pl !docs -DskipDocs -Dformat.skip -Dincremental -Dgib.disableSelectedProjectsHandling -Dgib.untracked=false -Dgib.uncommitted=false -Dgib.referenceBranch=origin/main -Dgib.disableIfReferenceBranchMatches='origin/\d+\.\d+'
> shell: C:\Program Files\Git\bin\bash.EXE --noprofile --norc -e -o pipefail {0}         env:          LANG: en_US.UTF-8          COMMON_MAVEN_ARGS: -e -B --settings .github/mvn-settings.xml --fail-at-end          NATIVE_TEST_MAVEN_ARGS: -Dtest-containers -Dstart-containers -Dquarkus.native.native-image-xmx=5g -Dnative -Dnative.surefire.skip -Dformat.skip -Dno-descriptor-tests install -DskipDocs          JVM_TEST_MAVEN_ARGS: -Dtest-containers -Dstart-containers -Dformat.skip -DskipDocs -Dquarkus.test.hang-detection-timeout=60
> MAVEN_OPTS: -Xmx2g -XX:MaxMetaspaceSize=1g -Xlog:gc*=debug:file=windows-java-17.txt
> JAVA_HOME: C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\17.0.6-10\x64    JAVA_HOME_17_X64: C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\17.0.6-10\x64
> Error: Failed to validate Maven wrapper SHA-256, your Maven wrapper might be compromised.        Investigate or delete /d/a/quarkus/quarkus/.mvn/wrapper/maven-wrapper.jar to attempt a clean download.     
> If you updated your Maven version, you need to update the specified wrapperSha256Sum property.
> {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)