You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "david-mollitor-db (via GitHub)" <gi...@apache.org> on 2026/09/14 21:22:58 UTC
[PR] [MINOR][SQL] Fix stale doc for spark.sql.parquet.pushdown.inFilterThreshold [spark]
david-mollitor-db opened a new pull request, #58794:
URL: https://github.com/apache/spark/pull/58794
### What changes were proposed in this pull request?
Update the `spark.sql.parquet.pushdown.inFilterThreshold` config documentation to match the current implementation. The doc still states that, when an IN list exceeds the threshold, the Parquet filter is pushed down as a range (a value `>= min AND <= max`). That range was removed by SPARK-39312, which replaced it with a single native Parquet `in` predicate (`FilterApi.in`) over the set of values. This is a documentation-only change.
### Why are the changes needed?
The doc is stale and misleading. `ParquetFilters` no longer pushes a `[min, max]` range for above-threshold IN lists -- it pushes `FilterApi.in(column, set)` (via `makeInPredicate`). The `.doc(...)` string predates SPARK-39312 and describes behavior that no longer exists, which misrepresents the pruning precision of large IN filters.
### Does this PR introduce _any_ user-facing change?
No. Documentation-only update to a config description; no behavior change.
### How was this patch tested?
No tests. Documentation-only change to a `.doc(...)` string; confirmed the current `ParquetFilters` uses `FilterApi.in` for above-threshold IN lists (introduced by SPARK-39312) rather than a min/max range.
### Was this patch authored or co-authored using generative AI tooling?
This pull request and its description were written by Isaac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Fix stale doc for spark.sql.parquet.pushdown.inFilterThreshold [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #58794:
URL: https://github.com/apache/spark/pull/58794#issuecomment-5789492427
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/c6da9be29ca33ec336a96b110d41513e52db394e
- merged into branch-4.x https://github.com/apache/spark/commit/61b9ca8cd577376cb22550643c396e8b320dd73a
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Fix stale doc for spark.sql.parquet.pushdown.inFilterThreshold [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #58794: [MINOR][SQL] Fix stale doc for spark.sql.parquet.pushdown.inFilterThreshold
URL: https://github.com/apache/spark/pull/58794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org