You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/12/07 17:56:11 UTC
[jira] [Commented] (TINKERPOP-859) Provide a more general way to
set log levels in plugins
[ https://issues.apache.org/jira/browse/TINKERPOP-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045228#comment-15045228 ]
ASF GitHub Bot commented on TINKERPOP-859:
------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/171
TINKERPOP-859 Moved logging setup to configuration in HadoopGremlinPlugin
https://issues.apache.org/jira/browse/TINKERPOP-859
Logging setup shouldn't be hardcoded anywhere especially since we use slf4j. With this approach the user has the ultimate control over what they want logged and what they don't. TinkerPop provides a sensible default in the provided logging properties files using log4j.
I tested the console manually copying the examples in the reference documentation after these changes and didn't see any difference in the output to the console.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-859
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #171
----
commit b9efcb6a99bf83e94f8db6a4612f0d92c23526cd
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-12-07T16:29:49Z
Moved logging setup to configuration.
Logging setup shouldn't be hardcoded anywhere especially since we use slf4j. With this approach the user has the ultimate control over what they want logged and what they don't. TinkerPop provides a sensible default in the provided logging properties files using log4j.
----
> Provide a more general way to set log levels in plugins
> -------------------------------------------------------
>
> Key: TINKERPOP-859
> URL: https://issues.apache.org/jira/browse/TINKERPOP-859
> Project: TinkerPop
> Issue Type: Improvement
> Components: plugin
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.1-incubating
>
>
> Currently plugins are bound to log4j which allow the log level to be set programmatically from the plugin itself. It would be better if this could be set some other way from the plugin as we've gone through the trouble of using slf4j as an abstraction for logging.
> This might be helpful: http://stackoverflow.com/questions/10505418/how-to-find-which-library-slf4j-has-bound-itself-to
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)