You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/06/23 07:41:31 UTC
[kudu-CR] java: Move schema creation helpers out of KuduClientTest
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10807
Change subject: java: Move schema creation helpers out of KuduClientTest
......................................................................
java: Move schema creation helpers out of KuduClientTest
These helpers are useful in other tests too.
Change-Id: I461a198fb2d30a9a893aee24bbcfe2b493d3350b
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/util/ClusterTestUtil.java
2 files changed, 56 insertions(+), 56 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/10807/1
--
To view, visit http://gerrit.cloudera.org:8080/10807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I461a198fb2d30a9a893aee24bbcfe2b493d3350b
Gerrit-Change-Number: 10807
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] java: Move schema creation helpers out of KuduClientTest
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10807 )
Change subject: java: Move schema creation helpers out of KuduClientTest
......................................................................
java: Move schema creation helpers out of KuduClientTest
These helpers are useful in other tests too.
Also add missing license header file to ClientTestUtil.java
Change-Id: I461a198fb2d30a9a893aee24bbcfe2b493d3350b
Reviewed-on: http://gerrit.cloudera.org:8080/10807
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/util/ClientTestUtil.java
2 files changed, 73 insertions(+), 56 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I461a198fb2d30a9a893aee24bbcfe2b493d3350b
Gerrit-Change-Number: 10807
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] java: Move schema creation helpers out of KuduClientTest
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10807
to look at the new patch set (#3).
Change subject: java: Move schema creation helpers out of KuduClientTest
......................................................................
java: Move schema creation helpers out of KuduClientTest
These helpers are useful in other tests too.
Also add missing license header file to ClientTestUtil.java
Change-Id: I461a198fb2d30a9a893aee24bbcfe2b493d3350b
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/util/ClientTestUtil.java
2 files changed, 73 insertions(+), 56 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/10807/3
--
To view, visit http://gerrit.cloudera.org:8080/10807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I461a198fb2d30a9a893aee24bbcfe2b493d3350b
Gerrit-Change-Number: 10807
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] java: Move schema creation helpers out of KuduClientTest
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10807
to look at the new patch set (#2).
Change subject: java: Move schema creation helpers out of KuduClientTest
......................................................................
java: Move schema creation helpers out of KuduClientTest
These helpers are useful in other tests too.
Change-Id: I461a198fb2d30a9a893aee24bbcfe2b493d3350b
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/util/ClientTestUtil.java
2 files changed, 56 insertions(+), 56 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/10807/2
--
To view, visit http://gerrit.cloudera.org:8080/10807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I461a198fb2d30a9a893aee24bbcfe2b493d3350b
Gerrit-Change-Number: 10807
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] java: Move schema creation helpers out of KuduClientTest
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10807 )
Change subject: java: Move schema creation helpers out of KuduClientTest
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10807
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I461a198fb2d30a9a893aee24bbcfe2b493d3350b
Gerrit-Change-Number: 10807
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 02 Jul 2018 23:36:59 +0000
Gerrit-HasComments: No