You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/07/29 16:04:26 UTC
[GitHub] [maven] michael-o opened a new pull request #518: [MNG-7199] MAVENHOME_CONFIG var in mvnlauncher script improperly hand…
michael-o opened a new pull request #518:
URL: https://github.com/apache/maven/pull/518
…les two options at once
This closes #518
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #518: [MNG-7199] MAVENHOME_CONFIG var in mvnlauncher script improperly hand…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #518:
URL: https://github.com/apache/maven/pull/518#discussion_r680502918
##########
File path: apache-maven/src/assembly/shared/run
##########
@@ -14,6 +14,7 @@ exec "$JAVACMD" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
-classpath "${LAUNCHER_JAR}" \
- $MAVENHOME_CONFIG \
+ "-Dclassworlds.conf=$CLASSWOLRDS_CONF" \
Review comment:
I have a local patch which handles the path conversion and will provide after this one has been merged. It works both on Cygwin and MinGW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #518: [MNG-7199] MAVENHOME_CONFIG var in mvnlauncher script improperly hand…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #518:
URL: https://github.com/apache/maven/pull/518#discussion_r680501659
##########
File path: apache-maven/src/assembly/shared/run
##########
@@ -14,6 +14,7 @@ exec "$JAVACMD" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
-classpath "${LAUNCHER_JAR}" \
- $MAVENHOME_CONFIG \
+ "-Dclassworlds.conf=$CLASSWOLRDS_CONF" \
Review comment:
Thanks, will fix that.
We cannot add the system property name to the variable value because a subsequent ticket will handle the Cygwin path conversion between Unix and Windows. This is not covered for the moment. If you look at `sh -x mvn ...` you'll see that still the Unix path is passed and we rely on implicit Cygwin behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #518: [MNG-7199] MAVENHOME_CONFIG var in mvnlauncher script improperly hand…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #518:
URL: https://github.com/apache/maven/pull/518#discussion_r680502956
##########
File path: apache-maven/src/assembly/shared/run
##########
@@ -14,6 +14,7 @@ exec "$JAVACMD" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
-classpath "${LAUNCHER_JAR}" \
- $MAVENHOME_CONFIG \
+ "-Dclassworlds.conf=$CLASSWOLRDS_CONF" \
Review comment:
Here are the details: https://www.msys2.org/docs/filesystem-paths/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit closed pull request #518: [MNG-7199] MAVENHOME_CONFIG var in mvnlauncher script improperly hand…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #518:
URL: https://github.com/apache/maven/pull/518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #518: [MNG-7199] MAVENHOME_CONFIG var in mvnlauncher script improperly hand…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #518:
URL: https://github.com/apache/maven/pull/518#discussion_r680501013
##########
File path: apache-maven/src/assembly/shared/run
##########
@@ -14,6 +14,7 @@ exec "$JAVACMD" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
-classpath "${LAUNCHER_JAR}" \
- $MAVENHOME_CONFIG \
+ "-Dclassworlds.conf=$CLASSWOLRDS_CONF" \
Review comment:
typo in `CLASSWOLRDS`, but why use/introduce a variable if we can say `-Dclassworlds.conf=${MAVEN_HOME}/bin/m2.conf` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #518: [MNG-7199] MAVENHOME_CONFIG var in mvnlauncher script improperly hand…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #518:
URL: https://github.com/apache/maven/pull/518#discussion_r680502519
##########
File path: apache-maven/src/assembly/shared/run
##########
@@ -14,6 +14,7 @@ exec "$JAVACMD" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
-classpath "${LAUNCHER_JAR}" \
- $MAVENHOME_CONFIG \
+ "-Dclassworlds.conf=$CLASSWOLRDS_CONF" \
Review comment:
Ok, I see. If the usage of `$CLASSWOLRDS_CONF` fixes that I'm okay with it.
We might need tests for it, otherwise we'll have a future committer that tries to clean up these scripts too, not aware of the reason ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org