You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2019/02/19 05:47:00 UTC

[jira] [Comment Edited] (HBASE-21917) Make the HFileBlock#validateChecksum can accept ByteBuff as an input.

    [ https://issues.apache.org/jira/browse/HBASE-21917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771577#comment-16771577 ] 

stack edited comment on HBASE-21917 at 2/19/19 5:46 AM:
--------------------------------------------------------

Can we bring it local?

(IIRC when I looked long time ago, it isn't really possible. If we could bring it local we could use it in meantime while worked on changing access downstream -- thanks [~openinx])


was (Author: stack):
Can we bring it local?

> Make the HFileBlock#validateChecksum can accept ByteBuff as an input.
> ---------------------------------------------------------------------
>
>                 Key: HBASE-21917
>                 URL: https://issues.apache.org/jira/browse/HBASE-21917
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>            Priority: Major
>         Attachments: HBASE-21917.v1.patch, HBASE-21917.v2.patch, HBASE-21917.v3.patch, HBASE-21917.v4.patch
>
>
> I've tried to make a patch for HBASE-21879, most of work seems to be fine, but the trouble is: 
> HFileBlock#validateChecksum can only accept ByteBuffer as its input, while after the HBASE-21916, we will use an ourself-defined ByteBuff (which can be SingleByteBuff or MultiByteBuff). 
> Now, need to create our own ByteBuff checksum validation method, should not be so hard but an separate issue will be more clearer.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)