[GitHub] spark pull request #16497: [SPARK-19118] [SQL] Percentile support for freque...

[hvanhovell <gi...@git.apache.org>]

Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16497#discussion_r99493733
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala ---
    @@ -125,10 +139,17 @@ case class Percentile(
           buffer: OpenHashMap[Number, Long],
           input: InternalRow): OpenHashMap[Number, Long] = {
         val key = child.eval(input).asInstanceOf[Number]
    +    val frqValue = frequencyExpression.eval(input)
     
         // Null values are ignored in counts map.
    -    if (key != null) {
    -      buffer.changeValue(key, 1L, _ + 1L)
    +    if (key != null && frqValue != null) {
    +      val frqLong = frqValue.asInstanceOf[Number].longValue()
    +      // add only when frequency is positive
    +      if (frqLong > 0) {
    +        buffer.changeValue(key, frqLong, _ + frqLong)
    +      } else if ( frqLong < 0 ) {
    --- End diff --
    
    NIT: no leading and trailing spaces in the `if` clause


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org