You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/11 06:54:13 UTC
[GitHub] [incubator-kyuubi] cfmcgrady opened a new pull request #1895: Make `Query Details` and `Failure Reason` sortable on the Kyuubi Quer…
cfmcgrady opened a new pull request #1895:
URL: https://github.com/apache/incubator-kyuubi/pull/1895
…y Engine page.
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Before this PR, when we sorted the `SQL statistics` using the `Query Details` column, an exception would be thrown.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1895: [KYUUBI #1896] Make `Query Details` and `Failure Reason` sortable on the Kyuubi Query Engine page
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1895:
URL: https://github.com/apache/incubator-kyuubi/pull/1895#issuecomment-1035952367
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1895?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1895](https://codecov.io/gh/apache/incubator-kyuubi/pull/1895?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a7fae2) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/0d1502e3d7c717d4354f00c63e860af6b0a9c9af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0d1502e) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1895?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1895 +/- ##
============================================
- Coverage 59.79% 59.75% -0.04%
+ Complexity 323 321 -2
============================================
Files 291 291
Lines 14232 14234 +2
Branches 1804 1806 +2
============================================
- Hits 8510 8506 -4
- Misses 4998 5003 +5
- Partials 724 725 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1895?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/main/scala/org/apache/spark/ui/EnginePage.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1895/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3BhcmsvdWkvRW5naW5lUGFnZS5zY2FsYQ==) | `78.97% <0.00%> (-0.48%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1895/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1895?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1895?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0d1502e...1a7fae2](https://codecov.io/gh/apache/incubator-kyuubi/pull/1895?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on pull request #1895: [KYUUBI #1896] Make `Query Details` and `Failure Reason` sortable on the Kyuubi Query Engine page
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on pull request #1895:
URL: https://github.com/apache/incubator-kyuubi/pull/1895#issuecomment-1035995497
> https://github.com/apache/incubator-kyuubi/runs/5153133042?check_suite_focus=true master test failure related？
Judging from its logs, I don't think it's related.
```
1 session(s) are online,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] SteNicholas edited a comment on pull request #1895: Make `Query Details` and `Failure Reason` sortable on the Kyuubi Quer…
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #1895:
URL: https://github.com/apache/incubator-kyuubi/pull/1895#issuecomment-1035930267
@cfmcgrady, thanks for your contribution. IMO, you should firstly create a new issue when we sorted the `SQL statistics` using the `Query Details` column.
cc @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on pull request #1895: Make `Query Details` and `Failure Reason` sortable on the Kyuubi Quer…
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on pull request #1895:
URL: https://github.com/apache/incubator-kyuubi/pull/1895#issuecomment-1035932171
> is it also a bug in 1.4?
No, We introduced this bug with [PR-1776](https://github.com/apache/incubator-kyuubi/pull/1776), as we don't backport PR-1776 to branch-1.4, it's not a bug in 1.4. @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1895: [KYUUBI #1896] Make `Query Details` and `Failure Reason` sortable on the Kyuubi Query Engine page
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1895:
URL: https://github.com/apache/incubator-kyuubi/pull/1895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1895: Make `Query Details` and `Failure Reason` sortable on the Kyuubi Quer…
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1895:
URL: https://github.com/apache/incubator-kyuubi/pull/1895#issuecomment-1035927429
is it also a bug in 1.4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on pull request #1895: [KYUUBI #1896] Make `Query Details` and `Failure Reason` sortable on the Kyuubi Query Engine page
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on pull request #1895:
URL: https://github.com/apache/incubator-kyuubi/pull/1895#issuecomment-1035946558
> @cfmcgrady, thanks for your contribution. IMO, you should firstly create a new issue when we sorted the `SQL statistics` using the `Query Details` column. cc @yaooqinn
Thanks for the reminder, added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady edited a comment on pull request #1895: Make `Query Details` and `Failure Reason` sortable on the Kyuubi Quer…
Posted by GitBox <gi...@apache.org>.
cfmcgrady edited a comment on pull request #1895:
URL: https://github.com/apache/incubator-kyuubi/pull/1895#issuecomment-1035932171
> is it also a bug in 1.4?
No, we introduced this bug with [PR-1776](https://github.com/apache/incubator-kyuubi/pull/1776), as we don't backport PR-1776 to branch-1.4, it's not a bug in 1.4. @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1895: [KYUUBI #1896] Make `Query Details` and `Failure Reason` sortable on the Kyuubi Query Engine page
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1895:
URL: https://github.com/apache/incubator-kyuubi/pull/1895#issuecomment-1035961027
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1895: [KYUUBI #1896] Make `Query Details` and `Failure Reason` sortable on the Kyuubi Query Engine page
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1895:
URL: https://github.com/apache/incubator-kyuubi/pull/1895#issuecomment-1035974086
https://github.com/apache/incubator-kyuubi/runs/5153133042?check_suite_focus=true master test failure related？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] SteNicholas commented on pull request #1895: Make `Query Details` and `Failure Reason` sortable on the Kyuubi Quer…
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #1895:
URL: https://github.com/apache/incubator-kyuubi/pull/1895#issuecomment-1035930267
@cfmcgrady, thanks for your contribution. IMO, you should firstly create a new issue when we sorted the `SQL statistics` using the `Query Details` column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org