You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/02/02 21:54:32 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #143: Add SourceDistPlugin for creating source packages
mdedetrich opened a new pull request, #143:
URL: https://github.com/apache/incubator-pekko/pull/143
Adds the prototype source dist plugin which generates source packages for Apache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on pull request #143: Add SourceDistPlugin for creating source packages
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#issuecomment-1425456760
Just as quick info that in my checkout, the plugin somehow got into a loop and created a 50GB distribution file when I noticed and stopped it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #143: Add SourceDistPlugin for creating source packages
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#issuecomment-1424215542
> The most important thing here is that you start from a pristine checkout because files are included based on a blacklist and not on a whitelist so any extra file you might have in your workspace will be included.
We can add this as a check to sbt-source-dist so it won't work if the checkout is not pristine
> I would have also preferred to simply use git archive but since the work is already done, it seems good enough.
Its always possible to make sbt-source-dist just wrap `git archive` however arguably this is also an advantage of sbt-source-dist because its not reliant on git. Not relevant for pekko specifically but as a general Apache SBT plugin (which it may be in the future) this has theoretical relevance because not everyone uses git (then again, a good counter argument to this is to just detect if the machine has git and then proceed to use git archive).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #143: Add SourceDistPlugin for creating source packages
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#issuecomment-1415968704
> v0.1.2 of the sbt plugin is available now
Will update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #143: Add SourceDistPlugin for creating source packages
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#discussion_r1099199280
##########
project/plugins.sbt:
##########
@@ -26,4 +26,5 @@ addSbtPlugin("net.bzzt" % "sbt-reproducible-builds" % "0.30")
addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.5.10")
addSbtPlugin("com.lightbend.sbt" % "sbt-publish-rsync" % "0.2")
+addSbtPlugin("com.github.pjfanning" % "sbt-source-dist" % "0.1.2")
Review Comment:
0.1.3 is ready - it generates the sha256/sha512 digest files as well as the zip/tgz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] spangaer commented on pull request #143: Add SourceDistPlugin for creating source packages
Posted by "spangaer (via GitHub)" <gi...@apache.org>.
spangaer commented on PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#issuecomment-1421418180
Well, I'd think you'll always need a plugin to do more. I just saw things like "self handling" of .gitignore files, to which I think -> just let Git handle that. Where wrapping that command would help you.
But I fully understand I'm waaaay late with that suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #143: Add SourceDistPlugin for creating source packages
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#issuecomment-1424258845
I agree that `git archive` would be a workable solution.
A few benefits of an sbt plugin
* the artifact names are set up in the sbt scripts so that users just call `sbt sourceDistGenerate` regardless of the repo - so they don't need to customise the commands for different repos. One call gets you the zip and tgz
* the `sourceDistGenerate` creates the SHA digests automatically
* we'll probably also get it use sbt-pgp to gen the gpg signing asc files
* checking for a clean unmodified repo is definitely needed
If the plugin proves problematic, we can look again at `git archive`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #143: Add SourceDistPlugin for creating source packages
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#issuecomment-1424262697
> If the plugin proves problematic, we can look again at git archive.
Just a note on this (incase its not clear), there isn't any issue in sbt plugins just wrap existing cli's (such as `git` with `git archive`). In fact a lot of sbt plugins, even official ones do this (a good example is sbt-pgp).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] spangaer commented on pull request #143: Add SourceDistPlugin for creating source packages
Posted by "spangaer (via GitHub)" <gi...@apache.org>.
spangaer commented on PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#issuecomment-1421398928
Sorry for the late comment, but wondering whether something like this was considered:
Query Git for an archive of the branch state: https://git-scm.com/docs/git-archive
I guess the archive can receive some post processing to added certain "generated files", like the "dist stuff" or
https://github.com/apache/incubator-pekko/issues/130#issuecomment-1421339657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #143: Add SourceDistPlugin for creating source packages
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#issuecomment-1425464576
> Just as quick info that in my checkout, the plugin somehow got into a loop and created a 50GB distribution file when I noticed and stopped it...
Hmm, I am honestly thinking that in the medium term, let alone long term it would be easier to divert to git archive. @jrudolph Do you want to investigate https://github.com/pjfanning/sbt-source-dist/issues/14 ?
@pjfanning Can you add @jrudolph as a maintainer of the repo as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #143: Add SourceDistPlugin for creating source packages
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#discussion_r1095123191
##########
build.sbt:
##########
@@ -100,9 +100,12 @@ lazy val root = Project(id = "pekko", base = file("."))
akkaScalaNightly,
docs,
serialversionRemoverPlugin))
- .settings(Compile / headerCreate / unmanagedSources := (baseDirectory.value / "project").**("*.scala").get)
+ .settings(
+ Compile / headerCreate / unmanagedSources := (baseDirectory.value / "project").**("*.scala").get,
+ sourceDistName := "pekko")
Review Comment:
incubator-pekko is more correct for the source distribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #143: Add SourceDistPlugin for creating source packages
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#issuecomment-1421412536
@spangaer since we've already written the sbt plugin, I don't see the real attraction to using this command line tool. If we hadn't written the plugin, the tool might have been an alternative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #143: Add SourceDistPlugin for creating source packages
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#issuecomment-1414970983
@pjfanning Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #143: Add SourceDistPlugin for creating source packages
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#issuecomment-1415922342
v0.1.2 of the sbt plugin is available now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #143: Add SourceDistPlugin for creating source packages
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#discussion_r1095127009
##########
build.sbt:
##########
@@ -100,9 +100,12 @@ lazy val root = Project(id = "pekko", base = file("."))
akkaScalaNightly,
docs,
serialversionRemoverPlugin))
- .settings(Compile / headerCreate / unmanagedSources := (baseDirectory.value / "project").**("*.scala").get)
+ .settings(
+ Compile / headerCreate / unmanagedSources := (baseDirectory.value / "project").**("*.scala").get,
+ sourceDistName := "pekko")
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich merged pull request #143: Add SourceDistPlugin for creating source packages
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #143: Add SourceDistPlugin for creating source packages
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #143:
URL: https://github.com/apache/incubator-pekko/pull/143#issuecomment-1425467726
We can also have a look into what https://github.com/Apache/daffodil does, its another Apache project that uses sbt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org