You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/03 23:42:42 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #10144: Enforce keyword-only arguments for google provider operators
ephraimbuddy opened a new pull request #10144:
URL: https://github.com/apache/airflow/pull/10144
This PR closes part of #9942, It enforces keyword-only arguments for google provider operators
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10144: Add correct signatures for operators in google provider package
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10144:
URL: https://github.com/apache/airflow/pull/10144#issuecomment-668298667
> Hi, @mik-laj, I noticed that operators in natural_language module and a few others didn't use apply_default decorator. I added it but I'm wondering if there's a reason why it was not used
There is no reason it was missing - most likely a mistake
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #10144: Add correct signatures for operators in google provider package
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #10144:
URL: https://github.com/apache/airflow/pull/10144#issuecomment-668296694
Hi, @mik-laj, I noticed that operators in natural_language module and a few others didn't use apply_default decorator. I added it but I'm wondering if there's a reason why it was not used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10144: Add correct signatures for operators in google provider package
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10144:
URL: https://github.com/apache/airflow/pull/10144
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #10144: Add correct signatures for operators in google provider package
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #10144:
URL: https://github.com/apache/airflow/pull/10144#issuecomment-668299092
> > Hi, @mik-laj, I noticed that operators in natural_language module and a few others didn't use apply_default decorator. I added it but I'm wondering if there's a reason why it was not used
>
> There is no reason it was missing - most likely a mistake
Ok. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org