You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "junichi11 (via GitHub)" <gi...@apache.org> on 2023/03/24 06:26:10 UTC

[GitHub] [netbeans] junichi11 opened a new pull request, #5706: Fix incorrect GotoDeclaration in Enum implementing interface

junichi11 opened a new pull request, #5706:
URL: https://github.com/apache/netbeans/pull/5706

   #### Example
   
   ```php
   <?php
   namespace Enum1;
   
   interface ExampleInterface1 {}
   interface ExampleInterface2 {}
   
   namespace Enum2;
   
   use Enum1\ExampleInterface1;
   use Enum1\ExampleInterface2;
   
   enum EnumImpl1 implements ExampleInterface1 {
       case A = 'A';
       case B = 'B';
   }
   
   enum EnumImpl2 implements ExampleInterface1, ExampleInterface2 {
       case A = 'A';
       case B = 'B';
   }
   ````
   
   #### Before:
   ![nb-php-incorrect-goto-in-enum-before](https://user-images.githubusercontent.com/738383/227442047-647a3b1d-e323-4ca3-a2dc-6854b4bc63d8.gif)
   
   #### After:
   ![nb-php-incorrect-goto-in-enum-after](https://user-images.githubusercontent.com/738383/227442070-271751a5-c887-4e34-86b6-a82208182f8b.gif)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik merged pull request #5706: Fix GotoDeclaration in Enum implementing interface

Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik merged PR #5706:
URL: https://github.com/apache/netbeans/pull/5706


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #5706: Fix GotoDeclaration in Enum implementing interface

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #5706:
URL: https://github.com/apache/netbeans/pull/5706#issuecomment-1483486742

   @tmysik Could you please have a look at this? If there is no problem, let's merge it. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #5706: Fix GotoDeclaration in Enum implementing interface

Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on PR #5706:
URL: https://github.com/apache/netbeans/pull/5706#issuecomment-1483727459

   Thanks for the tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists