You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/05 18:46:20 UTC
[GitHub] [pulsar] david-streamlio opened a new pull request #10140: [Issue-9889] [integration tests] Refactored Function integration tests
david-streamlio opened a new pull request #10140:
URL: https://github.com/apache/pulsar/pull/10140
<!--
Fixes #9889
### Motivation
Restructure the function integration tests for easier maintainability going forward
### Modifications
I have broken out the existing test cases into separate classes based upon the type of Function we are trying to test, e.g Go, Java, Python, etc. Previously all of these tests were in a single class which violates OOP principles significantly
### Verifying this change
This change is already covered by existing tests, such as *(please describe tests)*.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (No)
- The public API: (No)
- The schema: (No)
- The default values of configurations: (No)
- The wire protocol: (No)
- The rest endpoints: (No)
- The admin cli options: (No)
- Anything that affects deployment: (No)
### Documentation
- Does this pull request introduce a new feature? (No)
- If yes, how is the feature documented? (not applicable)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on pull request #10140: [Issue-9889] [integration tests] Refactored Function integration tests
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on pull request #10140:
URL: https://github.com/apache/pulsar/pull/10140#issuecomment-814532026
Add description for changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] david-streamlio commented on pull request #10140: [Issue-9889] [integration tests] Refactored Function integration tests
Posted by GitBox <gi...@apache.org>.
david-streamlio commented on pull request #10140:
URL: https://github.com/apache/pulsar/pull/10140#issuecomment-814328308
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng merged pull request #10140: [Issue-9889] [integration tests] Refactored Function integration tests
Posted by GitBox <gi...@apache.org>.
jerrypeng merged pull request #10140:
URL: https://github.com/apache/pulsar/pull/10140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] david-streamlio commented on pull request #10140: [Issue-9889] [integration tests] Refactored Function integration tests
Posted by GitBox <gi...@apache.org>.
david-streamlio commented on pull request #10140:
URL: https://github.com/apache/pulsar/pull/10140#issuecomment-833952045
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] david-streamlio commented on pull request #10140: [Issue-9889] [integration tests] Refactored Function integration tests
Posted by GitBox <gi...@apache.org>.
david-streamlio commented on pull request #10140:
URL: https://github.com/apache/pulsar/pull/10140#issuecomment-814232971
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #10140: [Issue-9889] [integration tests] Refactored Function integration tests
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #10140:
URL: https://github.com/apache/pulsar/pull/10140#issuecomment-819062263
@freeznet Can you review this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on pull request #10140: [Issue-9889] [integration tests] Refactored Function integration tests
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on pull request #10140:
URL: https://github.com/apache/pulsar/pull/10140#issuecomment-833742275
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10140: [Issue-9889] [integration tests] Refactored Function integration tests
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10140:
URL: https://github.com/apache/pulsar/pull/10140#issuecomment-816961020
@david-streamlio can you fix the conflicts please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org