You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "slievrly (via GitHub)" <gi...@apache.org> on 2026/09/26 07:23:02 UTC
[PR] test: assert server message dispatch across protocol versions [incubator-seata]
slievrly opened a new pull request, #8273:
URL: https://github.com/apache/incubator-seata/pull/8273
- [x] I have read the contributing guidelines.
- [x] I have registered the PR changes.
### Ⅰ. Describe what this PR did
Register synchronous recording processors in the normal server dispatch fixtures. Verify both child requests, IDs, codec and compressor for 2.3.0 merged messages, unchanged merged dispatch for older clients, and normal request delivery through processMessage and ServerHandler.
### Ⅱ. Does this pull request fix one issue?
Fixes #8272.
### Ⅲ. Test cases
All 30 NettyRemotingServerBehaviorTest cases pass. Changed-file Checkstyle passes. The normal dispatch cases no longer emit missing-processor errors.
### Ⅳ. Describe how to verify it
Java 17: `mvn -pl core -am test -Dtest=NettyRemotingServerBehaviorTest -Dsurefire.failIfNoSpecifiedTests=false -Dcheckstyle.skip=false -Dcheckstyle.includes=org/apache/seata/core/rpc/netty/NettyRemotingServerBehaviorTest.java`.
### Ⅴ. Special notes for reviews
Source: [Java 17 CI job](https://github.com/apache/incubator-seata/actions/runs/35840434140/job/107113931949).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: assert server message dispatch across protocol versions [incubator-seata]
Posted by "l81893521 (via GitHub)" <gi...@apache.org>.
l81893521 merged PR #8273:
URL: https://github.com/apache/incubator-seata/pull/8273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: assert server message dispatch across protocol versions [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8273:
URL: https://github.com/apache/incubator-seata/pull/8273#issuecomment-5844298779
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/8273?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 73.14%. Comparing base ([`96e84e5`](https://app.codecov.io/gh/apache/incubator-seata/commit/96e84e52f1013c484ef524afefdc81a2fb981d18?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7600c61`](https://app.codecov.io/gh/apache/incubator-seata/commit/7600c61d377be733027a76978e8e2b3b2e5c2569?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #8273 +/- ##
============================================
- Coverage 73.33% 73.14% -0.19%
Complexity 1146 1146
============================================
Files 1153 1153
Lines 42348 42348
Branches 5061 5061
============================================
- Hits 31056 30976 -80
- Misses 8811 8891 +80
Partials 2481 2481
```
[see 23 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/8273/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/8273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org