You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/05/14 18:38:15 UTC
Re: Review Request 67110: Disabled omission of frame pointers in debug
builds in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67110/
-----------------------------------------------------------
(Updated May 14, 2018, 8:38 p.m.)
Review request for mesos, Benjamin Mahler and James Peach.
Summary (updated)
-----------------
Disabled omission of frame pointers in debug builds in libprocess.
Bugs: MESOS-8908
https://issues.apache.org/jira/browse/MESOS-8908
Repository: mesos
Description
-------
This patch prevents the compiler from omitting frame pointers for
debug builds which can lead to a better debugging or profiling
experience.
Since having this flag turned on can disable certain optimizations we
do not enable it in non-debug builds. This can lead to minor
deviations in runtime behavior when combing release and debug flags
(e.g., when combining `--enable-debug` with `--enable-optimize`, or
with the cmake build type `RelWithDebInfo`), but still should give the
best possible build for pure release builds, and allow a reasonable
developer experience when debugging/profiling.
Diffs
-----
3rdparty/libprocess/configure.ac 083cf8b1c644cf826cc0d164cf5276315392aa1c
Diff: https://reviews.apache.org/r/67110/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier