You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/08 19:37:42 UTC
[GitHub] [tvm] tkonolige opened a new pull request #10532: [FIX] Remove hexagon files built when hexagon is disabled
tkonolige opened a new pull request #10532:
URL: https://github.com/apache/tvm/pull/10532
This PR just removes the hexagon files from the default build.
@areusch @kparzysz-quic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige closed pull request #10532: [FIX] Remove hexagon files built when hexagon is disabled
Posted by GitBox <gi...@apache.org>.
tkonolige closed pull request #10532:
URL: https://github.com/apache/tvm/pull/10532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on pull request #10532: [FIX] Remove hexagon files built when hexagon is disabled
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #10532:
URL: https://github.com/apache/tvm/pull/10532#issuecomment-1063410990
@csullivan 's solution seems to satisfy everyone's constraints here. It won't require setting global flags, and it will correctly disable log customization on regular targets. I'll submit a PR with it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on pull request #10532: [FIX] Remove hexagon files built when hexagon is disabled
Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on pull request #10532:
URL: https://github.com/apache/tvm/pull/10532#issuecomment-1062182704
You need to either delete or comment out everything in `tests/cpp/runtime/hexagon_buffer.cc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] adstraw commented on pull request #10532: [FIX] Remove hexagon files built when hexagon is disabled
Posted by GitBox <gi...@apache.org>.
adstraw commented on pull request #10532:
URL: https://github.com/apache/tvm/pull/10532#issuecomment-1063157137
> If @adstraw prefers to keep these checks would it be acceptable to only enable custom logging when those sources are built for Hexagon?
I prefer to keep the pre-commit checks for `HexagonBuffer` running on x86. Longer term, it would be great to move these checks to Hexagon CI. Short term, if enabling log customization as @csullivan proposed above works for all parties I am OK with this solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on pull request #10532: [FIX] Remove hexagon files built when hexagon is disabled
Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on pull request #10532:
URL: https://github.com/apache/tvm/pull/10532#issuecomment-1063121256
We should have this functionality tested in CI, but it should be done on Hexagon. We should figure out how we can run these tests, or their equivalents on simulator. The Hexagon docker has all the tools that are needed for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on pull request #10532: [FIX] Remove hexagon files built when hexagon is disabled
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #10532:
URL: https://github.com/apache/tvm/pull/10532#issuecomment-1065516419
Close in favor of #10587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] csullivan commented on pull request #10532: [FIX] Remove hexagon files built when hexagon is disabled
Posted by GitBox <gi...@apache.org>.
csullivan commented on pull request #10532:
URL: https://github.com/apache/tvm/pull/10532#issuecomment-1063110308
@adstraw's intention with adding these tests was to allow for unit testing of some of the C++ classes that would run pre-commit. Of course in production they run on Hexagon where custom logging is needed, but he has found it useful to have some of these unit tests running on x86 during commit time. If @adstraw prefers to keep these checks would it be acceptable to only enable custom logging when those sources are built for Hexagon?
```
#if defined(__hexagon__)
#define TVM_LOG_CUSTOMIZE 1
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org