You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/22 01:21:19 UTC

[GitHub] [nifi-minifi-cpp] bakaid opened a new pull request #765: MINIFICPP-942,MINIFICPP-943 - compile flags refactor

bakaid opened a new pull request #765:
URL: https://github.com/apache/nifi-minifi-cpp/pull/765


   This commit
    - ensures that that the proper compile and link flags are passed
      to all CMake ExternalProject_Add third parties
    - ensures that the proper compile flags are passed to all
      ./configure && make && make install third parties
    - use the recommended Threads::Threads target everywhere for linking
      with the platform-specific threading library, when required
    - introduces universal PIC and PIE executables instead of sporadic
      and inconsistent usage
    - adds support for building with AddressSanitizer intstrumentation
      with supported compilers
   
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #765: MINIFICPP-942,MINIFICPP-943 - compile flags refactor

Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #765:
URL: https://github.com/apache/nifi-minifi-cpp/pull/765#discussion_r412879720



##########
File path: CMakeLists.txt
##########
@@ -123,6 +125,18 @@ endif()
 set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
+# We want everything PIC
+set(CMAKE_POSITION_INDEPENDENT_CODE ON)

Review comment:
       Why do we want everything PIC?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #765: MINIFICPP-942,MINIFICPP-943 - compile flags refactor

Posted by GitBox <gi...@apache.org>.
bakaid commented on a change in pull request #765:
URL: https://github.com/apache/nifi-minifi-cpp/pull/765#discussion_r413690442



##########
File path: CMakeLists.txt
##########
@@ -123,6 +125,18 @@ endif()
 set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
+# We want everything PIC
+set(CMAKE_POSITION_INDEPENDENT_CODE ON)

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] arpadboda commented on pull request #765: MINIFICPP-942,MINIFICPP-943 - compile flags refactor

Posted by GitBox <gi...@apache.org>.
arpadboda commented on pull request #765:
URL: https://github.com/apache/nifi-minifi-cpp/pull/765#issuecomment-619178276


   LGTM, thanks!
   
   The next step here seems to be adding a job that builds with this turned on. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #765: MINIFICPP-942,MINIFICPP-943 - compile flags refactor

Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #765:
URL: https://github.com/apache/nifi-minifi-cpp/pull/765#discussion_r412879720



##########
File path: CMakeLists.txt
##########
@@ -123,6 +125,18 @@ endif()
 set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
+# We want everything PIC
+set(CMAKE_POSITION_INDEPENDENT_CODE ON)

Review comment:
       Why do we want everything PIC? I mean an explanation in the comment would be nice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org