You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/08 22:58:52 UTC
[GitHub] [flink] RyanSkraba opened a new pull request, #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
RyanSkraba opened a new pull request, #20230:
URL: https://github.com/apache/flink/pull/20230
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Update the `flink-formats/flink-parquet` module to AssertJ and JUnit 5 following the [JUnit 5 Migration Guide](https://docs.google.com/document/d/1514Wa_aNB9bJUen4xm5uiuXOooOJTtXqS_Jqk9KJitU/edit)
## Brief change log
* Removed dependences on JUnit 4, JUnit 5 Assertions and Hamcrest where possible.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
I've verified that there are 94 tests run in this module before and after the refactoring.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive):no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature?no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20230:
URL: https://github.com/apache/flink/pull/20230#issuecomment-1179419344
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "baaa6afb49ee84320d422273ce57611302e29f78",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "baaa6afb49ee84320d422273ce57611302e29f78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* baaa6afb49ee84320d422273ce57611302e29f78 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r989201719
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/protobuf/ParquetProtoStreamingFileSinkITCase.java:
##########
@@ -49,13 +50,12 @@
* Simple integration test case for writing bulk encoded files with the {@link StreamingFileSink}
* with Parquet.
*/
-public class ParquetProtoStreamingFileSinkITCase extends AbstractTestBase {
-
- @Rule public final Timeout timeoutPerTest = Timeout.seconds(20);
+@ExtendWith(MiniClusterExtension.class)
+@Timeout(20)
Review Comment:
There was a community discussion on trying to avoid timeouts (see [discussion thread](https://lists.apache.org/thread/q11t0y3qsw07lkb811037h4mvx0r7ncn) and [corresponding Flink coding guidelines](https://flink.apache.org/contributing/code-style-and-quality-common.html#avoid-timeouts-in-junit-tests)).
The decision was only made on unit tests but I don't see why the same wouldn't also apply for integration tests. WDYT?
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/vector/ParquetColumnarRowSplitReaderTest.java:
##########
@@ -137,21 +134,15 @@ public class ParquetColumnarRowSplitReaderTest {
.as(OriginalType.DECIMAL)
.named("f14"));
- @ClassRule public static final TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();
+ @TempDir java.io.File tmpDir;
Review Comment:
```suggestion
@TempDir File tmpDir;
```
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/avro/AvroParquetStreamingFileSinkITCase.java:
##########
@@ -59,15 +60,12 @@
* Simple integration test case for writing bulk encoded files with the {@link StreamingFileSink}
* with Parquet.
*/
-@SuppressWarnings("serial")
-public class AvroParquetStreamingFileSinkITCase extends AbstractTestBase {
-
- @Rule public final Timeout timeoutPerTest = Timeout.seconds(20);
+@ExtendWith(MiniClusterExtension.class)
+@Timeout(20)
Review Comment:
There was a community discussion on trying to avoid timeouts (see [discussion thread](https://lists.apache.org/thread/q11t0y3qsw07lkb811037h4mvx0r7ncn) and [corresponding Flink coding guidelines](https://flink.apache.org/contributing/code-style-and-quality-common.html#avoid-timeouts-in-junit-tests)).
The decision was only made on unit tests but I don't see why the same wouldn't also apply for integration tests. WDYT?
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/protobuf/ParquetProtoStreamingFileSinkITCase.java:
##########
@@ -49,13 +50,12 @@
* Simple integration test case for writing bulk encoded files with the {@link StreamingFileSink}
* with Parquet.
*/
-public class ParquetProtoStreamingFileSinkITCase extends AbstractTestBase {
-
- @Rule public final Timeout timeoutPerTest = Timeout.seconds(20);
+@ExtendWith(MiniClusterExtension.class)
Review Comment:
Is there a difference between using `@ExtendWith` and `@RegisterExtension` on a field member like you did it in `AvroParquetFileReadITCase`? :thinking: shall we go for a consistent approach if not?
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriterTest.java:
##########
@@ -112,26 +109,27 @@ public class ParquetRowDataWriterTest {
TypeConversions.fromLogicalToDataType(ROW_TYPE));
@Test
- public void testTypes() throws Exception {
+ void testTypes(@TempDir java.nio.file.Path folder) throws Exception {
Review Comment:
nit: Here and in the other test method: We could switch to `File` to avoid having the fully qualified reference.
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java:
##########
@@ -125,21 +122,15 @@ public class ParquetColumnarRowInputFormatTest {
.as(OriginalType.DECIMAL)
.named("f14"));
- @ClassRule public static final TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();
+ @TempDir private java.io.File folder;
Review Comment:
```suggestion
@TempDir private File folder;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1004510730
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriterTest.java:
##########
@@ -112,26 +109,27 @@ public class ParquetRowDataWriterTest {
TypeConversions.fromLogicalToDataType(ROW_TYPE));
@Test
- public void testTypes() throws Exception {
+ void testTypes(@TempDir java.nio.file.Path folder) throws Exception {
Review Comment:
If this opinion isn't strongly held, my preference is to use the newer java.nio.file.* classes where possible (except in the cases where we actually **need** the {{java.io.File}} for working with legacy APIs, of course). It looks like this is the tendency in the Flink code as well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1005578991
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java:
##########
@@ -126,7 +126,7 @@ class ParquetColumnarRowInputFormatTest {
new MapType(new IntType(), new BooleanType()),
RowType.of(new VarCharType(VarCharType.MAX_LENGTH), new IntType()));
- @TempDir private java.io.File folder;
Review Comment:
The hotfix commit does contain changes that are not related to the `@Timeout` removal
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/avro/AvroParquetFileReadITCase.java:
##########
@@ -79,14 +92,14 @@ public static void setup() throws IOException {
createParquetFile(
AvroParquetWriters.forGenericRecord(schema),
- Path.fromLocalFile(TEMPORARY_FOLDER.newFile(USER_PARQUET_FILE_1)),
+ Path.fromLocalFile(temporaryFolder.resolve(USER_PARQUET_FILE_1).toFile()),
Review Comment:
Aren't we creating a `Path` that's converted to a `File` for it to be converted to a `Path` again? :thinking: ...this also applies to the other occurrences below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on PR #20230:
URL: https://github.com/apache/flink/pull/20230#issuecomment-1180875380
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1008306660
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java:
##########
@@ -126,7 +126,7 @@ class ParquetColumnarRowInputFormatTest {
new MapType(new IntType(), new BooleanType()),
RowType.of(new VarCharType(VarCharType.MAX_LENGTH), new IntType()));
- @TempDir private java.io.File folder;
Review Comment:
Hello! I refer to the two minor changes in the commit message:
1) Clean up qualified classes, and
2) Clean up @Timeout
(Admittedly I should have used the right Case for @Timeout).
Do you think this needs to be fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1014228413
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java:
##########
@@ -126,7 +126,7 @@ class ParquetColumnarRowInputFormatTest {
new MapType(new IntType(), new BooleanType()),
RowType.of(new VarCharType(VarCharType.MAX_LENGTH), new IntType()));
- @TempDir private java.io.File folder;
Review Comment:
Yes, it should because you're introducing a code change in this PR that you fix in the very same PR. But admittedly, we can just squash the two commits into one, anyway. So, I'm gonna go ahead with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp merged pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
XComp merged PR #20230:
URL: https://github.com/apache/flink/pull/20230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1008306660
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java:
##########
@@ -126,7 +126,7 @@ class ParquetColumnarRowInputFormatTest {
new MapType(new IntType(), new BooleanType()),
RowType.of(new VarCharType(VarCharType.MAX_LENGTH), new IntType()));
- @TempDir private java.io.File folder;
Review Comment:
Hello! I refer to the two minor changes in the commit message:
1) Clean up qualified classes, and
2) Clean up `@Timeout`
(Admittedly I should have used the right Case for `@Timeout` (It appears that the lower case is a representation for a specific, unrelated user).
Do you think this needs to be fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #20230:
URL: https://github.com/apache/flink/pull/20230#issuecomment-1303838597
I'm gonna merge this PR without rerunning the e2e tests because the change suggested by this PR is independent of the e2e tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1004501592
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/protobuf/ParquetProtoStreamingFileSinkITCase.java:
##########
@@ -49,13 +50,12 @@
* Simple integration test case for writing bulk encoded files with the {@link StreamingFileSink}
* with Parquet.
*/
-public class ParquetProtoStreamingFileSinkITCase extends AbstractTestBase {
-
- @Rule public final Timeout timeoutPerTest = Timeout.seconds(20);
+@ExtendWith(MiniClusterExtension.class)
Review Comment:
There is a difference: `@RegisterExtension` allows you to tune the minicluster (in this case, `AvroParquetFileReadITCase` has some parallelism tests that will fail with the default number of slots).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1008306660
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java:
##########
@@ -126,7 +126,7 @@ class ParquetColumnarRowInputFormatTest {
new MapType(new IntType(), new BooleanType()),
RowType.of(new VarCharType(VarCharType.MAX_LENGTH), new IntType()));
- @TempDir private java.io.File folder;
Review Comment:
Hello! I refer to the two minor changes in the commit message:
1) Clean up qualified classes, and
2) Clean up `@Timeout`
(Admittedly I should have used the right Case for `@Timeout`~ It appears that the commit message is correct and github is interpreting it as a link to an unrelated user).
Do you think this needs to be fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1008315366
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/avro/AvroParquetFileReadITCase.java:
##########
@@ -79,14 +92,14 @@ public static void setup() throws IOException {
createParquetFile(
AvroParquetWriters.forGenericRecord(schema),
- Path.fromLocalFile(TEMPORARY_FOLDER.newFile(USER_PARQUET_FILE_1)),
+ Path.fromLocalFile(temporaryFolder.resolve(USER_PARQUET_FILE_1).toFile()),
Review Comment:
This isn't a round trip unfortunately -- it's `java.nio.file.Path` to `java.io.File` to `org.apache.flink.core.fs.Path`.
I think generally, the new `java.nio.file.Path` has many advantages over the old interfaces -- in this case, the nicer `resolve` method. I can think of a couple of ways to address this:
1. Add a `fromLocal(java.nio.file.Path in)` to `org.apache.flink.core.fs.Path`, or
2. Change the test case to use the `new org.apache.flink.core.fs.Path(URI uri)` constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1014228413
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java:
##########
@@ -126,7 +126,7 @@ class ParquetColumnarRowInputFormatTest {
new MapType(new IntType(), new BooleanType()),
RowType.of(new VarCharType(VarCharType.MAX_LENGTH), new IntType()));
- @TempDir private java.io.File folder;
Review Comment:
Yes, it should be changed because you're introducing a code change in this PR that you fix in the very same PR but a separate commit. This generates unnecessary diffs. But admittedly, we can just squash the two commits into one, anyway. So, I'm gonna go ahead with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1014227896
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/avro/AvroParquetFileReadITCase.java:
##########
@@ -79,14 +92,14 @@ public static void setup() throws IOException {
createParquetFile(
AvroParquetWriters.forGenericRecord(schema),
- Path.fromLocalFile(TEMPORARY_FOLDER.newFile(USER_PARQUET_FILE_1)),
+ Path.fromLocalFile(temporaryFolder.resolve(USER_PARQUET_FILE_1).toFile()),
Review Comment:
ha, true... I missed that. Nevermind! 8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #20230: [FLINK-28449][tests][JUnit5 migration] flink-parquet
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #20230:
URL: https://github.com/apache/flink/pull/20230#issuecomment-1303836863
I created FLINK-29893 to cover the build failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org