You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "soumyakanti3578 (via GitHub)" <gi...@apache.org> on 2023/05/16 23:33:31 UTC
[GitHub] [hive] soumyakanti3578 opened a new pull request, #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
soumyakanti3578 opened a new pull request, #4330:
URL: https://github.com/apache/hive/pull/4330
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Move loadSource method out of Udf to Exec. Now hplsql() function will have stored procedure as the last argument.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This removes HMS dependency from Udf as stored procedure is now an argument to the hplsql function
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4330:
URL: https://github.com/apache/hive/pull/4330#issuecomment-1573178984
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4330)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4330:
URL: https://github.com/apache/hive/pull/4330#issuecomment-1550727105
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4330)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4330:
URL: https://github.com/apache/hive/pull/4330#issuecomment-1577833130
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4330)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] soumyakanti3578 commented on a diff in pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "soumyakanti3578 (via GitHub)" <gi...@apache.org>.
soumyakanti3578 commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1213702972
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1870,12 +1878,30 @@ private boolean execUserSql(HplsqlParser.Expr_func_paramsContext ctx, String nam
sql.append(", ");
}
}
- sql.append(")");
+ sql.append(", \"");
+ sql.append(getStoredProcedure(name.toUpperCase()));
Review Comment:
I think this is handled in the beginning of the method, [here](https://github.com/apache/hive/blob/7cd3107a76d633ef5fae2ffb8ec16953ac968092/hplsql/src/main/java/org/apache/hive/hplsql/Exec.java#L1849). It ultimately calls [this method](https://github.com/apache/hive/blob/7cd3107a76d633ef5fae2ffb8ec16953ac968092/hplsql/src/main/java/org/apache/hive/hplsql/functions/HmsFunctionRegistry.java#L148), and checks that the function is present. Since they both are using the same HMS API, I think this shouldn't be an issue, but let me know if we still need to check something here. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4330:
URL: https://github.com/apache/hive/pull/4330#issuecomment-1593366483
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4330)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4330:
URL: https://github.com/apache/hive/pull/4330#issuecomment-1553928250
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4330)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] mdayakar commented on a diff in pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "mdayakar (via GitHub)" <gi...@apache.org>.
mdayakar commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1201532676
##########
hplsql/src/main/java/org/apache/hive/hplsql/udf/Udf.java:
##########
@@ -66,48 +64,25 @@ public ObjectInspector initialize(ObjectInspector[] arguments) throws UDFArgumen
if (!(arguments[0] instanceof StringObjectInspector)) {
Review Comment:
Now it requires minimum two arguments so validation can be changed. Also second argument should be StringObjectInspector type so this check can also be added.
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1870,12 +1878,30 @@ private boolean execUserSql(HplsqlParser.Expr_func_paramsContext ctx, String nam
sql.append(", ");
}
}
- sql.append(")");
+ sql.append(", \"");
+ sql.append(getStoredProcedure(name.toUpperCase()));
Review Comment:
What will happen if `getStoredProcedure(name.toUpperCase()) `returns null (in case the function is not registered as a HPL/SQL function). I feel this scenario is not handled, please check once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] mdayakar commented on a diff in pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "mdayakar (via GitHub)" <gi...@apache.org>.
mdayakar commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1217702875
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1870,12 +1878,30 @@ private boolean execUserSql(HplsqlParser.Expr_func_paramsContext ctx, String nam
sql.append(", ");
}
}
- sql.append(")");
+ sql.append(", \"");
+ sql.append(getStoredProcedure(name.toUpperCase()));
Review Comment:
Can you test a scenario like in HPL/SQL procedure/function you can use any Hive built-in function and check whether it works or not. Because [here](https://github.com/apache/hive/pull/4330/files#diff-7f870ba54791ec47f97a12f0b100d31a26527e5434a304edd61cb63ef9fb4596L108) earlier they were checking like if _functionDefinition_ null then they treat it as a built-in function and execute. So just once check this scenario, if it works then its fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] soumyakanti3578 commented on a diff in pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "soumyakanti3578 (via GitHub)" <gi...@apache.org>.
soumyakanti3578 commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1219958089
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1870,12 +1878,30 @@ private boolean execUserSql(HplsqlParser.Expr_func_paramsContext ctx, String nam
sql.append(", ");
}
}
- sql.append(")");
+ sql.append(", \"");
+ sql.append(getStoredProcedure(name.toUpperCase()));
Review Comment:
From my understanding, if we don't use a procedure and use just a udf instead, it will take a different code path, i.e., it won't use the hplsql udf. But, I have added two tests to check that udfs work well in hplsql mode. Please review again. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz merged pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "kasakrisz (via GitHub)" <gi...@apache.org>.
kasakrisz merged PR #4330:
URL: https://github.com/apache/hive/pull/4330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4330:
URL: https://github.com/apache/hive/pull/4330#issuecomment-1552250378
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4330)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on a diff in pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "kasakrisz (via GitHub)" <gi...@apache.org>.
kasakrisz commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1197744904
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1822,8 +1826,12 @@ public List<Table> intoTables(ParserRuleContext ctx, List<String> names) {
* User-defined function in a SQL query
*/
public void execSql(String name, HplsqlParser.Expr_func_paramsContext ctx) {
- if (execUserSql(ctx, name)) {
- return;
+ try {
+ if (execUserSql(ctx, name)) {
+ return;
+ }
+ } catch (TException e) {
+ throw new HplValidationException(ctx, ExceptionUtils.getStackTrace(e));
Review Comment:
What is the reason not to extend `HplValidationException` with a constructor which receives `Throwable cause` to wrap the original exception?
##########
hplsql/src/main/java/org/apache/hive/hplsql/udf/Udf.java:
##########
@@ -66,48 +64,23 @@ public ObjectInspector initialize(ObjectInspector[] arguments) throws UDFArgumen
if (!(arguments[0] instanceof StringObjectInspector)) {
throw new UDFArgumentException("First argument must be a string");
}
- SessionState sessionState = SessionState.get();
- if (sessionState != null) {
- // we are still in HiveServer, get the source of the HplSQL function and store it.
- functionDefinition = loadSource(sessionState, functionName(arguments[0]));
- }
queryOI = (StringObjectInspector)arguments[0];
+ funcDefOI = (StringObjectInspector)arguments[arguments.length-1];
argumentsOI = arguments;
return PrimitiveObjectInspectorFactory.javaStringObjectInspector;
}
- protected String loadSource(SessionState sessionState, String functionName) throws UDFArgumentException {
- Exec exec = sessionState.getDynamicVar(Exec.class);
- try {
- StoredProcedure storedProcedure = exec.getMsc().getStoredProcedure(
- new StoredProcedureRequest(
- SessionState.get().getCurrentCatalog(),
- SessionState.get().getCurrentDatabase(),
- functionName));
- return storedProcedure != null ? storedProcedure.getSource() : null;
- } catch (TException e) {
- throw new UDFArgumentException(e);
- }
- }
-
- protected String functionName(ObjectInspector argument) {
- ConstantObjectInspector inspector = (ConstantObjectInspector) (argument);
- String functionCall = inspector.getWritableConstantValue().toString();
- return functionCall.split("\\(")[0].toUpperCase();
- }
-
/**
* Execute UDF
*/
@Override
public Object evaluate(DeferredObject[] arguments) throws HiveException {
- if (exec == null) {
- exec = new Exec();
Review Comment:
I saw that initializing the `Exec` instance is moved to the constructor of `Udf`. Could you please elaborate this change?
##########
hplsql/src/main/java/org/apache/hive/hplsql/udf/Udf.java:
##########
@@ -66,48 +64,23 @@ public ObjectInspector initialize(ObjectInspector[] arguments) throws UDFArgumen
if (!(arguments[0] instanceof StringObjectInspector)) {
throw new UDFArgumentException("First argument must be a string");
}
- SessionState sessionState = SessionState.get();
- if (sessionState != null) {
- // we are still in HiveServer, get the source of the HplSQL function and store it.
- functionDefinition = loadSource(sessionState, functionName(arguments[0]));
- }
queryOI = (StringObjectInspector)arguments[0];
+ funcDefOI = (StringObjectInspector)arguments[arguments.length-1];
argumentsOI = arguments;
return PrimitiveObjectInspectorFactory.javaStringObjectInspector;
}
- protected String loadSource(SessionState sessionState, String functionName) throws UDFArgumentException {
- Exec exec = sessionState.getDynamicVar(Exec.class);
- try {
- StoredProcedure storedProcedure = exec.getMsc().getStoredProcedure(
- new StoredProcedureRequest(
- SessionState.get().getCurrentCatalog(),
- SessionState.get().getCurrentDatabase(),
- functionName));
- return storedProcedure != null ? storedProcedure.getSource() : null;
- } catch (TException e) {
- throw new UDFArgumentException(e);
- }
- }
-
- protected String functionName(ObjectInspector argument) {
- ConstantObjectInspector inspector = (ConstantObjectInspector) (argument);
- String functionCall = inspector.getWritableConstantValue().toString();
- return functionCall.split("\\(")[0].toUpperCase();
- }
-
/**
* Execute UDF
*/
@Override
public Object evaluate(DeferredObject[] arguments) throws HiveException {
- if (exec == null) {
- exec = new Exec();
- exec.setQueryExecutor(QueryExecutor.DISABLED);
- exec.init();
- if (functionDefinition != null) { // if it's null, it can be a built-in function
- exec.parseAndEval(Arguments.script(functionDefinition));
- }
+ if (functionDefinition == null) { // if it's null, it can be a built-in function
+ int idx = arguments.length-1;
+ setParameterForPrimitiveTypeArgument(":" + idx, arguments[idx].get(), funcDefOI);
+ functionDefinition = funcDefOI.getPrimitiveJavaObject(arguments[idx].get());
+ LOG.info("functionDefinition: {}", functionDefinition);
Review Comment:
Does `info` level is necessary? What happens if the function is called on a 1M record table on each row?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] soumyakanti3578 commented on a diff in pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "soumyakanti3578 (via GitHub)" <gi...@apache.org>.
soumyakanti3578 commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1198334353
##########
hplsql/src/main/java/org/apache/hive/hplsql/udf/Udf.java:
##########
@@ -66,48 +64,23 @@ public ObjectInspector initialize(ObjectInspector[] arguments) throws UDFArgumen
if (!(arguments[0] instanceof StringObjectInspector)) {
throw new UDFArgumentException("First argument must be a string");
}
- SessionState sessionState = SessionState.get();
- if (sessionState != null) {
- // we are still in HiveServer, get the source of the HplSQL function and store it.
- functionDefinition = loadSource(sessionState, functionName(arguments[0]));
- }
queryOI = (StringObjectInspector)arguments[0];
+ funcDefOI = (StringObjectInspector)arguments[arguments.length-1];
argumentsOI = arguments;
return PrimitiveObjectInspectorFactory.javaStringObjectInspector;
}
- protected String loadSource(SessionState sessionState, String functionName) throws UDFArgumentException {
- Exec exec = sessionState.getDynamicVar(Exec.class);
- try {
- StoredProcedure storedProcedure = exec.getMsc().getStoredProcedure(
- new StoredProcedureRequest(
- SessionState.get().getCurrentCatalog(),
- SessionState.get().getCurrentDatabase(),
- functionName));
- return storedProcedure != null ? storedProcedure.getSource() : null;
- } catch (TException e) {
- throw new UDFArgumentException(e);
- }
- }
-
- protected String functionName(ObjectInspector argument) {
- ConstantObjectInspector inspector = (ConstantObjectInspector) (argument);
- String functionCall = inspector.getWritableConstantValue().toString();
- return functionCall.split("\\(")[0].toUpperCase();
- }
-
/**
* Execute UDF
*/
@Override
public Object evaluate(DeferredObject[] arguments) throws HiveException {
- if (exec == null) {
- exec = new Exec();
- exec.setQueryExecutor(QueryExecutor.DISABLED);
- exec.init();
- if (functionDefinition != null) { // if it's null, it can be a built-in function
- exec.parseAndEval(Arguments.script(functionDefinition));
- }
+ if (functionDefinition == null) { // if it's null, it can be a built-in function
+ int idx = arguments.length-1;
+ setParameterForPrimitiveTypeArgument(":" + idx, arguments[idx].get(), funcDefOI);
+ functionDefinition = funcDefOI.getPrimitiveJavaObject(arguments[idx].get());
+ LOG.info("functionDefinition: {}", functionDefinition);
Review Comment:
I will change it to DEBUG 👍🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] soumyakanti3578 commented on a diff in pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "soumyakanti3578 (via GitHub)" <gi...@apache.org>.
soumyakanti3578 commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1198334021
##########
hplsql/src/main/java/org/apache/hive/hplsql/udf/Udf.java:
##########
@@ -66,48 +64,23 @@ public ObjectInspector initialize(ObjectInspector[] arguments) throws UDFArgumen
if (!(arguments[0] instanceof StringObjectInspector)) {
throw new UDFArgumentException("First argument must be a string");
}
- SessionState sessionState = SessionState.get();
- if (sessionState != null) {
- // we are still in HiveServer, get the source of the HplSQL function and store it.
- functionDefinition = loadSource(sessionState, functionName(arguments[0]));
- }
queryOI = (StringObjectInspector)arguments[0];
+ funcDefOI = (StringObjectInspector)arguments[arguments.length-1];
argumentsOI = arguments;
return PrimitiveObjectInspectorFactory.javaStringObjectInspector;
}
- protected String loadSource(SessionState sessionState, String functionName) throws UDFArgumentException {
- Exec exec = sessionState.getDynamicVar(Exec.class);
- try {
- StoredProcedure storedProcedure = exec.getMsc().getStoredProcedure(
- new StoredProcedureRequest(
- SessionState.get().getCurrentCatalog(),
- SessionState.get().getCurrentDatabase(),
- functionName));
- return storedProcedure != null ? storedProcedure.getSource() : null;
- } catch (TException e) {
- throw new UDFArgumentException(e);
- }
- }
-
- protected String functionName(ObjectInspector argument) {
- ConstantObjectInspector inspector = (ConstantObjectInspector) (argument);
- String functionCall = inspector.getWritableConstantValue().toString();
- return functionCall.split("\\(")[0].toUpperCase();
- }
-
/**
* Execute UDF
*/
@Override
public Object evaluate(DeferredObject[] arguments) throws HiveException {
- if (exec == null) {
- exec = new Exec();
Review Comment:
Yeah, it was mostly because it looks odd init-ing Exec in `evaluate` method. It was getting initialized only once anyway, so it's better to move it to the constructor of Udf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] soumyakanti3578 commented on a diff in pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "soumyakanti3578 (via GitHub)" <gi...@apache.org>.
soumyakanti3578 commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1198338463
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1822,8 +1826,12 @@ public List<Table> intoTables(ParserRuleContext ctx, List<String> names) {
* User-defined function in a SQL query
*/
public void execSql(String name, HplsqlParser.Expr_func_paramsContext ctx) {
- if (execUserSql(ctx, name)) {
- return;
+ try {
+ if (execUserSql(ctx, name)) {
+ return;
+ }
+ } catch (TException e) {
+ throw new HplValidationException(ctx, ExceptionUtils.getStackTrace(e));
Review Comment:
I will do it 👍🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] soumyakanti3578 commented on a diff in pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "soumyakanti3578 (via GitHub)" <gi...@apache.org>.
soumyakanti3578 commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1213696680
##########
hplsql/src/main/java/org/apache/hive/hplsql/udf/Udf.java:
##########
@@ -66,48 +64,25 @@ public ObjectInspector initialize(ObjectInspector[] arguments) throws UDFArgumen
if (!(arguments[0] instanceof StringObjectInspector)) {
Review Comment:
Thanks for pointing this out! I will update this and also the check just before this to check for minimum 2 arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on a diff in pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "kasakrisz (via GitHub)" <gi...@apache.org>.
kasakrisz commented on code in PR #4330:
URL: https://github.com/apache/hive/pull/4330#discussion_r1230385242
##########
hplsql/src/main/java/org/apache/hive/hplsql/udf/Udf.java:
##########
@@ -37,77 +33,59 @@
import org.apache.hive.hplsql.Scope;
import org.apache.hive.hplsql.Var;
import org.apache.hive.hplsql.executor.QueryExecutor;
-import org.apache.thrift.TException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
-@Description(name = "hplsql", value = "_FUNC_('query' [, :1, :2, ...n]) - Execute HPL/SQL query", extended = "Example:\n" + " > SELECT _FUNC_('CURRENT_DATE') FROM src LIMIT 1;\n")
+@Description(name = "hplsql", value = "_FUNC_('query' [, :1, :2, ...n], 'storedProcedure') - Execute HPL/SQL query",
+ extended = "Example:\n" + " > SELECT _FUNC_('CURRENT_DATE') FROM src LIMIT 1;\n")
@UDFType(deterministic = false)
public class Udf extends GenericUDF {
public static String NAME = "hplsql";
- transient Exec exec;
- StringObjectInspector queryOI;
- ObjectInspector[] argumentsOI;
- private String functionDefinition;
+ private final transient Exec exec = new Exec();
+ private StringObjectInspector queryOI;
+ private ObjectInspector[] argumentsOI;
+ private StringObjectInspector funcDefOI;
+ private String functionDefinition = null;
+ private static final Logger LOG = LoggerFactory.getLogger(Udf.class.getName());
public Udf() {
- }
-
- public Udf(Exec exec) {
- this.exec = exec;
+ exec.setQueryExecutor(QueryExecutor.DISABLED);
+ exec.init();
}
/**
* Initialize UDF
*/
@Override
public ObjectInspector initialize(ObjectInspector[] arguments) throws UDFArgumentException {
- if (arguments.length == 0) {
- throw new UDFArgumentLengthException("At least one argument must be specified");
+ if (arguments.length < 2) {
+ throw new UDFArgumentLengthException("At least two arguments must be specified");
}
if (!(arguments[0] instanceof StringObjectInspector)) {
throw new UDFArgumentException("First argument must be a string");
}
- SessionState sessionState = SessionState.get();
- if (sessionState != null) {
- // we are still in HiveServer, get the source of the HplSQL function and store it.
- functionDefinition = loadSource(sessionState, functionName(arguments[0]));
+ if (!(arguments[arguments.length-1] instanceof StringObjectInspector)) {
+ throw new UDFArgumentException("Last argument (stored procedure) must be a string");
}
queryOI = (StringObjectInspector)arguments[0];
+ funcDefOI = (StringObjectInspector)arguments[arguments.length-1];
argumentsOI = arguments;
return PrimitiveObjectInspectorFactory.javaStringObjectInspector;
}
- protected String loadSource(SessionState sessionState, String functionName) throws UDFArgumentException {
- Exec exec = sessionState.getDynamicVar(Exec.class);
- try {
- StoredProcedure storedProcedure = exec.getMsc().getStoredProcedure(
- new StoredProcedureRequest(
- SessionState.get().getCurrentCatalog(),
- SessionState.get().getCurrentDatabase(),
- functionName));
- return storedProcedure != null ? storedProcedure.getSource() : null;
- } catch (TException e) {
- throw new UDFArgumentException(e);
- }
- }
-
- protected String functionName(ObjectInspector argument) {
- ConstantObjectInspector inspector = (ConstantObjectInspector) (argument);
- String functionCall = inspector.getWritableConstantValue().toString();
- return functionCall.split("\\(")[0].toUpperCase();
- }
-
/**
* Execute UDF
*/
@Override
public Object evaluate(DeferredObject[] arguments) throws HiveException {
- if (exec == null) {
- exec = new Exec();
- exec.setQueryExecutor(QueryExecutor.DISABLED);
- exec.init();
- if (functionDefinition != null) { // if it's null, it can be a built-in function
- exec.parseAndEval(Arguments.script(functionDefinition));
+ if (functionDefinition == null) { // if it's null, it can be a built-in function
+ int idx = arguments.length-1;
+ setParameterForPrimitiveTypeArgument(":" + idx, arguments[idx].get(), funcDefOI);
+ functionDefinition = funcDefOI.getPrimitiveJavaObject(arguments[idx].get());
+ if (LOG.isDebugEnabled()) {
Review Comment:
This check is unnecessary. Please remove it.
##########
hplsql/src/main/java/org/apache/hive/hplsql/udf/Udf.java:
##########
@@ -37,77 +33,59 @@
import org.apache.hive.hplsql.Scope;
import org.apache.hive.hplsql.Var;
import org.apache.hive.hplsql.executor.QueryExecutor;
-import org.apache.thrift.TException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
-@Description(name = "hplsql", value = "_FUNC_('query' [, :1, :2, ...n]) - Execute HPL/SQL query", extended = "Example:\n" + " > SELECT _FUNC_('CURRENT_DATE') FROM src LIMIT 1;\n")
+@Description(name = "hplsql", value = "_FUNC_('query' [, :1, :2, ...n], 'storedProcedure') - Execute HPL/SQL query",
+ extended = "Example:\n" + " > SELECT _FUNC_('CURRENT_DATE') FROM src LIMIT 1;\n")
@UDFType(deterministic = false)
public class Udf extends GenericUDF {
public static String NAME = "hplsql";
- transient Exec exec;
- StringObjectInspector queryOI;
- ObjectInspector[] argumentsOI;
- private String functionDefinition;
+ private final transient Exec exec = new Exec();
+ private StringObjectInspector queryOI;
+ private ObjectInspector[] argumentsOI;
+ private StringObjectInspector funcDefOI;
+ private String functionDefinition = null;
+ private static final Logger LOG = LoggerFactory.getLogger(Udf.class.getName());
Review Comment:
nit.: static field declarations especially logger is usually the first in the class.
##########
hplsql/src/main/java/org/apache/hive/hplsql/udf/Udf.java:
##########
@@ -121,11 +99,20 @@ public Object evaluate(DeferredObject[] arguments) throws HiveException {
}
}
+ /**
+ * Getter for Exec object
+ *
+ * @return Exec
+ */
+ public Exec getExec() {
+ return this.exec;
+ }
+
/**
* Set parameters for the current call
*/
void setParameters(DeferredObject[] arguments) throws HiveException {
- for (int i = 1; i < arguments.length; i++) {
+ for (int i = 1; i < arguments.length-1; i++) {
Review Comment:
nit.:
```
arguments.length - 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4330: HIVE-27349: Move HMS call to get stored procedure out of Udf
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4330:
URL: https://github.com/apache/hive/pull/4330#issuecomment-1592612192
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4330)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4330&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4330&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4330&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org