You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/03/01 00:10:56 UTC

[GitHub] incubator-brooklyn pull request: Improve CLI customisability for d...

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/536

    Improve CLI customisability for downstream projects

    - Make ASCII art banner customisable
    - Make info command customisable
    - Remove redundant duplicate Main.cliScriptName, as already declared in AbstractMain
    - Adds tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn feature/customizable-banner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/536.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #536
    
----
commit fdf4bd34e5765f90862930dd5a5bca4d52d0d79a
Author: Aled Sage <al...@gmail.com>
Date:   2015-02-28T23:09:27Z

    Improve CLI customisability for downstream projects
    
    - Make ASCII art banner customisable
    - Make info command customisable
    - Remove redundant duplicate Main.cliScriptName, as already declared
      in AbstractMain
    - Adds tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Improve CLI customisability for d...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/536


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Improve CLI customisability for d...

Posted by nakomis <gi...@git.apache.org>.
Github user nakomis commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/536#issuecomment-76925325
  
    LGTM, tests pass


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Improve CLI customisability for d...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/536#issuecomment-76970445
  
    Thanks @ nakomis - merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---