You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/11/24 11:12:50 UTC
[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4295: ARTEMIS-4098 AMQP messages missing correlation ID in console
gemmellr commented on code in PR #4295:
URL: https://github.com/apache/activemq-artemis/pull/4295#discussion_r1031388599
##########
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java:
##########
@@ -2285,6 +2287,7 @@ public void testToCompositeDataPropertiesSection() throws Exception {
assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "absoluteExpiryTime" + "=" + testExpiryTime));
assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "to" + "=" + TEST_TO_ADDRESS));
assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "subject" + "=" + testSubject));
+ assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "correlationId" + "=" + testCorrelationId));
Review Comment:
This makes the comment below further inaccurate. It already was since the reply-to field was added without any test in https://github.com/apache/activemq-artemis/commit/cbd8df6459b01f816d922efb967800bf020b4e6a
##########
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java:
##########
@@ -2285,6 +2287,7 @@ public void testToCompositeDataPropertiesSection() throws Exception {
assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "absoluteExpiryTime" + "=" + testExpiryTime));
assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "to" + "=" + TEST_TO_ADDRESS));
assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "subject" + "=" + testSubject));
+ assertTrue(properties.contains(PROPERTY_MAP_PROPERTIES_PREFIX + "correlationId" + "=" + testCorrelationId));
Review Comment:
This makes the comment below it further inaccurate. It already was since the reply-to field was added without any test in https://github.com/apache/activemq-artemis/commit/cbd8df6459b01f816d922efb967800bf020b4e6a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org