You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/06 10:28:50 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #156: test: add one more e2e case
tokers opened a new pull request #156:
URL: https://github.com/apache/apisix-ingress-controller/pull/156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #156: test: add one more e2e case
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #156:
URL: https://github.com/apache/apisix-ingress-controller/pull/156#issuecomment-755219211
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=h1) Report
> Merging [#156](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=desc) (77d22fa) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/33ceff08b011b70297c787bafd56e974071c6216?el=desc) (33ceff0) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #156 +/- ##
=======================================
Coverage 50.21% 50.21%
=======================================
Files 30 30
Lines 1414 1414
=======================================
Hits 710 710
Misses 620 620
Partials 84 84
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=footer). Last update [33ceff0...77d22fa](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #156: test: add one more e2e case
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #156:
URL: https://github.com/apache/apisix-ingress-controller/pull/156#discussion_r554294412
##########
File path: test/e2e/scaffold/crd.go
##########
@@ -160,9 +160,6 @@ func (s *Scaffold) EnsureNumApisixUpstreamsCreated(desired int) error {
// ListApisixUpstreams list all upstream from APISIX
func (s *Scaffold) ListApisixUpstreams() ([]*v1.Upstream, error) {
host, err := s.apisixAdminServiceURL()
- if err != nil {
Review comment:
Oh, it's removed by accidentally.
##########
File path: test/e2e/scaffold/crd.go
##########
@@ -160,9 +160,6 @@ func (s *Scaffold) EnsureNumApisixUpstreamsCreated(desired int) error {
// ListApisixUpstreams list all upstream from APISIX
func (s *Scaffold) ListApisixUpstreams() ([]*v1.Upstream, error) {
host, err := s.apisixAdminServiceURL()
- if err != nil {
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #156: test: add one more e2e case
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #156:
URL: https://github.com/apache/apisix-ingress-controller/pull/156#discussion_r554294463
##########
File path: test/e2e/scaffold/crd.go
##########
@@ -160,9 +160,6 @@ func (s *Scaffold) EnsureNumApisixUpstreamsCreated(desired int) error {
// ListApisixUpstreams list all upstream from APISIX
func (s *Scaffold) ListApisixUpstreams() ([]*v1.Upstream, error) {
host, err := s.apisixAdminServiceURL()
- if err != nil {
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #156: test: add one more e2e case
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #156:
URL: https://github.com/apache/apisix-ingress-controller/pull/156#discussion_r554294412
##########
File path: test/e2e/scaffold/crd.go
##########
@@ -160,9 +160,6 @@ func (s *Scaffold) EnsureNumApisixUpstreamsCreated(desired int) error {
// ListApisixUpstreams list all upstream from APISIX
func (s *Scaffold) ListApisixUpstreams() ([]*v1.Upstream, error) {
host, err := s.apisixAdminServiceURL()
- if err != nil {
Review comment:
Oh, it's removed by accidentally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #156: test: add one more e2e case
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #156:
URL: https://github.com/apache/apisix-ingress-controller/pull/156#issuecomment-755219211
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=h1) Report
> Merging [#156](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=desc) (fc30214) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/2a8e8a70fe34790c3eb54db22890e466ea0643d1?el=desc) (2a8e8a7) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #156 +/- ##
=======================================
Coverage 34.55% 34.55%
=======================================
Files 28 28
Lines 1314 1314
=======================================
Hits 454 454
Misses 830 830
Partials 30 30
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=footer). Last update [2a8e8a7...fc30214](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #156: test: add one more e2e case
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #156:
URL: https://github.com/apache/apisix-ingress-controller/pull/156#discussion_r554277916
##########
File path: test/e2e/scaffold/crd.go
##########
@@ -160,9 +160,6 @@ func (s *Scaffold) EnsureNumApisixUpstreamsCreated(desired int) error {
// ListApisixUpstreams list all upstream from APISIX
func (s *Scaffold) ListApisixUpstreams() ([]*v1.Upstream, error) {
host, err := s.apisixAdminServiceURL()
- if err != nil {
Review comment:
Why remove error check ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #156: test: add one more e2e case
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #156:
URL: https://github.com/apache/apisix-ingress-controller/pull/156#discussion_r554277916
##########
File path: test/e2e/scaffold/crd.go
##########
@@ -160,9 +160,6 @@ func (s *Scaffold) EnsureNumApisixUpstreamsCreated(desired int) error {
// ListApisixUpstreams list all upstream from APISIX
func (s *Scaffold) ListApisixUpstreams() ([]*v1.Upstream, error) {
host, err := s.apisixAdminServiceURL()
- if err != nil {
Review comment:
Why remove error check ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #156: test: add one more e2e case
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #156:
URL: https://github.com/apache/apisix-ingress-controller/pull/156#issuecomment-755219211
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=h1) Report
> Merging [#156](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=desc) (48aef52) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/33ceff08b011b70297c787bafd56e974071c6216?el=desc) (33ceff0) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #156 +/- ##
=======================================
Coverage 50.21% 50.21%
=======================================
Files 30 30
Lines 1414 1414
=======================================
Hits 710 710
Misses 620 620
Partials 84 84
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=footer). Last update [33ceff0...48aef52](https://codecov.io/gh/apache/apisix-ingress-controller/pull/156?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #156: test: add one more e2e case
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #156:
URL: https://github.com/apache/apisix-ingress-controller/pull/156#issuecomment-755219211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #156: test: add one more e2e case
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #156:
URL: https://github.com/apache/apisix-ingress-controller/pull/156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #156: test: add one more e2e case
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #156:
URL: https://github.com/apache/apisix-ingress-controller/pull/156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org