You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/01 22:09:53 UTC
[GitHub] [flink-statefun] igalshilman opened a new pull request #91:
[FLINK-16927][core] Fallback to the legacy scheduler.
igalshilman opened a new pull request #91: [FLINK-16927][core] Fallback to the legacy scheduler.
URL: https://github.com/apache/flink-statefun/pull/91
This PR switches to the legacy scheduler until `FLINK-16139` would be resolved.
See the relevant JIRA issues for details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] asfgit closed pull request #91:
[FLINK-16927][core] Fallback to the legacy scheduler.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #91: [FLINK-16927][core] Fallback to the legacy scheduler.
URL: https://github.com/apache/flink-statefun/pull/91
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request
#91: [FLINK-16927][core] Fallback to the legacy scheduler.
Posted by GitBox <gi...@apache.org>.
tzulitai commented on a change in pull request #91: [FLINK-16927][core] Fallback to the legacy scheduler.
URL: https://github.com/apache/flink-statefun/pull/91#discussion_r402233081
##########
File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/StatefulFunctionsConfigValidator.java
##########
@@ -64,6 +66,14 @@ private static void validateMaxConcurrentCheckpoints(Configuration configuration
}
}
+ private static void validateLegacyScheduler(Configuration configuration) {
+ String configuredScheduler = configuration.get(JobManagerOptions.SCHEDULER);
+ if (!"legacy".equalsIgnoreCase(configuredScheduler)) {
+ throw new StatefulFunctionsInvalidConfigException(
+ JobManagerOptions.SCHEDULER, "Currently the only support scheduler is `legacy`");
Review comment:
```suggestion
JobManagerOptions.SCHEDULER, "Currently the only supported scheduler is `legacy`");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request
#91: [FLINK-16927][core] Fallback to the legacy scheduler.
Posted by GitBox <gi...@apache.org>.
tzulitai commented on a change in pull request #91: [FLINK-16927][core] Fallback to the legacy scheduler.
URL: https://github.com/apache/flink-statefun/pull/91#discussion_r402225904
##########
File path: tools/docker/flink-distribution-template/conf/flink-conf.yaml
##########
@@ -30,3 +30,4 @@ state.backend.rocksdb.timer-service.factory: ROCKSDB
state.checkpoints.dir: file:///checkpoint-dir
state.backend.incremental: true
taskmanager.memory.process.size: 4g
+jobmanager.scheduler: legacy
Review comment:
This should be placed under the first section, where we group all strictly-required configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink-statefun] tzulitai commented on a change in pull request
#91: [FLINK-16927][core] Fallback to the legacy scheduler.
Posted by GitBox <gi...@apache.org>.
tzulitai commented on a change in pull request #91: [FLINK-16927][core] Fallback to the legacy scheduler.
URL: https://github.com/apache/flink-statefun/pull/91#discussion_r402232495
##########
File path: statefun-flink/statefun-flink-harness/src/main/java/org/apache/flink/statefun/flink/harness/Harness.java
##########
@@ -167,5 +168,6 @@ private static void configureStrictlyRequiredFlinkConfigs(Configuration flinkCon
flinkConfig.set(
ExecutionCheckpointingOptions.MAX_CONCURRENT_CHECKPOINTS,
StatefulFunctionsConfigValidator.MAX_CONCURRENT_CHECKPOINTS);
+ flinkConfig.set(JobManagerOptions.SCHEDULER, "legacy");
Review comment:
```suggestion
flinkConfig.set(JobManagerOptions.SCHEDULER, SchedulerNGFactoryFactory.SCHEDULER_TYPE_LEGACY);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services