[GitHub] [arrow-rs] askoa commented on a diff in pull request #3109: object_store: add support for using proxy_url for connection testing

[GitBox <gi...@apache.org>]

askoa commented on code in PR #3109:
URL: https://github.com/apache/arrow-rs/pull/3109#discussion_r1025940409


##########
object_store/src/aws/mod.rs:
##########
@@ -561,6 +571,13 @@ impl AmazonS3Builder {
         let bucket = self.bucket_name.context(MissingBucketNameSnafu)?;
         let region = self.region.context(MissingRegionSnafu)?;
 
+        let clientbuilder = if let Some(url) = self.proxy_url {

Review Comment:
   The better coding pattern is 
   
   ```
   let clientbuilder = match self.proxy_url {
       Some(url) => {},
       None => {}
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org