You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/10/18 06:42:19 UTC
[PR] [SPARK-45553][PS] Deprecate `assertPandasOnSparkEqual` [spark]
itholic opened a new pull request, #43426:
URL: https://github.com/apache/spark/pull/43426
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR proposes to deprecate `assertPandasOnSparkEqual`.
### Why are the changes needed?
Now we have more pandas friendly testing utils such as `ps.testing.assert_frame_equal`, `ps.testing.assert_series_equal` and `ps.testing.assert_index_equal`.
### Does this PR introduce _any_ user-facing change?
Not for now, but `assertPandasOnSparkEqual` will be removed in the future version.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
The existing CI should pass.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45553][PS] Deprecate `assertPandasOnSparkEqual` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43426:
URL: https://github.com/apache/spark/pull/43426#discussion_r1366275157
##########
python/pyspark/testing/pandasutils.py:
##########
@@ -341,6 +341,11 @@ def assertPandasOnSparkEqual(
.. versionadded:: 3.5.0
+ .. deprecated:: 3.5.1
+ `assertPandasOnSparkEqual` will be removed in Spark 4.0.0.
+ Use `ps.testing.assert_frame_equal`, `ps.testing.assert_series_equal`
+ and `ps.testing.assert_index_equal` instead.
Review Comment:
@itholic let's remove this in branch-3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45553][PS] Deprecate `assertPandasOnSparkEqual` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #43426:
URL: https://github.com/apache/spark/pull/43426#discussion_r1366297314
##########
python/pyspark/testing/pandasutils.py:
##########
@@ -341,6 +341,11 @@ def assertPandasOnSparkEqual(
.. versionadded:: 3.5.0
+ .. deprecated:: 3.5.1
+ `assertPandasOnSparkEqual` will be removed in Spark 4.0.0.
+ Use `ps.testing.assert_frame_equal`, `ps.testing.assert_series_equal`
+ and `ps.testing.assert_index_equal` instead.
Review Comment:
Thanks for catching it out. Just created followup here: https://github.com/apache/spark/pull/43459.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45553][PS] Deprecate `assertPandasOnSparkEqual` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43426: [SPARK-45553][PS] Deprecate `assertPandasOnSparkEqual`
URL: https://github.com/apache/spark/pull/43426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45553][PS] Deprecate `assertPandasOnSparkEqual` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43426:
URL: https://github.com/apache/spark/pull/43426#discussion_r1363416342
##########
python/pyspark/testing/pandasutils.py:
##########
@@ -340,6 +340,10 @@ def assertPandasOnSparkEqual(
(pandas-on-Spark or pandas object).
.. versionadded:: 3.5.0
+ .. deprecated:: 4.0.0
Review Comment:
can we issue a deprecation warning too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45553][PS] Deprecate `assertPandasOnSparkEqual` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43426:
URL: https://github.com/apache/spark/pull/43426#discussion_r1363415920
##########
python/pyspark/testing/pandasutils.py:
##########
@@ -340,6 +340,10 @@ def assertPandasOnSparkEqual(
(pandas-on-Spark or pandas object).
.. versionadded:: 3.5.0
Review Comment:
```suggestion
.. versionadded:: 3.5.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45553][PS] Deprecate `assertPandasOnSparkEqual` [spark]
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on code in PR #43426:
URL: https://github.com/apache/spark/pull/43426#discussion_r1366272291
##########
python/pyspark/testing/pandasutils.py:
##########
@@ -341,6 +341,11 @@ def assertPandasOnSparkEqual(
.. versionadded:: 3.5.0
+ .. deprecated:: 3.5.1
+ `assertPandasOnSparkEqual` will be removed in Spark 4.0.0.
+ Use `ps.testing.assert_frame_equal`, `ps.testing.assert_series_equal`
+ and `ps.testing.assert_index_equal` instead.
Review Comment:
Seems like these functions don't exist `branch-3.5`. Will they be backported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45553][PS] Deprecate `assertPandasOnSparkEqual` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #43426:
URL: https://github.com/apache/spark/pull/43426#discussion_r1364127103
##########
python/pyspark/testing/pandasutils.py:
##########
@@ -340,6 +340,10 @@ def assertPandasOnSparkEqual(
(pandas-on-Spark or pandas object).
.. versionadded:: 3.5.0
+ .. deprecated:: 4.0.0
Review Comment:
If this is added at 3.5.0, can we deprecated at 3.5.1 instead of 4.0.0 because it's not used widely yet, @HyukjinKwon and @itholic ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45553][PS] Deprecate `assertPandasOnSparkEqual` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #43426:
URL: https://github.com/apache/spark/pull/43426#discussion_r1364745330
##########
python/pyspark/testing/pandasutils.py:
##########
@@ -340,6 +340,10 @@ def assertPandasOnSparkEqual(
(pandas-on-Spark or pandas object).
.. versionadded:: 3.5.0
+ .. deprecated:: 4.0.0
Review Comment:
Oh, it sounds reasonable to me if it's not violate the release policy.
@HyukjinKwon Let me change the number for now, so please let me know if you have other opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45553][PS] Deprecate `assertPandasOnSparkEqual` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43426:
URL: https://github.com/apache/spark/pull/43426#discussion_r1364876401
##########
python/pyspark/testing/pandasutils.py:
##########
@@ -340,6 +340,10 @@ def assertPandasOnSparkEqual(
(pandas-on-Spark or pandas object).
.. versionadded:: 3.5.0
+ .. deprecated:: 4.0.0
Review Comment:
SGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45553][PS] Deprecate `assertPandasOnSparkEqual` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43426:
URL: https://github.com/apache/spark/pull/43426#issuecomment-1769943645
Merged to master and branch-3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45553][PS] Deprecate `assertPandasOnSparkEqual` [spark]
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #43426:
URL: https://github.com/apache/spark/pull/43426#discussion_r1363712998
##########
python/pyspark/testing/pandasutils.py:
##########
@@ -340,6 +340,10 @@ def assertPandasOnSparkEqual(
(pandas-on-Spark or pandas object).
.. versionadded:: 3.5.0
+ .. deprecated:: 4.0.0
Review Comment:
Updated. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org