You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "maedhroz (via GitHub)" <gi...@apache.org> on 2023/02/16 23:39:29 UTC
[GitHub] [cassandra] maedhroz commented on a diff in pull request #2164: Fix statement validation against partition range queries
maedhroz commented on code in PR #2164:
URL: https://github.com/apache/cassandra/pull/2164#discussion_r1109131996
##########
src/java/org/apache/cassandra/cql3/restrictions/StatementRestrictions.java:
##########
@@ -833,12 +833,22 @@ private void validateSecondaryIndexSelections()
* @return <code>true</code> if all the primary key columns are restricted by an equality relation.
*/
public boolean hasAllPKColumnsRestrictedByEqualities()
Review Comment:
```suggestion
public boolean hasAllPrimaryKeyColumnsRestrictedByEqualities()
```
Might as well go for the full name w/ `hasAllPartitionKeyColumnsRestrictedByEqualities()` doing the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org