You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2026/01/29 18:08:32 UTC
[PR] only initializes vfs when deprecated prop is set [accumulo]
keith-turner opened a new pull request, #6097:
URL: https://github.com/apache/accumulo/pull/6097
When the property `general.vfs.classpaths` was not set VFS was still unnecessarily initialized. Modified to only initialized VFS when the property is actually set.
Tested locally by setting `general.vfs.classpaths=`, `general.dynamic.classpaths=`,
`general.context.class.loader.factory=TestCL`. Where TestCL is a classloader that does nothing. When all of these are set did not see VFS create anything in local filesystem. Had to set some props to empty string because mini accumulo would set them otherwise. Also added some debug logging if VFS was initialized and did not see that. Removed that logging from these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] only initializes vfs when deprecated prop is set [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #6097:
URL: https://github.com/apache/accumulo/pull/6097#issuecomment-3820276272
successfully ran `mvn verify -Psunny`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] only initializes vfs when deprecated prop is set [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #6097:
URL: https://github.com/apache/accumulo/pull/6097#discussion_r2742902700
##########
start/src/main/java/org/apache/accumulo/start/classloader/vfs/AccumuloVFSClassLoader.java:
##########
@@ -204,15 +207,25 @@ private static ClassLoader getClassLoader_Internal() throws IOException {
synchronized (lock) {
if (loader == null) {
- FileSystemManager vfs = generateVfs();
Review Comment:
The main thing this PR is doing is avoiding always calling this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] only initializes vfs when deprecated prop is set [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #6097:
URL: https://github.com/apache/accumulo/pull/6097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org