You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/27 17:03:31 UTC
[GitHub] [incubator-mxnet] barry-jin opened a new pull request #19432: [BUGFIX] Revert "Remove cleanup on side threads (#19378)"
barry-jin opened a new pull request #19432:
URL: https://github.com/apache/incubator-mxnet/pull/19432
## Description ##
Fix #19420
This reverts commit 43750c8bfed6ca91fc47fd1fa6d620197e26c84c.
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19432: [BUGFIX] Revert "Remove cleanup on side threads (#19378)"
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19432:
URL: https://github.com/apache/incubator-mxnet/pull/19432#issuecomment-717387333
Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-gpu, sanity, unix-gpu, website, clang, windows-cpu, edge, centos-cpu, miscellaneous, windows-gpu, unix-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #19432: [BUGFIX] Revert "Remove cleanup on side threads (#19378)"
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #19432:
URL: https://github.com/apache/incubator-mxnet/pull/19432#issuecomment-717422338
> I fail to understand how is this a bugfix. The original commit was introduced as a workaround for #19360 and the issue was raised (#19379) that a better solution should be put in its place. Just reverting it is not such better solution.
>
> Could you provide details on how this commit triggers the issue you are seeing?
Sorry for losing the context of PR #19378 . It's definitely not the best solution. But our current issue #19420 has blocked GluonNLP CI and GluonNLP development. So, this PR is an intermediate solution rather than a bugfix to have Cuda 11 broken on CD and unblock GluonNLP development. I will investigate more to find a better solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sxjscience commented on pull request #19432: [WIP] Revert "Remove cleanup on side threads (#19378)"
Posted by GitBox <gi...@apache.org>.
sxjscience commented on pull request #19432:
URL: https://github.com/apache/incubator-mxnet/pull/19432#issuecomment-717540152
@ptrendx Yeah, I agree with that. I think we will need some time to understand what's happening underneath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #19432: [WIP] Revert "Remove cleanup on side threads (#19378)"
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #19432:
URL: https://github.com/apache/incubator-mxnet/pull/19432#issuecomment-717554934
@ptrendx Thanks. I will update the linked issue with more detailed information after my investigation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19432: [WIP] Revert "Remove cleanup on side threads (#19378)"
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19432:
URL: https://github.com/apache/incubator-mxnet/pull/19432#issuecomment-717511070
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #19432: [WIP] Revert "Remove cleanup on side threads (#19378)"
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #19432:
URL: https://github.com/apache/incubator-mxnet/pull/19432#issuecomment-717539522
@sxjscience Sure, I understand that there is an issue somewhere and I'm happy to help resolve it. That said, neither this PR nor the linked issue explains why the failure happens with that change enabled (I assume here that you verified that a commit just before #19378 passes). If this was about reverting a feature it would be fine, but here we are reverting a bugfix (or bug workaround to be more precise), so I think it makes sense to make sure we understand what is going on here before we reintroduce a problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin closed pull request #19432: [WIP] Revert "Remove cleanup on side threads (#19378)"
Posted by GitBox <gi...@apache.org>.
barry-jin closed pull request #19432:
URL: https://github.com/apache/incubator-mxnet/pull/19432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sxjscience commented on pull request #19432: [WIP] Revert "Remove cleanup on side threads (#19378)"
Posted by GitBox <gi...@apache.org>.
sxjscience commented on pull request #19432:
URL: https://github.com/apache/incubator-mxnet/pull/19432#issuecomment-717506716
Ping also @mseth10 . @ptrendx We are seeing the error described in this issue https://github.com/apache/incubator-mxnet/issues/19420 after upgrading to the latest MXNet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19432: [WIP] Revert "Remove cleanup on side threads (#19378)"
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19432:
URL: https://github.com/apache/incubator-mxnet/pull/19432#issuecomment-717511108
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #19432: [BUGFIX] Revert "Remove cleanup on side threads (#19378)"
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #19432:
URL: https://github.com/apache/incubator-mxnet/pull/19432#issuecomment-717407636
I fail to understand how is this a bugfix. The original commit was introduced as a workaround for #19360 and the issue was raised (#19379) that a better solution should be put in its place. Just reverting it is not such better solution.
Could you provide details on how this commit triggers the issue you are seeing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org