Re: svn commit: r990537 - /subversion/branches/performance/subversion/libsvn_subr/svn_temp_ser ializer.c

[Johan Corveleyn <jc...@gmail.com>]

On Sun, Aug 29, 2010 at 4:36 PM, Daniel Shahaf <d....@daniel.shahaf.name>wrote:

> Johan Corveleyn wrote on Sun, Aug 29, 2010 at 16:24:24 +0200:
> > Hi Stefan,
> >
> > On Sun, Aug 29, 2010 at 12:32 PM,  <st...@apache.org> wrote:
> > > Author: stefan2
> > > Date: Sun Aug 29 10:32:08 2010
> > > New Revision: 990537
> > >
> > > URL: http://svn.apache.org/viewvc?rev=990537&view=rev
> > > Log:
> > > Looking for the cause of Johan Corveleyn's crash (see
> > > http://svn.haxx.se/dev/archive-2010-08/0652.shtml), it
> > > seems that wrong / corrupted data contains backward
> > > pointers, i.e. negative offsets. That cannot happen if
> > > everything works as intended.
> >
> > I've just retried my test after this change (actually with
> > performance-branch@990579, so updated just 10 minutes ago). Now I get
> > the assertion error, after running log or blame on that particular
> > file:
> >
> > [[[
> > $ svnserve -d -r c:/research/svn/experiment/repos
> > Assertion failed: *ptr > buffer, file
> > ..\..\..\subversion\libsvn_subr\svn_temp_serializer.c, line 282
> >
> > This application has requested the Runtime to terminate it in an unusual
> way.
> > Please contact the application's support team for more information.
> > ]]]
> >
> > Is there any way I can find more information about this failure, so I
> > can help you diagnose the problem?
> >
>
> s/assert/SVN_ERR_MALFUNCTION_NO_RETURN/
>


I think you meant SVN_ERR_ASSERT_NO_RETURN.

If I do that, I get:

[[[
$ svnserve -d -r c:/research/svn/experiment/repos
..\..\..\subversion\libsvn_fs_fs\fs_fs.c:2363: (apr_err=235000)
svn: In file '..\..\..\subversion\libsvn_subr\svn_temp_serializer.c' line
282: assertion failed (*ptr > buffer)

This application has requested the Runtime to terminate it in an unusual
way.
Please contact the application's support team for more information.

This application has requested the Runtime to terminate it in an unusual
way.
Please contact the application's support team for more information.
]]]


-- 
Johan