You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "lovepoem (GitHub)" <gi...@apache.org> on 2019/01/02 16:30:04 UTC
[GitHub] [incubator-dubbo] lovepoem opened pull request #3116:
upgrade junit to junit5
## What is the purpose of the change
upgrade junit to junit5
## Brief changelog
test case update
## Verifying this change
ci success
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3116 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] lovepoem closed pull request #3116:
upgrade junit to junit5
Posted by "lovepoem (GitHub)" <gi...@apache.org>.
[ pull request closed by lovepoem ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3116 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] lovepoem closed pull request #3116:
upgrade junit to junit5
Posted by "lovepoem (GitHub)" <gi...@apache.org>.
[ pull request closed by lovepoem ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3116 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3116:
upgrade junit to junit5
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3116?src=pr&el=h1) Report
> Merging [#3116](https://codecov.io/gh/apache/incubator-dubbo/pull/3116?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ddb518de3ab3b54ec4b6a8a52db6cde1b3f58262?src=pr&el=desc) will **decrease** coverage by `63.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3116?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3116 +/- ##
============================================
- Coverage 63.58% 0% -63.59%
============================================
Files 652 652
Lines 28199 28199
Branches 4782 4782
============================================
- Hits 17930 0 -17930
- Misses 8014 28199 +20185
+ Partials 2255 0 -2255
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3116?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...bo/cache/support/threadlocal/ThreadLocalCache.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3116/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC90aHJlYWRsb2NhbC9UaHJlYWRMb2NhbENhY2hlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...in/java/org/apache/dubbo/common/status/Status.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3116/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL1N0YXR1cy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...g/context/properties/DefaultDubboConfigBinder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3116/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9wcm9wZXJ0aWVzL0RlZmF1bHREdWJib0NvbmZpZ0JpbmRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...he/dubbo/remoting/http/servlet/ServletManager.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3116/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctaHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvaHR0cC9zZXJ2bGV0L1NlcnZsZXRNYW5hZ2VyLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...p/exchange/support/MulticastExchangeNetworker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3116/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvZXhjaGFuZ2Uvc3VwcG9ydC9NdWx0aWNhc3RFeGNoYW5nZU5ldHdvcmtlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...e/dubbo/common/serialize/fst/FstSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3116/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWZzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29tbW9uL3NlcmlhbGl6ZS9mc3QvRnN0U2VyaWFsaXphdGlvbi5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...va/com/alibaba/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3116/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbmZpZy9BcHBsaWNhdGlvbkNvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [.../java/com/alibaba/dubbo/config/ArgumentConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3116/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbmZpZy9Bcmd1bWVudENvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...e/support/threadlocal/ThreadLocalCacheFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3116/diff?src=pr&el=tree#diff-ZHViYm8tZmlsdGVyL2R1YmJvLWZpbHRlci1jYWNoZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY2FjaGUvc3VwcG9ydC90aHJlYWRsb2NhbC9UaHJlYWRMb2NhbENhY2hlRmFjdG9yeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...igurator/override/OverrideConfiguratorFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3116/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvY29uZmlndXJhdG9yL292ZXJyaWRlL092ZXJyaWRlQ29uZmlndXJhdG9yRmFjdG9yeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| ... and [546 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3116/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3116?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3116?src=pr&el=footer). Last update [ddb518d...9ae403e](https://codecov.io/gh/apache/incubator-dubbo/pull/3116?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3116 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org