You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Bilung Lee <bl...@gmail.com> on 2012/01/20 21:48:05 UTC
Re: Review Request: SQOOP-406 Update Avro files using OraOop and Oracle
Database
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3195/#review4507
-----------------------------------------------------------
Thanks for the patch! There are some style violations. Could you please fix them? You can find the style violations in "build/checkstyle-errors.html" after running "ant checkstyle".
- Bilung
On 2011-12-14 13:29:10, pieretti antoine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3195/
> -----------------------------------------------------------
>
> (Updated 2011-12-14 13:29:10)
>
>
> Review request for Sqoop.
>
>
> Summary
> -------
>
> Quick fix permits updating avro files. It should be better to mutualized / inheritance code with JdbcExport and other JobBase
>
>
> This addresses bug SQOOP-406.
> https://issues.apache.org/jira/browse/SQOOP-406
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/mapreduce/JdbcUpdateExportJob.java 1214229
>
> Diff: https://reviews.apache.org/r/3195/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> pieretti
>
>